aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src/completion
Commit message (Collapse)AuthorAgeFilesLines
* Use expect_test to make format_str_parser test more data-drivenIgor Aleksanov2020-10-021-35/+35
|
* Use lookup table instead of enum for postfix completion kindsIgor Aleksanov2020-10-021-62/+20
|
* Use ast::String for extracting string literal contentsIgor Aleksanov2020-10-022-14/+19
|
* Improve format-like completions code appearanceIgor Aleksanov2020-10-022-32/+26
|
* Add missing entry to doc-commentIgor Aleksanov2020-10-021-0/+1
|
* Simplify is_string_literal functionIgor Aleksanov2020-10-021-9/+5
|
* Improve checks for postfix suggestionsIgor Aleksanov2020-10-023-16/+23
|
* Add postfix completion for format-like string literalsIgor Aleksanov2020-10-023-1/+376
|
* Merge #6055bors[bot]2020-09-251-0/+5
|\ | | | | | | | | | | | | | | | | | | 6055: Add ok postfix completion r=matklad a=mullr Wrapping values in `Ok(...)` is so pervasive that it seems reasonable for it to have its own postfix completion. Co-authored-by: Russell Mull <[email protected]>
| * Cargo fmtRussell Mull2020-09-221-9/+2
| |
| * Add ok postfix completionRussell Mull2020-09-221-0/+12
| |
* | Merge #6056bors[bot]2020-09-241-0/+12
|\ \ | | | | | | | | | | | | | | | | | | | | | 6056: Add dbgr postfix completion r=matklad a=lnicola Expanding to `dbg!(&e)`. Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Add dbgr postfix completionLaurențiu Nicola2020-09-221-0/+12
| |/
* | Merge #5846bors[bot]2020-09-242-3/+130
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5846: Add references to fn args during completion r=matklad a=adamrk When completing a function call, if there is an argument taken as a ref or mut ref which matches the name and type of a variable in scope, we will insert a `&` or `&mut` when filling in the function arguments. This addresses https://github.com/rust-analyzer/rust-analyzer/issues/5449. E.g. ```rust fn foo(x: &i32) {} fn main() { let x = 5; foo # completing foo here generates `foo(&x)` now instead of `foo(x)` } ``` Co-authored-by: adamrk <[email protected]>
| * Trim mut keyword in fn completionadamrk2020-09-021-1/+22
| |
| * Remove exposing unificationadamrk2020-09-021-1/+1
| |
| * Collect locals in contextadamrk2020-09-022-12/+15
| |
| * Add back Param structadamrk2020-09-011-1/+1
| |
| * Add references to fn args during completionadamrk2020-08-301-2/+105
| |
* | Avoid checking all ancestors and fix mis-completionoxalica2020-09-151-33/+215
| |
* | inline parameters for a function description #6002Benjamin Coenen2020-09-151-0/+22
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #5976bors[bot]2020-09-141-56/+119
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5976: Complete trait impl immediately after type/const/fn r=jonas-schievink a=oxalica Currently, we can complete type/const/fn but only if we typed an identifier. That is, `impl .. { fn f<|> }` has completions with all trait fn including `f`, but `impl .. { fn <|> }` doesn't provide any suggestion (even if explicit trigger it). This PR tweak the logic of completion match to make it possible. However, we still need to explicit trigger suggestions (`Control + Space` by default) in vscode to show. Not sure if we can make it automatically triggered after typing the space after `fn`. Another question is that I cannot figure out why `BLOCK_EXPR` need to be checked. A block expr directly inside a impl block should be invalid, and nested items will failed to locate impl block in specific offset and skip the suggestion. Now I simply removed it and no tests are broken. https://github.com/rust-analyzer/rust-analyzer/blob/4f91478e50dc5c2a87235e9be8bd91e3f62de4b4/crates/ide/src/completion/complete_trait_impl.rs#L109 Co-authored-by: oxalica <[email protected]>
| * | Complete trait impl immediately after type/const/fnoxalica2020-09-111-56/+119
| | |
* | | Merge #5971bors[bot]2020-09-131-0/+22
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5971: Implement async blocks r=flodiebold a=oxalica Fix #4018 @flodiebold already gave a generic guide in the issue. Here's some concern about implementation detail: - Chalk doesn't support generator type yet. - Adding generator type as a brand new type (ctor) can be complex and need to *re-introduced* builtin impls. (Like how we implement closures before native closure support of chalk, which is already removed in #5401 ) - The output type of async block should be known after type inference of the whole body. - We cannot directly get the type from source like return-positon-impl-trait. But we still need to provide trait bounds when chalk asking for `opaque_ty_data`. - During the inference, the output type of async block can be temporary unknown and participate the later inference. `let a = async { None }; let _: i32 = a.await.unwrap();` So in this PR, the type of async blocks is inferred as an opaque type parameterized by the `Future::Output` type it should be, like what we do with closure type. And it really works now. Well, I still have some questions: - The bounds `AsyncBlockImplType<T>: Future<Output = T>` is currently generated in `opaque_ty_data`. I'm not sure if we should put this code here. - Type of async block is now rendered as `impl Future<Output = OutputType>`. Do we need to special display to hint that it's a async block? Note that closure type has its special format, instead of `impl Fn(..) -> ..` or function type. Co-authored-by: oxalica <[email protected]>
| * | Implement async blocksoxalica2020-09-101-0/+22
| |/
* | Adjust the test commentKirill Bulatov2020-09-111-9/+16
| |
* | One more testKirill Bulatov2020-09-091-0/+15
| |
* | Rename the method to avoid false promisesKirill Bulatov2020-09-091-5/+5
| |
* | Fix the testsKirill Bulatov2020-09-095-7/+9
| |
* | Add testsKirill Bulatov2020-09-091-0/+153
| |
* | Properly handle mod.rs importsKirill Bulatov2020-09-091-47/+40
| |
* | Complete semicolon when neededKirill Bulatov2020-09-096-26/+30
| |
* | Properly reacto to keywordsKirill Bulatov2020-09-096-4/+28
| |
* | Less false positive completion candidatesKirill Bulatov2020-09-091-44/+59
| |
* | Properly handle nested submodules in the same fileKirill Bulatov2020-09-091-70/+79
| |
* | Move most of the logic into the completion moduleKirill Bulatov2020-09-092-23/+98
| |
* | Finally cretae the mod completion moduleKirill Bulatov2020-09-092-17/+40
| |
* | Properly handle special cases (binaries, mod.rs)Kirill Bulatov2020-09-091-3/+1
| |
* | Exclude special filesKirill Bulatov2020-09-091-3/+0
| |
* | Happy path implementedKirill Bulatov2020-09-091-1/+1
| |
* | Better APIKirill Bulatov2020-09-091-5/+4
| |
* | First steps for mod<|> completionKirill Bulatov2020-09-091-2/+23
|/
* Complete `pub` in fieldsAleksey Kladov2020-08-254-7/+36
|
* Use the same abstraction for attrs and docsAleksey Kladov2020-08-252-2/+2
| | | | | Doc comments *are* attributes, so there's no reason to have two crates here.
* :arrow_up: ungrammarAleksey Kladov2020-08-211-1/+1
|
* Switch to expect_test from crates.ioAleksey Kladov2020-08-2113-13/+13
|
* Add SelfParam to code_modelAleksey Kladov2020-08-193-5/+3
|
* MinorAleksey Kladov2020-08-191-3/+3
|
* Cleanup feature generationAleksey Kladov2020-08-183-10/+10
|
* synchronizing changesDmitry2020-08-142-7/+20
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 12:11:43 +0000