aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src/completion
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5971bors[bot]2020-09-131-0/+22
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5971: Implement async blocks r=flodiebold a=oxalica Fix #4018 @flodiebold already gave a generic guide in the issue. Here's some concern about implementation detail: - Chalk doesn't support generator type yet. - Adding generator type as a brand new type (ctor) can be complex and need to *re-introduced* builtin impls. (Like how we implement closures before native closure support of chalk, which is already removed in #5401 ) - The output type of async block should be known after type inference of the whole body. - We cannot directly get the type from source like return-positon-impl-trait. But we still need to provide trait bounds when chalk asking for `opaque_ty_data`. - During the inference, the output type of async block can be temporary unknown and participate the later inference. `let a = async { None }; let _: i32 = a.await.unwrap();` So in this PR, the type of async blocks is inferred as an opaque type parameterized by the `Future::Output` type it should be, like what we do with closure type. And it really works now. Well, I still have some questions: - The bounds `AsyncBlockImplType<T>: Future<Output = T>` is currently generated in `opaque_ty_data`. I'm not sure if we should put this code here. - Type of async block is now rendered as `impl Future<Output = OutputType>`. Do we need to special display to hint that it's a async block? Note that closure type has its special format, instead of `impl Fn(..) -> ..` or function type. Co-authored-by: oxalica <[email protected]>
| * Implement async blocksoxalica2020-09-101-0/+22
| |
* | Adjust the test commentKirill Bulatov2020-09-111-9/+16
| |
* | One more testKirill Bulatov2020-09-091-0/+15
| |
* | Rename the method to avoid false promisesKirill Bulatov2020-09-091-5/+5
| |
* | Fix the testsKirill Bulatov2020-09-095-7/+9
| |
* | Add testsKirill Bulatov2020-09-091-0/+153
| |
* | Properly handle mod.rs importsKirill Bulatov2020-09-091-47/+40
| |
* | Complete semicolon when neededKirill Bulatov2020-09-096-26/+30
| |
* | Properly reacto to keywordsKirill Bulatov2020-09-096-4/+28
| |
* | Less false positive completion candidatesKirill Bulatov2020-09-091-44/+59
| |
* | Properly handle nested submodules in the same fileKirill Bulatov2020-09-091-70/+79
| |
* | Move most of the logic into the completion moduleKirill Bulatov2020-09-092-23/+98
| |
* | Finally cretae the mod completion moduleKirill Bulatov2020-09-092-17/+40
| |
* | Properly handle special cases (binaries, mod.rs)Kirill Bulatov2020-09-091-3/+1
| |
* | Exclude special filesKirill Bulatov2020-09-091-3/+0
| |
* | Happy path implementedKirill Bulatov2020-09-091-1/+1
| |
* | Better APIKirill Bulatov2020-09-091-5/+4
| |
* | First steps for mod<|> completionKirill Bulatov2020-09-091-2/+23
|/
* Complete `pub` in fieldsAleksey Kladov2020-08-254-7/+36
|
* Use the same abstraction for attrs and docsAleksey Kladov2020-08-252-2/+2
| | | | | Doc comments *are* attributes, so there's no reason to have two crates here.
* :arrow_up: ungrammarAleksey Kladov2020-08-211-1/+1
|
* Switch to expect_test from crates.ioAleksey Kladov2020-08-2113-13/+13
|
* Add SelfParam to code_modelAleksey Kladov2020-08-193-5/+3
|
* MinorAleksey Kladov2020-08-191-3/+3
|
* Cleanup feature generationAleksey Kladov2020-08-183-10/+10
|
* synchronizing changesDmitry2020-08-142-7/+20
|
* Rename hypothetical -> speculativeAleksey Kladov2020-08-141-1/+1
|
* Remove Hygiene from completionAleksey Kladov2020-08-133-59/+65
|
* MinorAleksey Kladov2020-08-131-6/+12
|
* Rename ra_ide -> ideAleksey Kladov2020-08-1318-0/+6880
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-17 12:00:43 +0000