Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | internal: remove DiagnosticWithFix infra | Aleksey Kladov | 2021-06-13 | 1 | -492/+22 |
| | |||||
* | internal: refactor incorrect case diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -14/+2 |
| | |||||
* | minor | Aleksey Kladov | 2021-06-13 | 1 | -38/+0 |
| | |||||
* | internal: refactor find_map diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -86/+2 |
| | |||||
* | minor | Aleksey Kladov | 2021-06-13 | 1 | -43/+0 |
| | |||||
* | internal: refactor missing or or some diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -3/+2 |
| | |||||
* | internal: refactor remove this semicolon diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -14/+3 |
| | |||||
* | internal: refactor mismatched args count diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -250/+2 |
| | |||||
* | internal: refactor missing unsafe diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -84/+2 |
| | |||||
* | internal: refactor BreakOutsideOfLoop diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -10/+2 |
| | |||||
* | internal: refactor NoSuchField diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -135/+11 |
| | |||||
* | internal: refactor unimplemented builtin macro diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -5/+2 |
| | |||||
* | minor: simplify | Aleksey Kladov | 2021-06-13 | 1 | -18/+3 |
| | |||||
* | internal: check diagnostics in all files and not just the first one | Aleksey Kladov | 2021-06-13 | 1 | -16/+15 |
| | |||||
* | internal: refactor macro error | Aleksey Kladov | 2021-06-13 | 1 | -0/+2 |
| | |||||
* | internal: refactor unresolved proc macro diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -10/+7 |
| | |||||
* | internal: refactor inactive code diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -17/+13 |
| | |||||
* | internal: refactor unresolved macro call diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -26/+3 |
| | |||||
* | internal: refactor unresolved import diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -29/+30 |
| | |||||
* | internal: refactor unresolved extern crate diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -0/+3 |
| | |||||
* | internal: unified missing fields diagnostic | Aleksey Kladov | 2021-06-13 | 1 | -14/+0 |
| | |||||
* | internal: move missing_fields diagnostics | Aleksey Kladov | 2021-06-13 | 1 | -4/+3 |
| | |||||
* | internal: start new diagnostics API | Aleksey Kladov | 2021-06-13 | 1 | -6/+35 |
| | | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics. | ||||
* | minor: put a mark back | Aleksey Kladov | 2021-06-13 | 1 | -0/+1 |
| | |||||
* | clippy::redudant_borrow | Maan2003 | 2021-06-13 | 1 | -3/+3 |
| | |||||
* | internal: cross-crate cov-marks | Aleksey Kladov | 2021-06-12 | 1 | -0/+2 |
| | |||||
* | internal: move diagnostics infra to hir | Aleksey Kladov | 2021-06-12 | 1 | -0/+354 |
| | |||||
* | Move some hir_ty diagnostics to hir | Aleksey Kladov | 2021-06-12 | 1 | -1/+1303 |
| | |||||
* | internal: move missing unsafe diagnostic to hir | Aleksey Kladov | 2021-06-12 | 1 | -0/+84 |
| | |||||
* | internal: move inference diagnostics to hir | Aleksey Kladov | 2021-06-12 | 1 | -1/+140 |
| | |||||
* | Diagnose unimplemented built-in macros | Jonas Schievink | 2021-05-30 | 1 | -0/+5 |
| | |||||
* | Stop expanding UseTrees during ItemTree lowering | Jonas Schievink | 2021-05-26 | 1 | -0/+2 |
| | |||||
* | internal: move diagnostics to hir | Aleksey Kladov | 2021-05-25 | 1 | -20/+45 |
| | | | | | | | | | | | | | | | | | | | | | | | The idea here is to eventually get rid of `dyn Diagnostic` and `DiagnosticSink` infrastructure altogether, and just have a `enum hir::Diagnostic` instead. The problem with `dyn Diagnostic` is that it is defined in the lowest level of the stack (hir_expand), but is used by the highest level (ide). As a first step, we free hir_expand and hir_def from `dyn Diagnostic` and kick the can up to `hir_ty`, as an intermediate state. The plan is then to move DiagnosticSink similarly to the hir crate, and, as final third step, remove its usage from the ide. One currently unsolved problem is testing. You can notice that the test which checks precise diagnostic ranges, unresolved_import_in_use_tree, was moved to the ide layer. Logically, only IDE should have the infra to render a specific range. At the same time, the range is determined with the data produced in hir_def and hir crates, so this layering is rather unfortunate. Working on hir_def shouldn't require compiling `ide` for testing. | ||||
* | Add pub mod option for UnlinkedFile | rainy-me | 2021-05-18 | 1 | -21/+42 |
| | |||||
* | internal: scalable module structure for fixits | Aleksey Kladov | 2021-05-17 | 1 | -530/+1 |
| | |||||
* | internal: use mutable syntax trees when filling fields | Aleksey Kladov | 2021-05-16 | 1 | -3/+3 |
| | |||||
* | fix: use raw idents in `make::name{_ref}` with keywords | Jonas Schievink | 2021-05-07 | 1 | -0/+20 |
| | |||||
* | Resolve single assist only | Kirill Bulatov | 2021-05-03 | 1 | -3/+3 |
| | |||||
* | Add a way to resolve certain assists | Kirill Bulatov | 2021-05-03 | 1 | -12/+31 |
| | |||||
* | Include path in `unresolved-macro-call` diagnostic | Jonas Schievink | 2021-04-16 | 1 | -1/+1 |
| | |||||
* | feat: improve performance by delaying computation of fixes for diagnostics | Aleksey Kladov | 2021-04-13 | 1 | -21/+39 |
| | |||||
* | internal: prepare for lazy diagnostics | Aleksey Kladov | 2021-04-12 | 1 | -39/+44 |
| | |||||
* | Shrink `unlinked-file` diagnostic to 3 characters | Jonas Schievink | 2021-04-09 | 1 | -7/+9 |
| | |||||
* | Don't mark unlinked file diagnostic as unused | Jonas Schievink | 2021-03-28 | 1 | -1/+0 |
| | |||||
* | Redo it properly and add a quickfix | Jonas Schievink | 2021-03-15 | 1 | -7/+154 |
| | |||||
* | Diagnose files that aren't in the module tree | Jonas Schievink | 2021-03-10 | 1 | -3/+13 |
| | |||||
* | For unresolved macros, hightlight only the last segment | Aleksey Kladov | 2021-02-28 | 1 | -11/+56 |
| | |||||
* | Add diagnostic for filter_map followed by next | Phil Ellison | 2021-01-23 | 1 | -0/+3 |
| | |||||
* | Handle self/super/crate in PathSegment as NameRef | Lukas Wirth | 2021-01-15 | 1 | -2/+2 |
| | |||||
* | Phase out SourceFileEdits in favour of a plain HashMap | Lukas Wirth | 2021-01-14 | 1 | -7/+5 |
| |