Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #9277 | bors[bot] | 2021-06-14 | 1 | -3/+3 |
|\ | | | | | | | | | | | | | | | | | 9277: internal: more natural order of sources for TypeParam r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | internal: more natural order of sources for TypeParam | Aleksey Kladov | 2021-06-14 | 1 | -3/+3 |
| | | | | | | | | | | We usually use first (left) variant of `Either` for "usual" case, and use right for odd things. For example, pat source is Pat | SelfParam. | ||||
* | | Merge #9275 | bors[bot] | 2021-06-14 | 1 | -2/+60 |
|\ \ | |/ |/| | | | | | | | | | | | 9275: feat: Support goto type for field expressions and patterns r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]> | ||||
| * | Support goto type for field expressions and patterns | Lukas Wirth | 2021-06-14 | 1 | -2/+60 |
| | | |||||
* | | minor: less ambiguous name | Aleksey Kladov | 2021-06-14 | 1 | -2/+3 |
| | | |||||
* | | internal: flatten module hierarchy | Aleksey Kladov | 2021-06-14 | 3 | -9/+10 |
| | | | | | | | | | | It seems that any crate can be made better by flattening the modules down to a single layer? | ||||
* | | internal: document rename challenges | Aleksey Kladov | 2021-06-14 | 1 | -0/+18 |
| | | |||||
* | | internal: adapt diagnostics to the new rename API | Aleksey Kladov | 2021-06-14 | 1 | -423/+12 |
| | | |||||
* | | internal: prepare to move assist definitions | Aleksey Kladov | 2021-06-14 | 1 | -2/+2 |
| | | |||||
* | | internal: move diagnostics to a new crate | Aleksey Kladov | 2021-06-14 | 23 | -4601/+3 |
|/ | |||||
* | internal: prepare to move rename to base_db | Aleksey Kladov | 2021-06-14 | 1 | -41/+40 |
| | | | | | | | | | | It's better to handle magical cases upper in the stack, because it allows for better re-use of the general implementation below. So, we pull the `self` case up here. The end goal is to put `Definition::rename` to the `ide_db`, because it's a generally re-usable functionality useful for different ide features, alongside with the search which is already there. | ||||
* | fix: don't use display-related functionality where semantics matters | Aleksey Kladov | 2021-06-14 | 1 | -41/+119 |
| | | | | | | | NavigationTarget is strictly a UI-level thing -- it describes where the cursor should be placed when the user presses goto definition. It doesn't make any semantic guaratees about rage and focus range and, as such, is not suitable for driving renames. | ||||
* | internal: diagnostic code is mandatory | Aleksey Kladov | 2021-06-13 | 2 | -23/+12 |
| | |||||
* | minor: dead code | Aleksey Kladov | 2021-06-13 | 2 | -50/+34 |
| | |||||
* | internal: kill diagnostic sink | Aleksey Kladov | 2021-06-13 | 1 | -35/+13 |
| | |||||
* | internal: use cov-mark rather than bailing out diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -49/+53 |
| | |||||
* | internal: refactor missing match arms diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -907/+926 |
| | |||||
* | internal: remove DiagnosticWithFix infra | Aleksey Kladov | 2021-06-13 | 4 | -585/+534 |
| | |||||
* | internal: refactor incorrect case diagnostics | Aleksey Kladov | 2021-06-13 | 3 | -40/+38 |
| | |||||
* | minor | Aleksey Kladov | 2021-06-13 | 2 | -38/+38 |
| | |||||
* | internal: refactor find_map diagnostic | Aleksey Kladov | 2021-06-13 | 4 | -171/+184 |
| | |||||
* | minor | Aleksey Kladov | 2021-06-13 | 3 | -44/+34 |
| | |||||
* | internal: refactor missing or or some diagnostic | Aleksey Kladov | 2021-06-13 | 3 | -24/+41 |
| | |||||
* | internal: refactor remove this semicolon diagnostics | Aleksey Kladov | 2021-06-13 | 6 | -59/+68 |
| | |||||
* | internal: refactor mismatched args count diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -250/+274 |
| | |||||
* | internal: refactor missing unsafe diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -84/+103 |
| | |||||
* | internal: refactor BreakOutsideOfLoop diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -10/+32 |
| | |||||
* | internal: refactor NoSuchField diagnostic | Aleksey Kladov | 2021-06-13 | 3 | -290/+297 |
| | |||||
* | internal: refactor unimplemented builtin macro diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -5/+21 |
| | |||||
* | minor: simplify | Aleksey Kladov | 2021-06-13 | 6 | -35/+18 |
| | |||||
* | internal: check diagnostics in all files and not just the first one | Aleksey Kladov | 2021-06-13 | 5 | -41/+46 |
| | |||||
* | internal: remove def-level diagnostics tests | Aleksey Kladov | 2021-06-13 | 1 | -0/+12 |
| | |||||
* | internal: refactor macro error | Aleksey Kladov | 2021-06-13 | 2 | -0/+165 |
| | |||||
* | internal: refactor unresolved proc macro diagnostic | Aleksey Kladov | 2021-06-13 | 3 | -11/+42 |
| | |||||
* | internal: refactor inactive code diagnostics | Aleksey Kladov | 2021-06-13 | 2 | -17/+126 |
| | |||||
* | internal: refactor unresolved macro call diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -26/+75 |
| | |||||
* | internal: refactor unresolved import diagnostic | Aleksey Kladov | 2021-06-13 | 3 | -29/+121 |
| | |||||
* | internal: refactor unresolved extern crate diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -0/+52 |
| | |||||
* | internal: unified missing fields diagnostic | Aleksey Kladov | 2021-06-13 | 2 | -24/+25 |
| | |||||
* | internal: move missing_fields diagnostics | Aleksey Kladov | 2021-06-13 | 4 | -53/+78 |
| | |||||
* | internal: start new diagnostics API | Aleksey Kladov | 2021-06-13 | 3 | -34/+82 |
| | | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics. | ||||
* | minor: put a mark back | Aleksey Kladov | 2021-06-13 | 1 | -0/+1 |
| | |||||
* | cargo fmt | Maan2003 | 2021-06-13 | 1 | -5/+3 |
| | |||||
* | clippy::useless_return | Maan2003 | 2021-06-13 | 3 | -4/+4 |
| | |||||
* | clippy::redundant_closure | Maan2003 | 2021-06-13 | 2 | -2/+2 |
| | |||||
* | clippy::clone_on_copy | Maan2003 | 2021-06-13 | 3 | -3/+3 |
| | |||||
* | clippy::redudant_borrow | Maan2003 | 2021-06-13 | 18 | -51/+51 |
| | |||||
* | internal: cross-crate cov-marks | Aleksey Kladov | 2021-06-12 | 1 | -0/+2 |
| | |||||
* | internal: move diagnostics infra to hir | Aleksey Kladov | 2021-06-12 | 1 | -0/+354 |
| | |||||
* | Move some hir_ty diagnostics to hir | Aleksey Kladov | 2021-06-12 | 1 | -1/+1303 |
| |