aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #6665bors[bot]2020-11-291-1/+102
|\ \ | | | | | | | | | | | | | | | | | | | | | 6665: Support self in reference search r=matklad a=Veykril The approach here is simply checking the descendants of the function body for `PathExpr` then checking whether it only contains a single `self` `PathSegment`, this is to prevent us from picking up `self` tokens from local `UseTree`s. Co-authored-by: Lukas Wirth <[email protected]>
| * | Support self in reference searchLukas Wirth2020-11-291-1/+102
| | |
* | | Merge #6599bors[bot]2020-11-294-10/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6599: Add attribute highlight modifier to all tokens inside attributes r=matklad a=Veykril This has the side effect that we also emit `attribute.attribute` highlights now, as in, the tokens that get the attribute semantic type also get the attribute modifier. I personally don't think it's really a problem but maybe it is to some? It's just that it was really simple to implement it this way, which is why I just went this route for now. Fixes #6536 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add attribute highlight modifier to all tokens inside attributesLukas Wirth2020-11-214-10/+23
| | | |
* | | | Reject more cases of invalid parameter to self renamesLukas Wirth2020-11-291-13/+122
| | | |
* | | | Fix renaming owned self to parameter emitting refLukas Wirth2020-11-291-1/+30
| |_|/ |/| |
* | | Merge #6666bors[bot]2020-11-291-17/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6666: Support 'go to definition' for self r=jonas-schievink a=Veykril Also reverts #6660, instead of showing the type it now works like it does for names by returning the declaration we are already on. This for example enables VSCode to show all references(#6665) when executing `go to definition` on the declaration. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Support 'go to definition' for selfLukas Wirth2020-11-291-17/+39
| | |/ | |/|
* | | Merge #6664bors[bot]2020-11-281-3/+43
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6664: Show type of self param on hover r=jonas-schievink a=Veykril Show the type of `self` when hovering the token in a `SelfParam`. Co-authored-by: Lukas Wirth <[email protected]>
| * | Show type of self param on hoverLukas Wirth2020-11-281-3/+43
| | |
* | | Merge #6660bors[bot]2020-11-281-6/+36
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6660: Support "go to definition" for SelfParams r=jonas-schievink a=Veykril Fixes #6657 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Support goto definition for ADT-SelfParamsLukas Wirth2020-11-281-6/+36
| |/ /
* | | Merge #6645bors[bot]2020-11-281-0/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6645: Publish diagnostics for macro expansion errors r=matklad a=jonas-schievink This adds 2 new diagnostics, emitted during name resolution: * `unresolved-proc-macro`, a weak warning that is emitted when a proc macro is supposed to be expanded, but was not provided by the build system. This usually means that proc macro support is turned off, but may also indicate setup issues when using rust-project.json. Being a weak warning, this should help set expectations when users see it, while not being too obstructive. We do not yet emit this for attribute macros though, just custom derives and `!` macros. * `macro-error`, which is emitted when any macro (procedural or `macro_rules!`) fails to expand due to some error. This is an error-level diagnostic, but currently still marked as experimental, because there might be spurious errors and this hasn't been tested too well. This does not yet emit diagnostics when expansion in item bodies fails, just for module-level macros. Known bug: The "proc macro not found" diagnostic points at the whole item for custom derives, it should just point at the macro's name in the `#[derive]` list, but I haven't found an easy way to do that. Screenshots: ![screenshot-2020-11-26-19:54:14](https://user-images.githubusercontent.com/1786438/100385782-f8bc2300-3023-11eb-9f27-e8f8ce9d6114.png) ![screenshot-2020-11-26-19:55:39](https://user-images.githubusercontent.com/1786438/100385784-f954b980-3023-11eb-9617-ac2eb0a0a9dc.png) Co-authored-by: Jonas Schievink <[email protected]>
| * | | More accurately place proc-macro diagnosticJonas Schievink2020-11-271-4/+6
| | | |
| * | | Publish diagnostics for macro expansion errorsJonas Schievink2020-11-271-0/+7
| |/ /
* | | Move the helpers into ide_dbKirill Bulatov2020-11-281-2/+2
| | |
* | | Extract the import code into the shared moduleKirill Bulatov2020-11-272-5/+3
|/ /
* | Use `ExpandResult` instead of `MacroResult`Jonas Schievink2020-11-261-3/+3
| | | | | | | | `MacroResult` is redundant
* | Rename `parse_macro` to `parse_macro_expansion`Jonas Schievink2020-11-241-1/+1
| | | | | | | | This does not parse macros, it expands a macro and parses the *result*
* | hir_expand: propagate expansion errorsJonas Schievink2020-11-241-3/+5
| |
* | Minor, import styleAleksey Kladov2020-11-231-6/+5
|/
* Merge #6582bors[bot]2020-11-171-8/+32
|\ | | | | | | | | | | | | | | | | | | | | | | | | 6582: Fill the diagnostic code field in publish_diagnostics r=kjeremy a=Veykril Fixes #6580 Before: ![Code_znn6VgLLH9](https://user-images.githubusercontent.com/3757771/99408084-213f7100-28f0-11eb-8317-3f5c2b93313d.png) After: ![Code_c4jJsvzOEA](https://user-images.githubusercontent.com/3757771/99408096-23093480-28f0-11eb-9bb2-8ebf2fb3d5a1.png) Co-authored-by: Lukas Wirth <[email protected]>
| * Fill the diagnostic code field in publish_diagnosticsLukas Wirth2020-11-171-8/+32
| |
* | Add **Ignore Test** assistAleksey Kladov2020-11-172-18/+6
|/
* Merge #6558bors[bot]2020-11-162-0/+4
|\ | | | | | | | | | | | | | | | | 6558: format string highlighting: handle hex + debug type specifier r=matklad a=ruabmbua Should fix https://github.com/rust-analyzer/rust-analyzer/issues/6427 Co-authored-by: Roland Ruckerbauer <[email protected]>
| * format string highlighting: handle hex + debug type specifierRoland Ruckerbauer2020-11-152-0/+4
| |
* | Cleanup edit_text_range_for_record_field_expr_or_patLukas Wirth2020-11-151-46/+59
| |
* | Use shorthand field syntax in destructuresLukas Wirth2020-11-142-19/+62
| |
* | Properly handle shorthands in destructure patterns when renamingLukas Wirth2020-11-142-6/+69
| |
* | Use shorthand record syntax when renaming struct initializer fieldLukas Wirth2020-11-141-4/+45
|/
* Merge #6472bors[bot]2020-11-096-3/+94
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6472: Add `static` modifier for associated functions r=matklad a=p3achyjr Adds static semantic token modifier to associated functions, resolves #6194 ## Info - Associated functions are more-or-less equivalent to static methods in other languages. This PR checks, for each function, whether that function has a self_param, and whether it's enclosed in a trait/impl. ## Changes - Added method ```is_associated``` to code_model::Function. This basically gets the source from the ast, and checks whether the enclosing scope is an impl or trait. - Added `static` to HighlightModifiers - Added unit test ## Tests - Ran ```cargo test``` Co-authored-by: Anatol Liu <[email protected]>
| * Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-091-2/+2
| | | | | | | | | | | | refactor logic into code_model.rs address comments
| * Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-081-1/+1
| | | | | | | | | | | | refactor logic into code_model.rs address comments
| * Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-051-14/+2
| | | | | | | | refactor logic into code_model.rs
| * Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-056-2/+105
| |
* | . is an operatorAleksey Kladov2020-11-095-28/+30
| | | | | | | | closes #6498
* | SimplifyAleksey Kladov2020-11-061-1/+0
| |
* | Kill RAW_ literalsAleksey Kladov2020-11-065-18/+12
|/ | | | | Syntactically, they are indistinguishable from non-raw versions, so it doesn't make sense to separate then *at the syntax* level.
* Support struct variants in extract_struct_from_enum_variantLukas Wirth2020-11-031-1/+2
|
* Only show `self` ident when showing parameter self hintsLukas Wirth2020-11-021-2/+23
|
* Merge #6365bors[bot]2020-11-021-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | 6365: Do insertion lookahead in algo::diff r=matklad a=Veykril This is the last blocker for #6287 after this I can update that PR to properly fix things through using `SyntaxRewriter`. This PR also shuffles tests around a bit and adds some more. Ideally this is just a hack until we implement a "proper" diff algorithm that approximates a minimal diff. Maybe something like [gumtree](https://github.com/GumTreeDiff/gumtree)? Co-authored-by: Lukas Wirth <[email protected]>
| * Do insertion lookahead in algo::diffLukas Wirth2020-10-261-1/+1
| |
| |
| \
*-. | Merge #6393 #6399bors[bot]2020-11-021-2/+106
|\ \| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6393: Remove repetitive inlay hints (take 2) r=matklad a=lnicola 6399: Keep generic annotations when qualifying things r=matklad a=Veykril The `qualify_path` assists currently eats up already annotated generics in all but one cases which can be annoying if one already pre-fills generics of a type before it's been qualified. Co-authored-by: Matthew Sanetra <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| * | Add check if param name is similar to fn nameMatthew Sanetra2020-10-281-2/+106
| | |
* | | Remove more unreachable pubsAleksey Kladov2020-11-029-27/+24
| | |
* | | Merge #6387bors[bot]2020-10-281-0/+21
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6387: do not use associated types placeholder for inlay hint r=flodiebold a=bnjjj close #6191 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-281-0/+21
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #6384bors[bot]2020-10-281-3/+67
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6384: add doctest runnables on struct r=lnicola a=bnjjj I will check for how to do the same on trait implementation on another PR. #6356 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-3/+67
| | |/ | |/| | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 00:33:55 +0100