aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #7291bors[bot]2021-01-185-73/+49
|\ | | | | | | | | | | | | | | 7291: Wrap remaining self/super/crate in Name{Ref} r=matklad a=Veykril That should be the remaining special casing for `self` 🎉 Co-authored-by: Lukas Wirth <[email protected]>
| * Wrap remaining self/super/crate in Name{Ref}Lukas Wirth2021-01-155-73/+49
| |
* | MinorAleksey Kladov2021-01-181-8/+5
| |
* | Merge #7292bors[bot]2021-01-181-14/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 7292: Swap assert_eq_text\!(expected, actual) r=matklad a=u5surf Fixes #7283 Swap assert_eq_text parameters in the order (expected, actual) Co-authored-by: yugo-horie <[email protected]>
| * | Swap assert_eq_text\!(expected, actual)yugo-horie2021-01-161-14/+14
| |/
* / Share import_assets and related entitiesKirill Bulatov2021-01-161-1/+1
|/
* Merge #7288bors[bot]2021-01-1511-186/+115
|\ | | | | | | | | | | | | | | | | | | 7288: Handle self/super/crate in PathSegment as NameRef r=matklad a=Veykril Wrapping self/super/crate in NameRef as per https://github.com/rust-analyzer/rust-analyzer/pull/7261#issuecomment-760023172 Co-authored-by: Lukas Wirth <[email protected]>
| * Handle self/super/crate in PathSegment as NameRefLukas Wirth2021-01-1511-186/+115
| |
* | Remove useless wrapperAleksey Kladov2021-01-153-7/+7
|/
* Phase out SourceFileEdits in favour of a plain HashMapLukas Wirth2021-01-146-125/+111
|
* Group file source edits by FileIdLukas Wirth2021-01-146-109/+86
|
* Merge #7260bors[bot]2021-01-141-0/+37
|\ | | | | | | | | | | | | | | | | | | | | 7260: Render Fn* trait objects and impl types as rust does r=matklad a=Veykril Also fixes raw ptr impl types being rendered ambiguously with multiple predicates. This moves out the `FamousDefs::Fixture` into its own file as well, cause I figured it is big enough to get its own file at this point + we also get highlighting this way when editing it. Fixes #3012 Co-authored-by: Lukas Wirth <[email protected]>
| * Render Fn* trait objects and impl types as rust doesLukas Wirth2021-01-131-0/+37
| |
* | Use upstream TextSize APIAleksey Kladov2021-01-132-15/+3
| |
* | Merge #7262bors[bot]2021-01-131-3/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 7262: Don't show internal server error on rename r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Don't show internal server error on renameAleksey Kladov2021-01-131-3/+0
| |/ | | | | | | | | | | | | Doesn't quite work due to https://github.com/microsoft/vscode-languageserver-node/issues/730 Note that this intentionally removes `impl std::Error for RenameError` -- we nether want to blindly bubble the rename error.
* | Rename FileReferences -> UsageSearchResultLukas Wirth2021-01-121-5/+5
| |
* | Ensure uniqueness of file ids in reference search via hashmapLukas Wirth2021-01-123-59/+62
| |
* | Group references by FileIdLukas Wirth2021-01-124-109/+116
|/
*---. Merge #7051 #7219 #7245 #7246bors[bot]2021-01-112-85/+162
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7051: Check dbg! macro in tidy_test r=matklad a=edwin0cheng Same as `check_todo` but for dbg! macro r? @matklad 7219: Refactor rename name checking r=matklad a=Veykril Improves the user facing error messages a bit and prevents renaming to `_` when the name is referenced as this would change source to not compile anymore since `_` is only a pattern, not a proper identifier. 7245: Encourage gifs r=matklad a=matklad bors r+ 🤖 7246: Unfreeze cargo_metadata r=matklad a=kjeremy It now pulls in a newer version of semver-parser. This does add a dependency on `cargo-platform` in the interest of correctness. Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * | Add some more marks to rename testsLukas Wirth2021-01-101-17/+58
| | | |
| | * | Use local error macros in references/renameLukas Wirth2021-01-101-39/+30
| | | |
| | * | Refactor rename name checkingLukas Wirth2021-01-092-59/+104
| | | |
* | | | Goto for inner doc links works for module inner doc commentsAleksey Kladov2021-01-112-40/+54
| |_|/ |/| |
* | | Merge #7218bors[bot]2021-01-104-15/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7218: Fix typos r=Veykril a=regexident Apart from the very last commit on this PR (which fixes a public type's name) all changes are non-breaking. Co-authored-by: Vincent Esche <[email protected]>
| * | | Fixed typos in code commentsVincent Esche2021-01-094-15/+15
| | |/ | |/|
* | | Merge #7239bors[bot]2021-01-102-6/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7239: Replace SyntaxKind usage with T! macro where applicable r=lnicola a=Veykril https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/dev/style.md#token-names Co-authored-by: Lukas Wirth <[email protected]>
| * | | Replace SyntaxKind usage with T! macro where applicableLukas Wirth2021-01-102-6/+5
| | | |
* | | | Fix typo, parentheses is pluralLaurențiu Nicola2021-01-109-133/+133
|/ / /
* | | Merge #6238bors[bot]2021-01-1012-303/+346
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6238: Split punctuation semantic highlighting up into more tags r=matklad a=Veykril Open question would be the name of the delimiter modifiers. I chose them this was as I see them this way but from what I remember people tend to mix the names however they like. So maybe using `delimSquare`, `delimCurly`, `delimRound` would be better. That would also go well with `angle` becoming `delimAngle`? Closes #6152 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Split punctuation semantic highlighting up into more tagsLukas Wirth2021-01-1012-303/+346
| | | |
| | | |
| \ \ \
*-. \ \ \ Merge #7206 #7231bors[bot]2021-01-108-27/+39
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7206: Use hir::GenericParam in ide_db::Definition instead of relisting all 3 r=Veykril a=Veykril Basically just this: ```diff pub enum Definition { Macro(MacroDef), Field(Field), ModuleDef(ModuleDef), SelfType(Impl), Local(Local), - TypeParam(TypeParam), - LifetimeParam(LifetimeParam), - ConstParam(ConstParam), + GenericParam(GenericParam), Label(Label), } ``` 7231: Cleaner API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| | * | | | Cleaner APIAleksey Kladov2021-01-102-7/+8
| | | | | |
| * | | | | Use hir::GenericParam in ide_db::Definition instead of relisting all 3Lukas Wirth2021-01-106-20/+31
| | |/ / / | |/| | |
* | | | | Merge #7229bors[bot]2021-01-102-37/+42
|\ \ \ \ \ | |/ / / / |/| / / / | |/ / / | | | | | | | | | | | | | | | | | | | | 7229: Cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | CleanupAleksey Kladov2021-01-102-37/+42
| | | |
* | | | Merge #6980bors[bot]2021-01-102-5/+111
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6980: Implement to support intra-doc link r=matklad a=sasurau4 Helps with #6168 This PR is very limited implementation to support intra-doc. It only support links indicate same file function. I want someone to feedback me about this implementation. If the approach is good, I will continue this PR to support other symbols like enum and struct. Co-authored-by: Daiki Ihara <[email protected]>
| * | | | Support intra_doc linksDaiki Ihara2021-01-082-5/+111
| | |_|/ | |/| |
* | | | Merge #7224bors[bot]2021-01-101-7/+19
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7224: Remove unnecessary allocation when checking whether to hide argument name hint r=jhpratt a=jhpratt The case-insensitive prefix/suffix check can be performed character-by-character. This allows the check to be done without having to allocate a new string. As a side effect, it's also no longer necessary to convert the entire string to lowercase, as it's done as needed. As the only case equality we're handling is ASCII, this operation can be further optimized by using byte equality, rather than character equality. cc @SomeoneToIgnore, as it's an update on my PR from yesterday. Co-authored-by: Jacob Pratt <[email protected]>
| * | | Skip leading underscores unconditionallyJacob Pratt2021-01-101-2/+5
| | | |
| * | | Short-circuit boolean operationJacob Pratt2021-01-101-4/+8
| | | |
| * | | Remove unnecessary allocationJacob Pratt2021-01-101-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The case-insensitive prefix/suffix check can be performed character-by-character. This allows the check to be done without having to allocate a new string. As a side effect, it's also no longer necessary to convert the entire string to lowercase, as it's done as needed. As the only case equality we're handling is ASCII, this operation can be further optimized by using byte equality, rather than character equality.
* | | | Replace state with functionAleksey Kladov2021-01-102-68/+54
|/ / /
* | | Refactor highlightingAleksey Kladov2021-01-093-528/+551
| | |
* | | SimplifyAleksey Kladov2021-01-092-86/+52
| |/ |/|
* | Better highlight for fixturesAleksey Kladov2021-01-092-2/+6
| |
* | SimplifyAleksey Kladov2021-01-092-52/+28
| |
* | Better namesAleksey Kladov2021-01-093-23/+24
| |
* | Reduce duplicationAleksey Kladov2021-01-091-7/+5
| |
* | Shorten namesAleksey Kladov2021-01-096-63/+46
| |