aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix iterator hint shortening heuristicLukas Wirth2020-10-121-2/+2
|
* Merge #6195bors[bot]2020-10-121-29/+48
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6195: Shorten iterators in associated params r=matklad a=SomeoneToIgnore Applies the same iterator-shortening logic to the iterator associated types, recursively. Before: ![image](https://user-images.githubusercontent.com/2690773/95662735-e6ecf200-0b41-11eb-8e54-28493ad4e644.png) After: <img width="1192" alt="image" src="https://user-images.githubusercontent.com/2690773/95662894-e9038080-0b42-11eb-897d-527571ccac58.png"> Co-authored-by: Kirill Bulatov <[email protected]>
| * Also replace the associated types with iterKirill Bulatov2020-10-101-11/+14
| |
| * Add a testKirill Bulatov2020-10-101-23/+39
| |
* | Merge #6198bors[bot]2020-10-124-4/+124
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 6198: Skip macro matcher fragment name semantic highlighting r=matklad a=Veykril Implements a small state-machine for macro_rules! highlighting to separate out the matcher part of its rules. This skips semantically highlighting names of metavariables in the matcher and expander. This might even allow for more fun macro highlighting things in the future. Fixes #4380. Co-authored-by: Lukas Wirth <[email protected]>
| * | Skip macro matcher fragment name semantic highlightingLukas Wirth2020-10-104-4/+124
| | |
* | | Merge #6199bors[bot]2020-10-121-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6199: Fix `mut self` not emitting mutable binding on `self` use r=matklad a=Veykril Prior to this, when `self` in a function is taken by value and bound mutably, its use inside of the method body won't be marked `mutably`. Fixes #5461 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Fix `mut self` not emitting mutable binding on `self` useLukas Wirth2020-10-111-1/+1
| |/ /
* | | Merge #5917bors[bot]2020-10-123-10/+287
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5917: Add a command to open docs for the symbol under the cursor r=matklad a=zacps #### Todo - [ ] Decide if there should be a default keybind or context menu entry - [x] Figure out how to get the documentation path for methods and other non-top-level defs - [x] Design the protocol extension. In future we'll probably want parameters for local/remote documentation URLs, so that should maybe be done in this PR? - [x] Code organisation - [x] Tests Co-authored-by: Zac Pullar-Strecker <[email protected]>
| * | Remove methodowner & fix formattingZac Pullar-Strecker2020-10-082-13/+24
| | |
| * | Rebase fixesZac Pullar-Strecker2020-10-081-13/+5
| | |
| * | Changes from reviewZac Pullar-Strecker2020-10-081-3/+3
| | |
| * | Remove outdated part of doc_links module docsZac Pullar-Strecker2020-10-081-2/+0
| | |
| * | Add ignored test to demonstrate ImportMap bugZac Pullar-Strecker2020-10-081-1/+26
| | |
| * | Fix namespace detection & function testZac Pullar-Strecker2020-10-081-6/+2
| | |
| * | Add testsZac Pullar-Strecker2020-10-081-2/+94
| | |
| * | Change Option::Some bug to a fixme noteZac Pullar-Strecker2020-10-081-3/+3
| | | | | | | | | | | | IMO this is too much work to be worth fixing at the moment.
| * | Differentiate method/tymethod by determining 'defaultness'Zac Pullar-Strecker2020-10-081-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently a method only has defaultness if it is a provided trait method, but this will change when specialisation is available and may need to become a concept known to hir. I opted to go for a 'fewest changes' approach given specialisation is still under development.
| * | Code reorganisation and field supportZac Pullar-Strecker2020-10-082-54/+47
| | |
| * | Changes from reviewZac Pullar-Strecker2020-10-082-4/+1
| | |
| * | Rename ide::link_rewrite -> ide::doc_links & tidy importsZac Pullar-Strecker2020-10-083-4/+4
| | |
| * | Add support for struct & trait methodsZac Pullar-Strecker2020-10-081-7/+83
| | |
| * | WIP: Command to open docs under cursorZac Pullar-Strecker2020-10-082-1/+89
| | |
* | | Show reason for failed rename refactoringRüdiger Herrmann2020-10-103-48/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Return an error with a meaningful message for requests to `textDocument/rename` if the operation cannot be performed. Pass errors raised by rename handling code to the LSP runtime. As a consequence, the VS Code client shows and logs the request as if a server-side programming error occured. Resolves https://github.com/rust-analyzer/rust-analyzer/issues/3981
* | | Merge #6176bors[bot]2020-10-101-0/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6176: add eprintln in fmt-like postfix r=SomeoneToIgnore a=bnjjj Co-authored-by: Benjamin Coenen <[email protected]>
| * | | add eprintln in fmt-like postfixBenjamin Coenen2020-10-081-0/+2
| |/ / | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | / adt: correctly inherit field visibility from enumJonas Schievink2020-10-091-0/+24
| |/ |/| | | | | | | | | | | Previously, "find all references" on a variant field wouldn't find any references outside the defining module. This is because variant fields were incorrectly assumed to be private, like struct fields without explicit visibility, but they actually inherit the enum's visibility.
* | Treat `ast::Name` in field patterns as useJonas Schievink2020-10-091-0/+46
| |
* | Fix source_to_def for named enum variant fieldsJonas Schievink2020-10-091-0/+17
|/
* Merge #6154bors[bot]2020-10-071-39/+162
|\ | | | | | | | | | | | | | | | | | | | | 6154: Shorten type hints for std::iter Iterators r=SomeoneToIgnore a=Veykril Fixes #3750. This re-exports the `hir_expand::name::known` module to be able to fetch the `Iterator` and `iter` names. I'm not sure if there is anything to do with `Solution::Ambig` in `normalize_trait_assoc_type` or whether discarding those results is always wanted. Co-authored-by: Lukas Wirth <[email protected]>
| * Clean up inlay_hintsLukas Wirth2020-10-071-18/+14
| |
| * Shorten iterator hints for std::iter iterators behind referencesLukas Wirth2020-10-071-2/+4
| |
| * Shorten iterator chain hintsLukas Wirth2020-10-071-36/+81
| |
| * Move IntoIterator into FamousDefsLukas Wirth2020-10-071-23/+5
| |
| * Use FamousDefs for shorten_iterator hintLukas Wirth2020-10-061-57/+36
| |
| * Shorten type hints for std::iter IteratorsLukas Wirth2020-10-061-6/+125
| |
* | Merge #6128bors[bot]2020-10-061-4/+25
|\ \ | | | | | | | | | | | | | | | | | | | | | 6128: Trim all trailing whitespace in onEnter r=matklad a=repnop Fixes #5848 Co-authored-by: Wesley Norris <[email protected]>
| * | Trim all trailing whitespace in onEnterWesley Norris2020-10-031-4/+25
| | | | | | | | | | | | Fixes #5848
* | | Merge #6140bors[bot]2020-10-063-7/+71
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6140: honour hover.content_format client capability r=lnicola a=robinvd This removes all markdown when the client does not support the markdown MarkupKind. Otherwise the output on the editor will have some markdown boilerplate, making it less readable. For example kak_lsp does not currently support markdown. ![image](https://user-images.githubusercontent.com/22073483/95112949-ef0ff080-0741-11eb-82a7-0594fa2cd736.png) after: ![image](https://user-images.githubusercontent.com/22073483/95113089-2bdbe780-0742-11eb-94fa-bcfec6d7347a.png) Co-authored-by: Robin van Dijk <[email protected]>
| * | add break after codeblocksRobin van Dijk2020-10-061-2/+4
| | |
| * | add doc describing limited capabilitiesRobin van Dijk2020-10-061-0/+2
| | |
| * | add docstringRobin van Dijk2020-10-051-0/+3
| | |
| * | honor content_format clientcapRobin van Dijk2020-10-053-7/+64
| |/ | | | | | | | | | | This removes all markdown when the client does not support the markdown MarkupKind Otherwise the output on the editor will have some markdown boilerplate, making it less readable
* | Merge #6148bors[bot]2020-10-061-0/+34
|\ \ | | | | | | | | | | | | | | | | | | | | | 6148: Fix trait object hir formatting behind pointer and references r=matklad a=Veykril Fixes #6064 Co-authored-by: Lukas Wirth <[email protected]>
| * | Fix trait object hir formatting behind pointer and referencesLukas Wirth2020-10-061-0/+34
| |/
* | Merge #6124bors[bot]2020-10-063-5/+35
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6124: Better normalized crate name usage r=jonas-schievink a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/5343 Closes https://github.com/rust-analyzer/rust-analyzer/issues/5932 Uses normalized name for code snippets (to be able to test the fix), hover messages and documentation rewrite links (are there any tests for those?). Also renamed the field to better resemble the semantics. Co-authored-by: Kirill Bulatov <[email protected]>
| * | Properly name the fieldKirill Bulatov2020-10-023-5/+5
| | |
| * | Add a dash testKirill Bulatov2020-10-021-0/+30
| | |
* | | Merge #6127bors[bot]2020-10-052-2/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6127: Correctly complete items with leading underscore r=SomeoneToIgnore a=fmease Fixes #6091. Let me know if the test is placed into the right file or if it is even desired. Co-authored-by: León Orell Valerian Liehr <[email protected]>
| * | | Correctly complete items with leading underscoreLeón Orell Valerian Liehr2020-10-032-2/+23
| |/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-26 21:15:43 +0000