aboutsummaryrefslogtreecommitdiff
path: root/crates/ide
Commit message (Collapse)AuthorAgeFilesLines
* internal: prepare to move rename to base_dbAleksey Kladov2021-06-141-41/+40
| | | | | | | | | | It's better to handle magical cases upper in the stack, because it allows for better re-use of the general implementation below. So, we pull the `self` case up here. The end goal is to put `Definition::rename` to the `ide_db`, because it's a generally re-usable functionality useful for different ide features, alongside with the search which is already there.
* fix: don't use display-related functionality where semantics mattersAleksey Kladov2021-06-141-41/+119
| | | | | | | NavigationTarget is strictly a UI-level thing -- it describes where the cursor should be placed when the user presses goto definition. It doesn't make any semantic guaratees about rage and focus range and, as such, is not suitable for driving renames.
* internal: diagnostic code is mandatoryAleksey Kladov2021-06-132-23/+12
|
* minor: dead codeAleksey Kladov2021-06-132-50/+34
|
* internal: kill diagnostic sinkAleksey Kladov2021-06-131-35/+13
|
* internal: use cov-mark rather than bailing out diagnosticAleksey Kladov2021-06-132-49/+53
|
* internal: refactor missing match arms diagnosticsAleksey Kladov2021-06-132-907/+926
|
* internal: remove DiagnosticWithFix infraAleksey Kladov2021-06-134-585/+534
|
* internal: refactor incorrect case diagnosticsAleksey Kladov2021-06-133-40/+38
|
* minorAleksey Kladov2021-06-132-38/+38
|
* internal: refactor find_map diagnosticAleksey Kladov2021-06-134-171/+184
|
* minorAleksey Kladov2021-06-133-44/+34
|
* internal: refactor missing or or some diagnosticAleksey Kladov2021-06-133-24/+41
|
* internal: refactor remove this semicolon diagnosticsAleksey Kladov2021-06-136-59/+68
|
* internal: refactor mismatched args count diagnosticAleksey Kladov2021-06-132-250/+274
|
* internal: refactor missing unsafe diagnosticAleksey Kladov2021-06-132-84/+103
|
* internal: refactor BreakOutsideOfLoop diagnosticAleksey Kladov2021-06-132-10/+32
|
* internal: refactor NoSuchField diagnosticAleksey Kladov2021-06-133-290/+297
|
* internal: refactor unimplemented builtin macro diagnosticAleksey Kladov2021-06-132-5/+21
|
* minor: simplifyAleksey Kladov2021-06-136-35/+18
|
* internal: check diagnostics in all files and not just the first oneAleksey Kladov2021-06-135-41/+46
|
* internal: remove def-level diagnostics testsAleksey Kladov2021-06-131-0/+12
|
* internal: refactor macro errorAleksey Kladov2021-06-132-0/+165
|
* internal: refactor unresolved proc macro diagnosticAleksey Kladov2021-06-133-11/+42
|
* internal: refactor inactive code diagnosticsAleksey Kladov2021-06-132-17/+126
|
* internal: refactor unresolved macro call diagnosticAleksey Kladov2021-06-132-26/+75
|
* internal: refactor unresolved import diagnosticAleksey Kladov2021-06-133-29/+121
|
* internal: refactor unresolved extern crate diagnosticAleksey Kladov2021-06-132-0/+52
|
* internal: unified missing fields diagnosticAleksey Kladov2021-06-132-24/+25
|
* internal: move missing_fields diagnosticsAleksey Kladov2021-06-134-53/+78
|
* internal: start new diagnostics APIAleksey Kladov2021-06-133-34/+82
| | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics.
* minor: put a mark backAleksey Kladov2021-06-131-0/+1
|
* cargo fmtMaan20032021-06-131-5/+3
|
* clippy::useless_returnMaan20032021-06-133-4/+4
|
* clippy::redundant_closureMaan20032021-06-132-2/+2
|
* clippy::clone_on_copyMaan20032021-06-133-3/+3
|
* clippy::redudant_borrowMaan20032021-06-1318-51/+51
|
* internal: cross-crate cov-marksAleksey Kladov2021-06-122-2/+3
|
* internal: move diagnostics infra to hirAleksey Kladov2021-06-121-0/+354
|
* Move some hir_ty diagnostics to hirAleksey Kladov2021-06-121-1/+1303
|
* internal: move missing unsafe diagnostic to hirAleksey Kladov2021-06-121-0/+84
|
* internal: move inference diagnostics to hirAleksey Kladov2021-06-121-1/+140
|
* Highlight tuple field accesses correctlyLukas Wirth2021-06-113-4/+7
|
* Merge #9219bors[bot]2021-06-111-2/+2
|\ | | | | | | | | | | | | | | 9219: minor: Replace some AssocItem::containing_trait calls trait_or_trait_impl r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * Replace some AssocItem::containing_trait calls trait_or_trait_implLukas Wirth2021-06-111-2/+2
| |
* | Merge #9218bors[bot]2021-06-111-1/+164
|\| | | | | | | | | | | | | | | 9218: Item search now respects trait impl items r=Veykril a=Veykril Fixes #2977 Co-authored-by: Lukas Wirth <[email protected]>
| * Item search now respects trait impl itemsLukas Wirth2021-06-111-1/+164
| |
* | Update ungrammarJonas Schievink2021-06-111-1/+1
| |
* | Populate import maps eagerlyKirill Bulatov2021-06-101-3/+4
| |
* | Don't classify attributes on macro-calls are the macro itselfLukas Wirth2021-06-091-0/+20
|/