aboutsummaryrefslogtreecommitdiff
path: root/crates/ide
Commit message (Collapse)AuthorAgeFilesLines
...
*---. Merge #7051 #7219 #7245 #7246bors[bot]2021-01-112-85/+162
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7051: Check dbg! macro in tidy_test r=matklad a=edwin0cheng Same as `check_todo` but for dbg! macro r? @matklad 7219: Refactor rename name checking r=matklad a=Veykril Improves the user facing error messages a bit and prevents renaming to `_` when the name is referenced as this would change source to not compile anymore since `_` is only a pattern, not a proper identifier. 7245: Encourage gifs r=matklad a=matklad bors r+ 🤖 7246: Unfreeze cargo_metadata r=matklad a=kjeremy It now pulls in a newer version of semver-parser. This does add a dependency on `cargo-platform` in the interest of correctness. Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * | Add some more marks to rename testsLukas Wirth2021-01-101-17/+58
| | | |
| | * | Use local error macros in references/renameLukas Wirth2021-01-101-39/+30
| | | |
| | * | Refactor rename name checkingLukas Wirth2021-01-092-59/+104
| | | |
* | | | Goto for inner doc links works for module inner doc commentsAleksey Kladov2021-01-112-40/+54
| |_|/ |/| |
* | | Merge #7218bors[bot]2021-01-104-15/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7218: Fix typos r=Veykril a=regexident Apart from the very last commit on this PR (which fixes a public type's name) all changes are non-breaking. Co-authored-by: Vincent Esche <[email protected]>
| * | | Fixed typos in code commentsVincent Esche2021-01-094-15/+15
| | |/ | |/|
* | | Merge #7239bors[bot]2021-01-102-6/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7239: Replace SyntaxKind usage with T! macro where applicable r=lnicola a=Veykril https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/dev/style.md#token-names Co-authored-by: Lukas Wirth <[email protected]>
| * | | Replace SyntaxKind usage with T! macro where applicableLukas Wirth2021-01-102-6/+5
| | | |
* | | | Fix typo, parentheses is pluralLaurențiu Nicola2021-01-109-133/+133
|/ / /
* | | Merge #6238bors[bot]2021-01-1012-303/+346
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6238: Split punctuation semantic highlighting up into more tags r=matklad a=Veykril Open question would be the name of the delimiter modifiers. I chose them this was as I see them this way but from what I remember people tend to mix the names however they like. So maybe using `delimSquare`, `delimCurly`, `delimRound` would be better. That would also go well with `angle` becoming `delimAngle`? Closes #6152 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Split punctuation semantic highlighting up into more tagsLukas Wirth2021-01-1012-303/+346
| | | |
| | | |
| \ \ \
*-. \ \ \ Merge #7206 #7231bors[bot]2021-01-108-27/+39
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7206: Use hir::GenericParam in ide_db::Definition instead of relisting all 3 r=Veykril a=Veykril Basically just this: ```diff pub enum Definition { Macro(MacroDef), Field(Field), ModuleDef(ModuleDef), SelfType(Impl), Local(Local), - TypeParam(TypeParam), - LifetimeParam(LifetimeParam), - ConstParam(ConstParam), + GenericParam(GenericParam), Label(Label), } ``` 7231: Cleaner API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| | * | | | Cleaner APIAleksey Kladov2021-01-102-7/+8
| | | | | |
| * | | | | Use hir::GenericParam in ide_db::Definition instead of relisting all 3Lukas Wirth2021-01-106-20/+31
| | |/ / / | |/| | |
* | | | | Merge #7229bors[bot]2021-01-102-37/+42
|\ \ \ \ \ | |/ / / / |/| / / / | |/ / / | | | | | | | | | | | | | | | | | | | | 7229: Cleanup r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | CleanupAleksey Kladov2021-01-102-37/+42
| | | |
* | | | Merge #6980bors[bot]2021-01-102-5/+111
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6980: Implement to support intra-doc link r=matklad a=sasurau4 Helps with #6168 This PR is very limited implementation to support intra-doc. It only support links indicate same file function. I want someone to feedback me about this implementation. If the approach is good, I will continue this PR to support other symbols like enum and struct. Co-authored-by: Daiki Ihara <[email protected]>
| * | | | Support intra_doc linksDaiki Ihara2021-01-082-5/+111
| | |_|/ | |/| |
* | | | Merge #7224bors[bot]2021-01-101-7/+19
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7224: Remove unnecessary allocation when checking whether to hide argument name hint r=jhpratt a=jhpratt The case-insensitive prefix/suffix check can be performed character-by-character. This allows the check to be done without having to allocate a new string. As a side effect, it's also no longer necessary to convert the entire string to lowercase, as it's done as needed. As the only case equality we're handling is ASCII, this operation can be further optimized by using byte equality, rather than character equality. cc @SomeoneToIgnore, as it's an update on my PR from yesterday. Co-authored-by: Jacob Pratt <[email protected]>
| * | | Skip leading underscores unconditionallyJacob Pratt2021-01-101-2/+5
| | | |
| * | | Short-circuit boolean operationJacob Pratt2021-01-101-4/+8
| | | |
| * | | Remove unnecessary allocationJacob Pratt2021-01-101-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The case-insensitive prefix/suffix check can be performed character-by-character. This allows the check to be done without having to allocate a new string. As a side effect, it's also no longer necessary to convert the entire string to lowercase, as it's done as needed. As the only case equality we're handling is ASCII, this operation can be further optimized by using byte equality, rather than character equality.
* | | | Replace state with functionAleksey Kladov2021-01-102-68/+54
|/ / /
* | | Refactor highlightingAleksey Kladov2021-01-093-528/+551
| | |
* | | SimplifyAleksey Kladov2021-01-092-86/+52
| |/ |/|
* | Better highlight for fixturesAleksey Kladov2021-01-092-2/+6
| |
* | SimplifyAleksey Kladov2021-01-092-52/+28
| |
* | Better namesAleksey Kladov2021-01-093-23/+24
| |
* | Reduce duplicationAleksey Kladov2021-01-091-7/+5
| |
* | Shorten namesAleksey Kladov2021-01-096-63/+46
| |
* | Reorder modulesAleksey Kladov2021-01-091-2/+4
| |
* | Shorten frequent namesAleksey Kladov2021-01-097-211/+192
| |
* | Rename dummy -> noneAleksey Kladov2021-01-093-15/+15
| |
* | Hide argument name hint regardless of caseJacob Pratt2021-01-091-3/+10
| |
* | Merge #7213bors[bot]2021-01-081-22/+8
|\ \ | | | | | | | | | | | | | | | | | | | | | 7213: Simplify r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | SimplifyLukas Wirth2021-01-081-22/+8
| |/
* | Merge #7212bors[bot]2021-01-089-274/+268
|\ \ | |/ |/| | | | | | | | | | | 7212: Simplify highlighting r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Simplify highlighting infraAleksey Kladov2021-01-089-274/+268
| | | | | | | | This also fixes the killer whale bug
* | Switch test markerPhil Ellison2021-01-071-1/+1
| |
* | cargo fmtPhil Ellison2021-01-071-1/+2
| |
* | Add fix to wrap return expression in SomePhil Ellison2021-01-072-8/+58
|/
* Better fixture highlightAleksey Kladov2021-01-074-10/+125
|
* Change <|> to $0 - RebaseKevaundray Wedderburn2021-01-0721-505/+505
|
* Remove some stale deprecationsAleksey Kladov2021-01-072-5/+0
|
* Align config's API with usageAleksey Kladov2021-01-061-1/+1
| | | | The config now is mostly immutable, optimize for that.
* YAGNI active_resolve_capabilitiesAleksey Kladov2021-01-061-2/+2
| | | | | | | | | This leaks a lot of LSP details into ide layer, which we want to avoid: https://github.com/rust-analyzer/rust-analyzer/tree/c9cec381bcfd97e5f3536e31a9c546ab5c0665e6/docs/dev#lsp-independence Additionally, all what this infra does is providing a toggle for auto-import completion, but we already have one!
* More maintainable configAleksey Kladov2021-01-063-50/+35
| | | | | | | Rather than eagerly converting JSON, we losslessly keep it as is, and change the shape of user-submitted data at the last moment. This also allows us to remove a bunch of wrong Defaults
* Show GotoTypeAction for TypeParamLukas Wirth2021-01-041-17/+54
|
* Show GotoTypeAction for ConstParamLukas Wirth2021-01-041-37/+66
|