aboutsummaryrefslogtreecommitdiff
path: root/crates/ide
Commit message (Collapse)AuthorAgeFilesLines
* Cast to ExprStmt, style fixesivan7702020-12-101-4/+4
|
* Format codeivan7702020-12-081-3/+10
|
* Remove unused useivan7702020-12-081-1/+1
|
* Remove this semicolonivan7702020-12-082-6/+23
|
* Merge #6750bors[bot]2020-12-081-28/+36
|\ | | | | | | | | | | | | | | | | | | | | | | 6750: Remove documentation query, move doc handling to attributes r=matklad a=Veykril Fixes #3182 Removes the documentation query in favor of `Attrs::docs`. Attrs already handlded doc comments partially but the alloc saving check was wrong so it only worked when other attributes existed as well. Unfortunately the `new` constructor has to do an intermediate allocation now because we need to keep the order of mixed doc attributes and doc comments. I've also partially adjusted the `hover` module to have its tests check the changes, it still has some `HasSource` trait usage due to the `ShortLabel` trait usage, as that is only implemented on the Ast parts and not the Hir, should this ideally be implemented for the Hir types as well?(would be a follow up PR of course) Co-authored-by: Lukas Wirth <[email protected]>
| * Remove hir_def/docs.rs moduleLukas Wirth2020-12-071-28/+36
| |
* | SimplifyKirill Bulatov2020-12-071-1/+0
| |
* | Use stateless completion resolveKirill Bulatov2020-12-071-0/+22
| |
* | Remove the stateKirill Bulatov2020-12-071-1/+1
| |
* | Make completion resolve asyncKirill Bulatov2020-12-071-1/+1
| |
* | Simplify import edit calculationKirill Bulatov2020-12-071-1/+1
| |
* | Properly fill client completion resolve capabilities dataKirill Bulatov2020-12-071-2/+2
| |
* | Working resolve completion imports prototypeKirill Bulatov2020-12-071-1/+2
|/
* Merge #6719bors[bot]2020-12-071-7/+6
|\ | | | | | | | | | | | | | | 6719: Use items can also have doc comments r=matklad a=Veykril Prior to this change modules show more docs than they have cause they inherit the docs from documented use items inside of them. Co-authored-by: Lukas Wirth <[email protected]>
| * Use items can also have doc commentsLukas Wirth2020-12-041-7/+6
| |
* | Don't insert blank lines between doc attributesLukas Wirth2020-12-071-2/+0
| |
* | Merge #6721bors[bot]2020-12-047-37/+44
|\ \ | | | | | | | | | | | | | | | | | | | | | 6721: Use METHOD semantic token type r=kjeremy a=lnicola Closes #6685 Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Use METHOD semantic token typeLaurențiu Nicola2020-12-047-37/+44
| |/
* / Don't diagnose `#[cfg]` in macrosJonas Schievink2020-12-031-0/+5
|/
* Merge #6673bors[bot]2020-12-021-45/+74
|\ | | | | | | | | | | | | | | 6673: Show type of Self on hover r=matklad a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * Show type of Self on hoverLukas Wirth2020-11-291-45/+74
| |
* | Type-safer API for dealing with parameter lists with optional selfAleksey Kladov2020-12-011-1/+1
| |
* | Merge #6665bors[bot]2020-11-291-1/+102
|\ \ | | | | | | | | | | | | | | | | | | | | | 6665: Support self in reference search r=matklad a=Veykril The approach here is simply checking the descendants of the function body for `PathExpr` then checking whether it only contains a single `self` `PathSegment`, this is to prevent us from picking up `self` tokens from local `UseTree`s. Co-authored-by: Lukas Wirth <[email protected]>
| * | Support self in reference searchLukas Wirth2020-11-291-1/+102
| | |
* | | Merge #6599bors[bot]2020-11-294-10/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6599: Add attribute highlight modifier to all tokens inside attributes r=matklad a=Veykril This has the side effect that we also emit `attribute.attribute` highlights now, as in, the tokens that get the attribute semantic type also get the attribute modifier. I personally don't think it's really a problem but maybe it is to some? It's just that it was really simple to implement it this way, which is why I just went this route for now. Fixes #6536 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add attribute highlight modifier to all tokens inside attributesLukas Wirth2020-11-214-10/+23
| | | |
* | | | Reject more cases of invalid parameter to self renamesLukas Wirth2020-11-291-13/+122
| | | |
* | | | Fix renaming owned self to parameter emitting refLukas Wirth2020-11-291-1/+30
| |_|/ |/| |
* | | Merge #6666bors[bot]2020-11-291-17/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6666: Support 'go to definition' for self r=jonas-schievink a=Veykril Also reverts #6660, instead of showing the type it now works like it does for names by returning the declaration we are already on. This for example enables VSCode to show all references(#6665) when executing `go to definition` on the declaration. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Support 'go to definition' for selfLukas Wirth2020-11-291-17/+39
| | |/ | |/|
* | | Merge #6664bors[bot]2020-11-281-3/+43
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 6664: Show type of self param on hover r=jonas-schievink a=Veykril Show the type of `self` when hovering the token in a `SelfParam`. Co-authored-by: Lukas Wirth <[email protected]>
| * | Show type of self param on hoverLukas Wirth2020-11-281-3/+43
| | |
* | | Merge #6660bors[bot]2020-11-281-6/+36
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6660: Support "go to definition" for SelfParams r=jonas-schievink a=Veykril Fixes #6657 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Support goto definition for ADT-SelfParamsLukas Wirth2020-11-281-6/+36
| |/ /
* | | Merge #6645bors[bot]2020-11-281-0/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6645: Publish diagnostics for macro expansion errors r=matklad a=jonas-schievink This adds 2 new diagnostics, emitted during name resolution: * `unresolved-proc-macro`, a weak warning that is emitted when a proc macro is supposed to be expanded, but was not provided by the build system. This usually means that proc macro support is turned off, but may also indicate setup issues when using rust-project.json. Being a weak warning, this should help set expectations when users see it, while not being too obstructive. We do not yet emit this for attribute macros though, just custom derives and `!` macros. * `macro-error`, which is emitted when any macro (procedural or `macro_rules!`) fails to expand due to some error. This is an error-level diagnostic, but currently still marked as experimental, because there might be spurious errors and this hasn't been tested too well. This does not yet emit diagnostics when expansion in item bodies fails, just for module-level macros. Known bug: The "proc macro not found" diagnostic points at the whole item for custom derives, it should just point at the macro's name in the `#[derive]` list, but I haven't found an easy way to do that. Screenshots: ![screenshot-2020-11-26-19:54:14](https://user-images.githubusercontent.com/1786438/100385782-f8bc2300-3023-11eb-9f27-e8f8ce9d6114.png) ![screenshot-2020-11-26-19:55:39](https://user-images.githubusercontent.com/1786438/100385784-f954b980-3023-11eb-9617-ac2eb0a0a9dc.png) Co-authored-by: Jonas Schievink <[email protected]>
| * | | More accurately place proc-macro diagnosticJonas Schievink2020-11-271-4/+6
| | | |
| * | | Publish diagnostics for macro expansion errorsJonas Schievink2020-11-271-0/+7
| |/ /
* | | Move the helpers into ide_dbKirill Bulatov2020-11-282-3/+2
| | |
* | | Extract the import code into the shared moduleKirill Bulatov2020-11-273-5/+4
|/ /
* | Use `ExpandResult` instead of `MacroResult`Jonas Schievink2020-11-261-3/+3
| | | | | | | | `MacroResult` is redundant
* | Rename `parse_macro` to `parse_macro_expansion`Jonas Schievink2020-11-241-1/+1
| | | | | | | | This does not parse macros, it expands a macro and parses the *result*
* | hir_expand: propagate expansion errorsJonas Schievink2020-11-241-3/+5
| |
* | Minor, import styleAleksey Kladov2020-11-231-6/+5
|/
* Merge #6582bors[bot]2020-11-171-8/+32
|\ | | | | | | | | | | | | | | | | | | | | | | | | 6582: Fill the diagnostic code field in publish_diagnostics r=kjeremy a=Veykril Fixes #6580 Before: ![Code_znn6VgLLH9](https://user-images.githubusercontent.com/3757771/99408084-213f7100-28f0-11eb-8317-3f5c2b93313d.png) After: ![Code_c4jJsvzOEA](https://user-images.githubusercontent.com/3757771/99408096-23093480-28f0-11eb-9bb2-8ebf2fb3d5a1.png) Co-authored-by: Lukas Wirth <[email protected]>
| * Fill the diagnostic code field in publish_diagnosticsLukas Wirth2020-11-171-8/+32
| |
* | Add **Ignore Test** assistAleksey Kladov2020-11-172-18/+6
|/
* Merge #6558bors[bot]2020-11-162-0/+4
|\ | | | | | | | | | | | | | | | | 6558: format string highlighting: handle hex + debug type specifier r=matklad a=ruabmbua Should fix https://github.com/rust-analyzer/rust-analyzer/issues/6427 Co-authored-by: Roland Ruckerbauer <[email protected]>
| * format string highlighting: handle hex + debug type specifierRoland Ruckerbauer2020-11-152-0/+4
| |
| * cleanupAleksey Kladov2020-11-131-0/+0
| |
| * add open Cargo.toml actionAnatol Liu2020-11-131-0/+0
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 02:19:45 +0000