aboutsummaryrefslogtreecommitdiff
path: root/crates/ide
Commit message (Collapse)AuthorAgeFilesLines
* Address review commentsPhil Ellison2021-01-231-9/+4
|
* cargo fmtPhil Ellison2021-01-231-2/+7
|
* Implement fix, add testsPhil Ellison2021-01-231-18/+11
|
* Add diagnostic for filter_map followed by nextPhil Ellison2021-01-232-1/+35
|
* Merge #7353bors[bot]2021-01-228-35/+12
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7353: Add LifetimeParam and ConstParam to CompletionItemKind r=matklad a=Veykril Adds `LifetimeParam` and `ConstParam` to `CompletionItemKind` and maps them both to `TypeParam` in the protocol conversion as there are no equivalents, so nothing really changes there. `ConstParam` could be mapped to `Const` I guess but I'm split on whether that would be better? Additions were solely inspired by (the single) test output for const params. Also sorts the variants of `CompletionItemKind` and its to_proto match. Co-authored-by: Lukas Wirth <[email protected]>
| * Move SymbolKind to ide_dbLukas Wirth2021-01-208-35/+12
| |
* | Merge #7348bors[bot]2021-01-222-3/+49
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 7348: Fix broken link in intra-doc r=edwin0cheng a=sasurau4 Fix #5546 The intra-doc link doesn't work fine for trait associated method. Co-authored-by: Daiki Ihara <[email protected]>
| * | Fix broken link in intra-docDaiki Ihara2021-01-222-3/+49
| | |
* | | Cleanup testsAleksey Kladov2021-01-221-12/+12
| | |
* | | Remove index based fallback for goto defAleksey Kladov2021-01-221-48/+18
|/ / | | | | | | | | We are so precise that the fallback creates more confusion, when you can goto def on an unresolved reference.
* | Include `countme` crate to count important data structures.Aleksey Kladov2021-01-211-0/+2
| |
* | Treat BlockExpr as a potential module originJonas Schievink2021-01-204-0/+9
| |
* | Avoid intermediate collectionsAleksey Kladov2021-01-201-26/+20
| |
* | Don't show runnable suggestions for other filesAleksey Kladov2021-01-201-3/+32
| | | | | | | | | | It't be actually great to have these once we have run anything dialog, but for run the thing at point it makes sense to show a limited set.
* | .Aleksey Kladov2021-01-197-10/+9
|/
* Merge #7321bors[bot]2021-01-192-73/+136
|\ | | | | | | | | | | | | | | 7321: Support runnables in macros r=matklad a=edwin0cheng fixes #4771 Co-authored-by: Edwin Cheng <[email protected]>
| * Support runnables in macrosEdwin Cheng2021-01-192-73/+136
| |
* | Remove obsolete RangeInfo usage in referencesLukas Wirth2021-01-183-38/+20
| |
| |
| \
*-. \ Merge #7297 #7338bors[bot]2021-01-182-4/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7297: Propose trait associated items and autoimport traits on completion r=matklad a=SomeoneToIgnore ![trait_imports](https://user-images.githubusercontent.com/2690773/104819998-6faeb480-583a-11eb-8b45-b7351b51b90e.gif) Closes #7248 7338: Parse `impl const Trait` r=Veykril a=Veykril Closes #7313 bors r+ Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add flyimport completion for trait assoc itemsKirill Bulatov2021-01-162-4/+6
| | |/ | |/|
* | | Remove obsolete RangeInfo usage in renameLukas Wirth2021-01-183-168/+150
| | |
* | | Merge #7332bors[bot]2021-01-182-164/+210
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7332: Rename reference search uses ide_db::search directly r=matklad a=Veykril https://github.com/rust-analyzer/rust-analyzer/pull/7251#discussion_r556644241 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Make rename reference search use ide_db::search directlyLukas Wirth2021-01-182-164/+210
| | |/ | |/|
* / | Add test for reference search on self declaration paramLukas Wirth2021-01-181-0/+20
|/ /
* | Merge #7291bors[bot]2021-01-185-73/+49
|\ \ | | | | | | | | | | | | | | | | | | | | | 7291: Wrap remaining self/super/crate in Name{Ref} r=matklad a=Veykril That should be the remaining special casing for `self` 🎉 Co-authored-by: Lukas Wirth <[email protected]>
| * | Wrap remaining self/super/crate in Name{Ref}Lukas Wirth2021-01-155-73/+49
| | |
* | | MinorAleksey Kladov2021-01-181-8/+5
| | |
* | | Merge #7292bors[bot]2021-01-181-14/+14
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 7292: Swap assert_eq_text\!(expected, actual) r=matklad a=u5surf Fixes #7283 Swap assert_eq_text parameters in the order (expected, actual) Co-authored-by: yugo-horie <[email protected]>
| * | Swap assert_eq_text\!(expected, actual)yugo-horie2021-01-161-14/+14
| |/
* / Share import_assets and related entitiesKirill Bulatov2021-01-161-1/+1
|/
* Merge #7288bors[bot]2021-01-1511-186/+115
|\ | | | | | | | | | | | | | | | | | | 7288: Handle self/super/crate in PathSegment as NameRef r=matklad a=Veykril Wrapping self/super/crate in NameRef as per https://github.com/rust-analyzer/rust-analyzer/pull/7261#issuecomment-760023172 Co-authored-by: Lukas Wirth <[email protected]>
| * Handle self/super/crate in PathSegment as NameRefLukas Wirth2021-01-1511-186/+115
| |
* | Remove useless wrapperAleksey Kladov2021-01-153-7/+7
|/
* Phase out SourceFileEdits in favour of a plain HashMapLukas Wirth2021-01-146-125/+111
|
* Group file source edits by FileIdLukas Wirth2021-01-146-109/+86
|
* Merge #7260bors[bot]2021-01-141-0/+37
|\ | | | | | | | | | | | | | | | | | | | | 7260: Render Fn* trait objects and impl types as rust does r=matklad a=Veykril Also fixes raw ptr impl types being rendered ambiguously with multiple predicates. This moves out the `FamousDefs::Fixture` into its own file as well, cause I figured it is big enough to get its own file at this point + we also get highlighting this way when editing it. Fixes #3012 Co-authored-by: Lukas Wirth <[email protected]>
| * Render Fn* trait objects and impl types as rust doesLukas Wirth2021-01-131-0/+37
| |
* | Use upstream TextSize APIAleksey Kladov2021-01-132-15/+3
| |
* | Merge #7262bors[bot]2021-01-131-3/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 7262: Don't show internal server error on rename r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Don't show internal server error on renameAleksey Kladov2021-01-131-3/+0
| |/ | | | | | | | | | | | | Doesn't quite work due to https://github.com/microsoft/vscode-languageserver-node/issues/730 Note that this intentionally removes `impl std::Error for RenameError` -- we nether want to blindly bubble the rename error.
* | Rename FileReferences -> UsageSearchResultLukas Wirth2021-01-121-5/+5
| |
* | Ensure uniqueness of file ids in reference search via hashmapLukas Wirth2021-01-123-59/+62
| |
* | Group references by FileIdLukas Wirth2021-01-124-109/+116
|/
*---. Merge #7051 #7219 #7245 #7246bors[bot]2021-01-112-85/+162
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7051: Check dbg! macro in tidy_test r=matklad a=edwin0cheng Same as `check_todo` but for dbg! macro r? @matklad 7219: Refactor rename name checking r=matklad a=Veykril Improves the user facing error messages a bit and prevents renaming to `_` when the name is referenced as this would change source to not compile anymore since `_` is only a pattern, not a proper identifier. 7245: Encourage gifs r=matklad a=matklad bors r+ 🤖 7246: Unfreeze cargo_metadata r=matklad a=kjeremy It now pulls in a newer version of semver-parser. This does add a dependency on `cargo-platform` in the interest of correctness. Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * | Add some more marks to rename testsLukas Wirth2021-01-101-17/+58
| | | |
| | * | Use local error macros in references/renameLukas Wirth2021-01-101-39/+30
| | | |
| | * | Refactor rename name checkingLukas Wirth2021-01-092-59/+104
| | | |
* | | | Goto for inner doc links works for module inner doc commentsAleksey Kladov2021-01-112-40/+54
| |_|/ |/| |
* | | Merge #7218bors[bot]2021-01-104-15/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7218: Fix typos r=Veykril a=regexident Apart from the very last commit on this PR (which fixes a public type's name) all changes are non-breaking. Co-authored-by: Vincent Esche <[email protected]>
| * | | Fixed typos in code commentsVincent Esche2021-01-094-15/+15
| | |/ | |/|