| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Merge #7741 | bors[bot] | 2021-02-24 | 1 | -0/+301 |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall Implements one direction of #7681 I wonder if this tries to guess too much at the right thing here. A common pattern is: ```rust let col = vec![1, 2, 3]; for v in &mut col { *v *= 2; } // equivalent to: col.iter_mut().for_each(|v| *v *= 2); ``` I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind: 1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types) 2. Try to check if iter/iter_mut exists and they return the right iterator type 3. Don't try to do this and just add `.into_iter()` to whatever is after `in` Co-authored-by: Matt Hall <[email protected]> | ||||
| | * | Address further review comments | Matt Hall | 2021-02-24 | 1 | -51/+35 |
| | | | | | | | | | | | | | * Use known names for iter/iter_mut method (simplifies checking if the method exists * Extract code to check assist with fixtures to function | ||||
| | * | Address review comments | Matt Hall | 2021-02-23 | 1 | -33/+125 |
| | | | | | | | | | | | * Move code to build replacement into closure * Look for iter/iter_mut methods on types behind reference | ||||
| | * | Add convert_for_to_iter_for_each assist | Matt Hall | 2021-02-23 | 1 | -0/+225 |
| | | | |||||
| * | | Add tests for apply_demorgan | Lukas Wirth | 2021-02-24 | 1 | -0/+67 |
| | | | |||||
| * | | De Morgan's Law assist now correctly inverts <, <=, >, >=. | lbrande | 2021-02-24 | 3 | -6/+6 |
| | | | |||||
| * | | De Morgan's Law assist now correctly parenthesizes binary expressions. | lbrande | 2021-02-24 | 1 | -4/+3 |
| |/ | |||||
| * | 7526: Rename crate assists to ide_assists. | Chetan Khilosiya | 2021-02-22 | 58 | -0/+24301 |
 |
index : rust-analyzer | |
| [FORK] modified to work on wasm targets |
| aboutsummaryrefslogtreecommitdiff |