Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Create modules in correct directory for nested modules in move_module assist | Lukas Wirth | 2021-06-17 | 1 | -13/+52 |
| | |||||
* | internal: don't #[ignore] tests | Aleksey Kladov | 2021-06-15 | 2 | -35/+16 |
| | | | | See the style.md for motivation | ||||
* | internal: cleanup tests | Aleksey Kladov | 2021-06-15 | 2 | -610/+596 |
| | | | | | | * ensure standard, non-indented style (should add this check to `fixture` some day) * removed a couple of ignores | ||||
* | internal: document that we don't #[ignore] tests | Aleksey Kladov | 2021-06-15 | 1 | -16/+16 |
| | |||||
* | Don't keep a trailing self token in import paths after unmerge_use | Lukas Wirth | 2021-06-14 | 1 | -1/+15 |
| | |||||
* | Merge #9242 | bors[bot] | 2021-06-13 | 17 | -28/+28 |
|\ | | | | | | | | | | | | | | | 9242: Clippy r=matklad a=Maan2003 Best viewed commit wise Co-authored-by: Maan2003 <[email protected]> | ||||
| * | clippy::redundant_closure | Maan2003 | 2021-06-13 | 2 | -3/+3 |
| | | |||||
| * | clippy::redudant_borrow | Maan2003 | 2021-06-13 | 16 | -25/+25 |
| | | |||||
* | | Merge #9240 | bors[bot] | 2021-06-13 | 1 | -1/+1 |
|\ \ | |/ |/| | | | | | | | | | | | 9240: Fixed a small typo in comment r=matklad a=fee1-dead Co-authored-by: fee1-dead <[email protected]> | ||||
| * | Fixed a small typo in comment | fee1-dead | 2021-06-11 | 1 | -1/+1 |
| | | |||||
* | | Merge #9215 | bors[bot] | 2021-06-11 | 1 | -2/+9 |
|\ \ | |/ |/| | | | | | | | | | | | 9215: change visibility for use and macro items r=jonas-schievink a=Maan2003 Co-authored-by: Maan2003 <[email protected]> | ||||
| * | change visibility for use and macro items | Maan2003 | 2021-06-11 | 1 | -2/+9 |
| | | |||||
* | | Don't suggest Remove unused param in trait impls | Maan2003 | 2021-06-11 | 1 | -1/+29 |
|/ | |||||
* | fmt | Joshua Warner | 2021-06-06 | 1 | -3/+12 |
| | |||||
* | Refactor to be just one assist | Joshua Warner | 2021-06-05 | 2 | -530/+328 |
| | |||||
* | Add assist for converting a tuple enum variant to a named variant | Joshua Warner | 2021-06-05 | 1 | -0/+515 |
| | |||||
* | Don't inline mutable locals in 'inline_local_variable' | Lukas Wirth | 2021-06-04 | 1 | -0/+17 |
| | |||||
* | NFC: remove redundant clones (clippy::perf) | Matthias Krüger | 2021-06-03 | 1 | -1/+1 |
| | |||||
* | Preserve indentation | Jonas Schievink | 2021-06-02 | 1 | -5/+30 |
| | |||||
* | Account for traits | Jonas Schievink | 2021-06-02 | 1 | -10/+29 |
| | |||||
* | Merge #9108 | bors[bot] | 2021-06-02 | 1 | -2/+31 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9108: Don't show extract into variable assist for unit expressions r=jonas-schievink a=brandondong **Reproduction:** ```rust fn main() { let mut i = 3; $0if i >= 0 { i += 1; } else { i -= 1; }$0 } ``` 1. Select the snippet of code between the $0's. 2. The extract into variable assist shows up, pushing down the more useful extract into function assist. 3. The resulting output of selecting the extract into variable assist is valid but with the extracted variable having the unit type: ```rust fn main() { let mut i = 3; let var_name = if i >= 0 { i += 1; } else { i -= 1; }; var_name } ``` **Fix:** - Don't show the extract into variable assist for unit expressions. I could not think of any scenarios where such a variable extraction would be desired. Co-authored-by: Brandon <[email protected]> | ||||
| * | Don't show extract into variable assist for unit expressions | Brandon | 2021-06-02 | 1 | -2/+31 |
| | | |||||
* | | Merge #9112 | bors[bot] | 2021-06-02 | 1 | -44/+125 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9112: Fix some bugs in `extract_struct_from_enum_variant` assist r=Veykril a=Veykril bors r+ Fixes #9100 Fixes #9099 Kind of fixes #9109, it now copies all the generics might be incorrect if the variant doesn't use all of them) Co-authored-by: Lukas Wirth <[email protected]> | ||||
| * | | Fix references to patterns in extract_struct_from_enum_variant assist | Lukas Wirth | 2021-06-02 | 1 | -26/+51 |
| | | | |||||
| * | | Carry over attributes in extract_struct_from_enum_variant | Lukas Wirth | 2021-06-02 | 1 | -5/+32 |
| | | | |||||
| * | | Account for generics in extract_struct_from_enum_variant | Lukas Wirth | 2021-06-02 | 1 | -17/+46 |
| |/ | |||||
* / | Place extracted type alias outside of impl | Jonas Schievink | 2021-06-02 | 1 | -1/+27 |
|/ | |||||
* | clippy::redundant_clone fixes | Laurențiu Nicola | 2021-05-26 | 1 | -1/+1 |
| | |||||
* | add test that it does not create extraneous commas | Domantas Jadenkus | 2021-05-24 | 1 | -0/+20 |
| | |||||
* | generate match arms with todo!() as placeholder body | Domantas Jadenkus | 2021-05-24 | 1 | -54/+74 |
| | |||||
* | Merge #8945 | bors[bot] | 2021-05-23 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | | | | | | | | | 8945: fix: Make expected type work in more situations r=flodiebold a=flodiebold Also makes call info show the correct types for generic methods. ![2021-05-23-182952_1134x616_scrot](https://user-images.githubusercontent.com/906069/119269023-dd5a5b00-bbf5-11eb-993a-b6e122c3b9a6.png) ![2021-05-23-183117_922x696_scrot](https://user-images.githubusercontent.com/906069/119269025-dfbcb500-bbf5-11eb-983c-fc415b8428e0.png) Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | Get rid of field_type again | Florian Diebold | 2021-05-23 | 1 | -1/+1 |
| | | |||||
* | | feat: generate getter avoids generating types like `&Vec<T>` | Aleksey Kladov | 2021-05-23 | 1 | -7/+106 |
| | | |||||
* | | feat: generate getter assist places the cursor at the generated function | Aleksey Kladov | 2021-05-23 | 1 | -7/+12 |
| | | |||||
* | | minimize tests | Aleksey Kladov | 2021-05-23 | 1 | -44/+54 |
| | | |||||
* | | remove duplicate tests | Aleksey Kladov | 2021-05-23 | 1 | -103/+26 |
| | | |||||
* | | reduce duplication | Aleksey Kladov | 2021-05-23 | 2 | -208/+160 |
|/ | |||||
* | Merge #8901 | bors[bot] | 2021-05-22 | 1 | -25/+56 |
|\ | | | | | | | | | | | | | | | | | | | | | 8901: fix: `fill_match_arms` hangs on a tuple of large enums r=matklad a=iDawer + Lazy computation of missing arms. + Convenience function to test lazy computation: `ide_assists::tests::check_assist_unresolved`. Fixes #8835 Co-authored-by: Dawer <[email protected]> | ||||
| * | Test `fill_match_arms` for lazy computation. | Dawer | 2021-05-21 | 1 | -1/+19 |
| | | | | | | | | This also adds `ide_assists::tests::check_assist_unresolved` function. | ||||
| * | fix: `fill_match_arms` hangs on a tuple of large enums | Dawer | 2021-05-20 | 1 | -2/+14 |
| | | |||||
| * | Compute missing arms lazily. | Dawer | 2021-05-20 | 1 | -23/+24 |
| | | |||||
* | | Merge #8897 | bors[bot] | 2021-05-20 | 1 | -0/+14 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | 8897: minor: Don't compare ast::Visibility by stringifying r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Tobias Wirth <[email protected]> | ||||
| * | | Don't compare ast::Visibility by stringifying | Lukas Tobias Wirth | 2021-05-20 | 1 | -0/+14 |
| |/ | |||||
* / | Update outdated auto-import documentation | Lukas Tobias Wirth | 2021-05-20 | 1 | -9/+8 |
|/ | |||||
* | add_explicit_type respects `@` patterns | Dawer | 2021-05-19 | 1 | -5/+20 |
| | |||||
* | Extract function assist will add async if required | Jamie Cunliffe | 2021-05-17 | 1 | -2/+63 |
| | | | | | The extract function assist will check for an AWAIT_EXPR in the body and if found, will add async to the generated function. | ||||
* | Merge #8845 | bors[bot] | 2021-05-16 | 1 | -12/+275 |
|\ | | | | | | | | | | | | | | | 8845: Generate the impl block via generate_trait_impl_text_from_impl r=Veykril a=hi-rustin Try to close https://github.com/rust-analyzer/rust-analyzer/issues/8827 Co-authored-by: hi-rustin <[email protected]> | ||||
| * | Remove attrs | hi-rustin | 2021-05-15 | 1 | -5/+1 |
| | | |||||
| * | Address comments and add more tests | hi-rustin | 2021-05-15 | 1 | -25/+249 |
| | | | | | | | | | | | | Fix tests Fmt code | ||||
| * | Generate the impl block via generate_trait_impl_text | hi-rustin | 2021-05-15 | 1 | -2/+45 |
| | |