aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_assists/src
Commit message (Collapse)AuthorAgeFilesLines
* internal: switch some tests to minicoreAleksey Kladov2021-06-171-84/+37
|
* internal: minimize minicoreAleksey Kladov2021-06-171-53/+25
| | | | | | We want to keep minicore small, so let's split out iterator adapters and sources into a separate `iterators` region, and use them only when needed.
* internal: cleanup testsAleksey Kladov2021-06-161-71/+114
|
* internal: switch some tests to minicoreAleksey Kladov2021-06-161-15/+12
|
* internal: switch some tests to minicoreAleksey Kladov2021-06-161-19/+15
|
* internal: don't #[ignore] testsAleksey Kladov2021-06-152-35/+16
| | | | See the style.md for motivation
* internal: cleanup testsAleksey Kladov2021-06-152-610/+596
| | | | | | * ensure standard, non-indented style (should add this check to `fixture` some day) * removed a couple of ignores
* internal: document that we don't #[ignore] testsAleksey Kladov2021-06-151-16/+16
|
* internal: cut deps between assists and diagnosticsAleksey Kladov2021-06-141-127/+4
|
* internal: prepare to move assist definitionsAleksey Kladov2021-06-142-29/+27
|
* Don't keep a trailing self token in import paths after unmerge_useLukas Wirth2021-06-141-1/+15
|
* Merge #9242bors[bot]2021-06-1322-37/+36
|\ | | | | | | | | | | | | | | 9242: Clippy r=matklad a=Maan2003 Best viewed commit wise Co-authored-by: Maan2003 <[email protected]>
| * cargo fmtMaan20032021-06-131-2/+1
| |
| * clippy::redundant_field_namesMaan20032021-06-131-1/+1
| |
| * clippy::useless_returnMaan20032021-06-131-4/+4
| |
| * clippy::redundant_closureMaan20032021-06-132-3/+3
| |
| * clippy::redudant_borrowMaan20032021-06-1319-28/+28
| |
* | Merge #9240bors[bot]2021-06-131-1/+1
|\ \ | |/ |/| | | | | | | | | | | 9240: Fixed a small typo in comment r=matklad a=fee1-dead Co-authored-by: fee1-dead <[email protected]>
| * Fixed a small typo in commentfee1-dead2021-06-111-1/+1
| |
* | Merge #9215bors[bot]2021-06-111-2/+9
|\ \ | |/ |/| | | | | | | | | | | 9215: change visibility for use and macro items r=jonas-schievink a=Maan2003 Co-authored-by: Maan2003 <[email protected]>
| * change visibility for use and macro itemsMaan20032021-06-111-2/+9
| |
* | Don't suggest Remove unused param in trait implsMaan20032021-06-111-1/+29
|/
* fmtJoshua Warner2021-06-061-3/+12
|
* Refactor to be just one assistJoshua Warner2021-06-053-532/+328
|
* Add assist for converting a tuple enum variant to a named variantJoshua Warner2021-06-052-0/+517
|
* Don't inline mutable locals in 'inline_local_variable'Lukas Wirth2021-06-041-0/+17
|
* NFC: remove redundant clones (clippy::perf)Matthias Krüger2021-06-031-1/+1
|
* Preserve indentationJonas Schievink2021-06-021-5/+30
|
* Account for traitsJonas Schievink2021-06-021-10/+29
|
* Merge #9108bors[bot]2021-06-021-2/+31
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9108: Don't show extract into variable assist for unit expressions r=jonas-schievink a=brandondong **Reproduction:** ```rust fn main() { let mut i = 3; $0if i >= 0 { i += 1; } else { i -= 1; }$0 } ``` 1. Select the snippet of code between the $0's. 2. The extract into variable assist shows up, pushing down the more useful extract into function assist. 3. The resulting output of selecting the extract into variable assist is valid but with the extracted variable having the unit type: ```rust fn main() { let mut i = 3; let var_name = if i >= 0 { i += 1; } else { i -= 1; }; var_name } ``` **Fix:** - Don't show the extract into variable assist for unit expressions. I could not think of any scenarios where such a variable extraction would be desired. Co-authored-by: Brandon <[email protected]>
| * Don't show extract into variable assist for unit expressionsBrandon2021-06-021-2/+31
| |
* | Merge #9112bors[bot]2021-06-021-44/+125
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9112: Fix some bugs in `extract_struct_from_enum_variant` assist r=Veykril a=Veykril bors r+ Fixes #9100 Fixes #9099 Kind of fixes #9109, it now copies all the generics might be incorrect if the variant doesn't use all of them) Co-authored-by: Lukas Wirth <[email protected]>
| * | Fix references to patterns in extract_struct_from_enum_variant assistLukas Wirth2021-06-021-26/+51
| | |
| * | Carry over attributes in extract_struct_from_enum_variantLukas Wirth2021-06-021-5/+32
| | |
| * | Account for generics in extract_struct_from_enum_variantLukas Wirth2021-06-021-17/+46
| |/
* / Place extracted type alias outside of implJonas Schievink2021-06-021-1/+27
|/
* clippy::redundant_clone fixesLaurențiu Nicola2021-05-261-1/+1
|
* add test that it does not create extraneous commasDomantas Jadenkus2021-05-241-0/+20
|
* tidyDomantas Jadenkus2021-05-241-2/+2
|
* generate match arms with todo!() as placeholder bodyDomantas Jadenkus2021-05-241-54/+74
|
* Merge #8945bors[bot]2021-05-231-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | 8945: fix: Make expected type work in more situations r=flodiebold a=flodiebold Also makes call info show the correct types for generic methods. ![2021-05-23-182952_1134x616_scrot](https://user-images.githubusercontent.com/906069/119269023-dd5a5b00-bbf5-11eb-993a-b6e122c3b9a6.png) ![2021-05-23-183117_922x696_scrot](https://user-images.githubusercontent.com/906069/119269025-dfbcb500-bbf5-11eb-983c-fc415b8428e0.png) Co-authored-by: Florian Diebold <[email protected]>
| * Get rid of field_type againFlorian Diebold2021-05-231-1/+1
| |
* | feat: generate getter avoids generating types like `&Vec<T>`Aleksey Kladov2021-05-232-9/+108
| |
* | feat: generate getter assist places the cursor at the generated functionAleksey Kladov2021-05-232-9/+14
| |
* | minimize testsAleksey Kladov2021-05-231-44/+54
| |
* | remove duplicate testsAleksey Kladov2021-05-231-103/+26
| |
* | reduce duplicationAleksey Kladov2021-05-234-211/+162
| |
* | Correctly resolve crate name in use paths when import shadows itselfLukas Tobias Wirth2021-05-231-2/+1
|/
* Merge #8922bors[bot]2021-05-222-2/+3
|\ | | | | | | | | | | | | | | | | 8922: Add more docs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Add more docsAleksey Kladov2021-05-222-2/+3
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-29 16:27:00 +0000