aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_assists/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #9215bors[bot]2021-06-111-2/+9
|\ | | | | | | | | | | | | | | 9215: change visibility for use and macro items r=jonas-schievink a=Maan2003 Co-authored-by: Maan2003 <[email protected]>
| * change visibility for use and macro itemsMaan20032021-06-111-2/+9
| |
* | Don't suggest Remove unused param in trait implsMaan20032021-06-111-1/+29
|/
* fmtJoshua Warner2021-06-061-3/+12
|
* Refactor to be just one assistJoshua Warner2021-06-053-532/+328
|
* Add assist for converting a tuple enum variant to a named variantJoshua Warner2021-06-052-0/+517
|
* Don't inline mutable locals in 'inline_local_variable'Lukas Wirth2021-06-041-0/+17
|
* NFC: remove redundant clones (clippy::perf)Matthias Krüger2021-06-031-1/+1
|
* Preserve indentationJonas Schievink2021-06-021-5/+30
|
* Account for traitsJonas Schievink2021-06-021-10/+29
|
* Merge #9108bors[bot]2021-06-021-2/+31
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9108: Don't show extract into variable assist for unit expressions r=jonas-schievink a=brandondong **Reproduction:** ```rust fn main() { let mut i = 3; $0if i >= 0 { i += 1; } else { i -= 1; }$0 } ``` 1. Select the snippet of code between the $0's. 2. The extract into variable assist shows up, pushing down the more useful extract into function assist. 3. The resulting output of selecting the extract into variable assist is valid but with the extracted variable having the unit type: ```rust fn main() { let mut i = 3; let var_name = if i >= 0 { i += 1; } else { i -= 1; }; var_name } ``` **Fix:** - Don't show the extract into variable assist for unit expressions. I could not think of any scenarios where such a variable extraction would be desired. Co-authored-by: Brandon <[email protected]>
| * Don't show extract into variable assist for unit expressionsBrandon2021-06-021-2/+31
| |
* | Merge #9112bors[bot]2021-06-021-44/+125
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9112: Fix some bugs in `extract_struct_from_enum_variant` assist r=Veykril a=Veykril bors r+ Fixes #9100 Fixes #9099 Kind of fixes #9109, it now copies all the generics might be incorrect if the variant doesn't use all of them) Co-authored-by: Lukas Wirth <[email protected]>
| * | Fix references to patterns in extract_struct_from_enum_variant assistLukas Wirth2021-06-021-26/+51
| | |
| * | Carry over attributes in extract_struct_from_enum_variantLukas Wirth2021-06-021-5/+32
| | |
| * | Account for generics in extract_struct_from_enum_variantLukas Wirth2021-06-021-17/+46
| |/
* / Place extracted type alias outside of implJonas Schievink2021-06-021-1/+27
|/
* clippy::redundant_clone fixesLaurențiu Nicola2021-05-261-1/+1
|
* add test that it does not create extraneous commasDomantas Jadenkus2021-05-241-0/+20
|
* tidyDomantas Jadenkus2021-05-241-2/+2
|
* generate match arms with todo!() as placeholder bodyDomantas Jadenkus2021-05-241-54/+74
|
* Merge #8945bors[bot]2021-05-231-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | 8945: fix: Make expected type work in more situations r=flodiebold a=flodiebold Also makes call info show the correct types for generic methods. ![2021-05-23-182952_1134x616_scrot](https://user-images.githubusercontent.com/906069/119269023-dd5a5b00-bbf5-11eb-993a-b6e122c3b9a6.png) ![2021-05-23-183117_922x696_scrot](https://user-images.githubusercontent.com/906069/119269025-dfbcb500-bbf5-11eb-983c-fc415b8428e0.png) Co-authored-by: Florian Diebold <[email protected]>
| * Get rid of field_type againFlorian Diebold2021-05-231-1/+1
| |
* | feat: generate getter avoids generating types like `&Vec<T>`Aleksey Kladov2021-05-232-9/+108
| |
* | feat: generate getter assist places the cursor at the generated functionAleksey Kladov2021-05-232-9/+14
| |
* | minimize testsAleksey Kladov2021-05-231-44/+54
| |
* | remove duplicate testsAleksey Kladov2021-05-231-103/+26
| |
* | reduce duplicationAleksey Kladov2021-05-234-211/+162
| |
* | Correctly resolve crate name in use paths when import shadows itselfLukas Tobias Wirth2021-05-231-2/+1
|/
* Merge #8922bors[bot]2021-05-222-2/+3
|\ | | | | | | | | | | | | | | | | 8922: Add more docs r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Add more docsAleksey Kladov2021-05-222-2/+3
| |
* | Merge #8868bors[bot]2021-05-224-228/+173
|\| | | | | | | | | | | | | | | 8868: internal: replace AstTransformer with mutable syntax trees r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * use more precise nameAleksey Kladov2021-05-223-12/+7
| |
| * internal: replace AstTransformer with mutable syntax treesAleksey Kladov2021-05-222-154/+104
| |
* | Merge #8901bors[bot]2021-05-222-27/+75
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 8901: fix: `fill_match_arms` hangs on a tuple of large enums r=matklad a=iDawer + Lazy computation of missing arms. + Convenience function to test lazy computation: `ide_assists::tests::check_assist_unresolved`. Fixes #8835 Co-authored-by: Dawer <[email protected]>
| * Test `fill_match_arms` for lazy computation.Dawer2021-05-212-3/+38
| | | | | | | | This also adds `ide_assists::tests::check_assist_unresolved` function.
| * fix: `fill_match_arms` hangs on a tuple of large enumsDawer2021-05-201-2/+14
| |
| * Compute missing arms lazily.Dawer2021-05-201-23/+24
| |
* | Merge #8897bors[bot]2021-05-201-0/+14
|\ \ | | | | | | | | | | | | | | | | | | | | | 8897: minor: Don't compare ast::Visibility by stringifying r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Tobias Wirth <[email protected]>
| * | Don't compare ast::Visibility by stringifyingLukas Tobias Wirth2021-05-201-0/+14
| | |
* | | Update outdated auto-import documentationLukas Tobias Wirth2021-05-201-9/+8
|/ /
* | Merge #8873bors[bot]2021-05-201-2/+6
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 8873: Implement import-granularity guessing r=matklad a=Veykril This renames our `MergeBehavior` to `ImportGranularity` as rustfmt has it as the purpose of them are basically the same. `ImportGranularity::Preserve` currently has no specific purpose for us as we don't have an organize imports assist yet, so it currently acts the same as `ImportGranularity::Item`. We now try to guess the import style on a per file basis and fall back to the user granularity setting if the file has no specific style yet or where it is ambiguous. This can be turned off by setting `import.enforceGranularity` to `true`. Closes https://github.com/rust-analyzer/rust-analyzer/issues/8870 Co-authored-by: Lukas Tobias Wirth <[email protected]>
| * Replace ImportGranularity::Guess with guessing boolean flagLukas Tobias Wirth2021-05-191-0/+1
| |
| * MergeBehavior -> ImportGranularityLukas Tobias Wirth2021-05-181-2/+5
| |
* | add_explicit_type respects `@` patternsDawer2021-05-191-5/+20
|/
* Extract function assist will add async if requiredJamie Cunliffe2021-05-171-2/+63
| | | | | The extract function assist will check for an AWAIT_EXPR in the body and if found, will add async to the generated function.
* Merge #8845bors[bot]2021-05-161-12/+275
|\ | | | | | | | | | | | | | | 8845: Generate the impl block via generate_trait_impl_text_from_impl r=Veykril a=hi-rustin Try to close https://github.com/rust-analyzer/rust-analyzer/issues/8827 Co-authored-by: hi-rustin <[email protected]>
| * Remove attrshi-rustin2021-05-151-5/+1
| |
| * Address comments and add more testshi-rustin2021-05-151-25/+249
| | | | | | | | | | | | Fix tests Fmt code
| * Generate the impl block via generate_trait_impl_texthi-rustin2021-05-151-2/+45
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 19:15:45 +0000