Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Only replace quotes in replace_string_with_char assist | Lukas Wirth | 2021-03-06 | 1 | -59/+77 | |
| | | | | ||||||
* | | | | Merge #7800 | bors[bot] | 2021-03-06 | 3 | -0/+407 | |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | 7800: [WIP] 7708: Initial implementation of generate Default assist. r=Veykril a=chetankhilosiya The Generate Default impl from new function. Co-authored-by: Chetan Khilosiya <[email protected]> | |||||
| * | | | 7708: rust ideomatic code fixes. | Chetan Khilosiya | 2021-03-06 | 1 | -9/+11 | |
| | | | | ||||||
| * | | | 7708: handle both FamousDefs fixture and plain code. | Chetan Khilosiya | 2021-03-06 | 1 | -8/+18 | |
| | | | | | | | | | | | | | | | | Also fix typo in example. | |||||
| * | | | 7708: Added the updated implementation of is_default_implemented. | Chetan Khilosiya | 2021-03-06 | 1 | -33/+31 | |
| | | | | | | | | | | | | | | | | The implementation uses hir create to find the implemented trait. | |||||
| * | | | 7708: Added the logic to check is default impl is already present. | Chetan Khilosiya | 2021-03-06 | 1 | -18/+97 | |
| | | | | | | | | | | | | | | | | Also added test cases for code present within module. | |||||
| * | | | 7708: Updated generate default fn logic. | Chetan Khilosiya | 2021-03-06 | 1 | -22/+48 | |
| | | | | ||||||
| * | | | 7708: Added the work for review comments. | Chetan Khilosiya | 2021-03-06 | 1 | -31/+60 | |
| | | | | | | | | | | | | | | | | Also added 1 test case to test multiple struct blocks are present. | |||||
| * | | | 7708: Fixed many documentaion example issues. | Chetan Khilosiya | 2021-03-06 | 2 | -6/+37 | |
| | | | | ||||||
| * | | | 7708: Format code through rust-analyzer formatter. | Chetan Khilosiya | 2021-03-06 | 1 | -35/+44 | |
| | | | | ||||||
| * | | | 7708: Initial implementation of generate Default assist. | Chetan Khilosiya | 2021-03-06 | 2 | -0/+223 | |
| | |/ | |/| | | | | | | | The Generate Default impl from new function. | |||||
* | | | Merge #7865 | bors[bot] | 2021-03-06 | 1 | -1/+37 | |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | 7865: preserve escape sequences when replacing string with char r=Veykril a=jDomantas Currently it replaces escape sequence with the actual value, which is very wrong for `"\n"`. Co-authored-by: Domantas Jadenkus <[email protected]> | |||||
| * | | preserve escape sequences when replacing string with char | Domantas Jadenkus | 2021-03-03 | 1 | -1/+37 | |
| | | | ||||||
* | | | generate function assist convert arg names to lower snake case | Josh Mcguigan | 2021-03-06 | 1 | -4/+52 | |
| |/ |/| | ||||||
* | | Merge #7869 | bors[bot] | 2021-03-05 | 1 | -0/+43 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | 7869: Add support for deref assignments to "pull assignment up" assist. r=Veykril a=Jesse-Bakker Fixes #7867 Co-authored-by: Jesse Bakker <[email protected]> | |||||
| * | | Add support for deref assignments to "pull assignment up" assist. | Jesse Bakker | 2021-03-05 | 1 | -0/+43 | |
| |/ | | | | | | | Fixes #7867 | |||||
* | | Merge #7880 | bors[bot] | 2021-03-05 | 1 | -2/+8 | |
|\ \ | |/ |/| | | | | | | | | | | | 7880: Honor snippet capability when using the extract function assist r=lnicola a=Arthamys This fixes issue #7793 Co-authored-by: san <[email protected]> | |||||
| * | Honor snippet capability in extract function assist | san | 2021-03-05 | 1 | -2/+8 | |
| | | ||||||
* | | Special-case parenthesized and negated expressions in demorgan assist | Jesse Bakker | 2021-03-03 | 1 | -2/+43 | |
| | | ||||||
* | | Merge #7851 | bors[bot] | 2021-03-02 | 2 | -616/+424 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | 7851: Compress tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | |||||
| * | | Compress tests | Aleksey Kladov | 2021-03-02 | 2 | -616/+424 | |
| | | | ||||||
* | | | chore: remove redundant tests | Conrad Ludgate | 2021-03-02 | 1 | -30/+0 | |
| | | | ||||||
* | | | chore: codegen | Conrad Ludgate | 2021-03-02 | 1 | -19/+0 | |
| | | | ||||||
* | | | refactor: re-use add_turbo_fish function | Conrad Ludgate | 2021-03-02 | 3 | -201/+137 | |
| | | | ||||||
* | | | chore: fmt + docs | Conrad Ludgate | 2021-03-02 | 1 | -2/+2 | |
| | | | ||||||
* | | | chore: rename var | Conrad Ludgate | 2021-03-02 | 1 | -3/+3 | |
| | | | ||||||
* | | | feat: add type ascription assist | Conrad Ludgate | 2021-03-02 | 3 | -0/+219 | |
|/ / | ||||||
* | | strip useless methods, and unary ops in suggest_name | Vladyslav Katasonov | 2021-03-02 | 1 | -7/+114 | |
| | | ||||||
* | | pull out suggest_name::* to utils; enchance heuristics | Vladyslav Katasonov | 2021-03-02 | 4 | -89/+821 | |
| | | ||||||
* | | suggest parameter name before function name | Vladyslav Katasonov | 2021-03-02 | 1 | -5/+5 | |
| | | ||||||
* | | try to suggest name when extracting variable | Vladyslav Katasonov | 2021-03-02 | 1 | -7/+287 | |
| | | ||||||
* | | Merge #7777 | bors[bot] | 2021-03-02 | 2 | -0/+421 | |
|\ \ | |/ |/| | | | | | | | | | | | 7777: Implement line<->block comment assist r=Veykril a=djrenren Fixes: https://github.com/rust-analyzer/rust-analyzer/issues/6515 Co-authored-by: John Renner <[email protected]> | |||||
| * | Apply edits | John Renner | 2021-03-01 | 1 | -51/+54 | |
| | | ||||||
| * | Implement line<->block comment assist | John Renner | 2021-02-25 | 2 | -0/+418 | |
| | | ||||||
* | | Use consistent naming for assist | Aleksey Kladov | 2021-02-28 | 4 | -39/+39 | |
| | | ||||||
* | | Don't spam loop-rewriting assist | Aleksey Kladov | 2021-02-28 | 2 | -2/+22 | |
| | | | | | | | | The more focused the assist, the better! | |||||
* | | generate try_into instead of into | Domantas Jadenkus | 2021-02-27 | 3 | -72/+96 | |
| | | ||||||
* | | rename generate_enum_match_method file to match assist name | Domantas Jadenkus | 2021-02-27 | 2 | -2/+2 | |
| | | ||||||
* | | move into_ and as_ generation to a separate file | Domantas Jadenkus | 2021-02-27 | 4 | -402/+340 | |
| | | ||||||
* | | cargo fmt | Domantas Jadenkus | 2021-02-27 | 1 | -35/+20 | |
| | | ||||||
* | | add generate_enum_as_method assist | Domantas Jadenkus | 2021-02-27 | 3 | -0/+154 | |
| | | ||||||
* | | deduplicate some | Domantas Jadenkus | 2021-02-27 | 1 | -37/+28 | |
| | | ||||||
* | | add generate_enum_into_method assist | Domantas Jadenkus | 2021-02-27 | 3 | -20/+275 | |
| | | ||||||
* | | make generate_enum_is_method work on any variants | Domantas Jadenkus | 2021-02-27 | 1 | -18/+95 | |
| | | ||||||
* | | rename existing assist to generate_enum_is_method | Domantas Jadenkus | 2021-02-27 | 3 | -11/+11 | |
| | | ||||||
* | | Disable "Flip comma" assist inside a macro call | Denys Zadorozhnyi | 2021-02-26 | 1 | -2/+24 | |
| | | ||||||
* | | docs(ide_assists): Change importMergeBehaviour to importMergeBehavior | Sanchith Hegde | 2021-02-26 | 1 | -3/+3 | |
| | | ||||||
* | | Merge #7741 | bors[bot] | 2021-02-24 | 3 | -0/+326 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall Implements one direction of #7681 I wonder if this tries to guess too much at the right thing here. A common pattern is: ```rust let col = vec![1, 2, 3]; for v in &mut col { *v *= 2; } // equivalent to: col.iter_mut().for_each(|v| *v *= 2); ``` I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind: 1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types) 2. Try to check if iter/iter_mut exists and they return the right iterator type 3. Don't try to do this and just add `.into_iter()` to whatever is after `in` Co-authored-by: Matt Hall <[email protected]> | |||||
| * | | Address further review comments | Matt Hall | 2021-02-24 | 1 | -51/+35 | |
| | | | | | | | | | | | | | | | | | | * Use known names for iter/iter_mut method (simplifies checking if the method exists * Extract code to check assist with fixtures to function | |||||
| * | | Address review comments | Matt Hall | 2021-02-23 | 1 | -33/+125 | |
| | | | | | | | | | | | | | | | * Move code to build replacement into closure * Look for iter/iter_mut methods on types behind reference |