aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_completion/src/completions/unqualified_path.rs
Commit message (Collapse)AuthorAgeFilesLines
* simplifyLukas Tobias Wirth2021-05-051-2/+4
|
*-. Merge #7900 #8000bors[bot]2021-03-161-25/+25
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| * | show function params in completion detailJosh Mcguigan2021-03-121-25/+25
| |/
* / unqualfied_path completions aren't responsible for pattern completionsLukas Wirth2021-03-151-87/+1
|/
* Use upstream cov-markLaurențiu Nicola2021-03-081-7/+5
|
* rename completion -> ide_completionAleksey Kladov2021-02-171-0/+755
We don't have completion-related PRs in flight, so lets do it