aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_completion/src/render.rs
Commit message (Collapse)AuthorAgeFilesLines
* don't clone types that are copy (clippy::clone_on_copy)Matthias Krüger2021-03-171-1/+1
|
* minor style fixes per feedback on #8036Josh Mcguigan2021-03-161-27/+21
|
*-. Merge #7900 #8000bors[bot]2021-03-161-8/+46
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| * | show function params in completion detailJosh Mcguigan2021-03-121-8/+46
| | |
* | | completions: centralize calculation of relevance and ref matchesJosh Mcguigan2021-03-161-35/+147
| |/ |/|
* | implement function completion scoringJosh Mcguigan2021-03-151-0/+60
| |
* | remove expected_name_and_type method on completion context in favor of using ↵Josh Mcguigan2021-03-151-12/+4
| | | | | | | | fields added in #8008
* | update algorithm for determining expected type of completionJosh Mcguigan2021-03-151-12/+3
| |
* | increase completion relevance for items in local scopeJosh Mcguigan2021-03-141-28/+51
| |
* | Skip ref_match on same types, remove sorting in testsivan7702021-03-141-38/+25
| |
* | Added both references and original matches to testsivan7702021-03-131-34/+42
| |
* | Fix incorrect DerefMut test reference typeivan7702021-03-131-1/+1
| |
* | Make relevance tests display references, suggest derefs only when neededivan7702021-03-131-15/+83
| |
* | Simplify call site and deref completion testivan7702021-03-131-85/+16
| |
* | Count derefs as matched types if possibleivan7702021-03-131-3/+125
|/
* add completion relevance scoreJosh Mcguigan2021-03-121-10/+12
|
* Unify namingAleksey Kladov2021-03-121-8/+7
|
* use references in CompletionItem's builderyonip232021-03-111-31/+31
|
* Future proof completion scoresAleksey Kladov2021-03-091-58/+41
|
* Cleanup auto-ref in completionAleksey Kladov2021-03-091-17/+73
|
* CleanupAleksey Kladov2021-03-091-3/+5
|
* Work towards better import labelsKirill Bulatov2021-03-081-6/+8
|
* Fix some testsKirill Bulatov2021-03-081-2/+5
|
* Return more data about located importsKirill Bulatov2021-03-081-1/+1
|
* Use upstream cov-markLaurențiu Nicola2021-03-081-10/+8
|
* rename completion -> ide_completionAleksey Kladov2021-02-171-0/+945
We don't have completion-related PRs in flight, so lets do it