Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | don't clone types that are copy (clippy::clone_on_copy) | Matthias Krüger | 2021-03-17 | 1 | -1/+1 |
| | |||||
* | minor style fixes per feedback on #8036 | Josh Mcguigan | 2021-03-16 | 1 | -27/+21 |
| | |||||
*-. | Merge #7900 #8000 | bors[bot] | 2021-03-16 | 1 | -8/+46 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]> | ||||
| * | | show function params in completion detail | Josh Mcguigan | 2021-03-12 | 1 | -8/+46 |
| | | | |||||
* | | | completions: centralize calculation of relevance and ref matches | Josh Mcguigan | 2021-03-16 | 1 | -35/+147 |
| |/ |/| | |||||
* | | implement function completion scoring | Josh Mcguigan | 2021-03-15 | 1 | -0/+60 |
| | | |||||
* | | remove expected_name_and_type method on completion context in favor of using ↵ | Josh Mcguigan | 2021-03-15 | 1 | -12/+4 |
| | | | | | | | | fields added in #8008 | ||||
* | | update algorithm for determining expected type of completion | Josh Mcguigan | 2021-03-15 | 1 | -12/+3 |
| | | |||||
* | | increase completion relevance for items in local scope | Josh Mcguigan | 2021-03-14 | 1 | -28/+51 |
| | | |||||
* | | Skip ref_match on same types, remove sorting in tests | ivan770 | 2021-03-14 | 1 | -38/+25 |
| | | |||||
* | | Added both references and original matches to tests | ivan770 | 2021-03-13 | 1 | -34/+42 |
| | | |||||
* | | Fix incorrect DerefMut test reference type | ivan770 | 2021-03-13 | 1 | -1/+1 |
| | | |||||
* | | Make relevance tests display references, suggest derefs only when needed | ivan770 | 2021-03-13 | 1 | -15/+83 |
| | | |||||
* | | Simplify call site and deref completion test | ivan770 | 2021-03-13 | 1 | -85/+16 |
| | | |||||
* | | Count derefs as matched types if possible | ivan770 | 2021-03-13 | 1 | -3/+125 |
|/ | |||||
* | add completion relevance score | Josh Mcguigan | 2021-03-12 | 1 | -10/+12 |
| | |||||
* | Unify naming | Aleksey Kladov | 2021-03-12 | 1 | -8/+7 |
| | |||||
* | use references in CompletionItem's builder | yonip23 | 2021-03-11 | 1 | -31/+31 |
| | |||||
* | Future proof completion scores | Aleksey Kladov | 2021-03-09 | 1 | -58/+41 |
| | |||||
* | Cleanup auto-ref in completion | Aleksey Kladov | 2021-03-09 | 1 | -17/+73 |
| | |||||
* | Cleanup | Aleksey Kladov | 2021-03-09 | 1 | -3/+5 |
| | |||||
* | Work towards better import labels | Kirill Bulatov | 2021-03-08 | 1 | -6/+8 |
| | |||||
* | Fix some tests | Kirill Bulatov | 2021-03-08 | 1 | -2/+5 |
| | |||||
* | Return more data about located imports | Kirill Bulatov | 2021-03-08 | 1 | -1/+1 |
| | |||||
* | Use upstream cov-mark | Laurențiu Nicola | 2021-03-08 | 1 | -10/+8 |
| | |||||
* | rename completion -> ide_completion | Aleksey Kladov | 2021-02-17 | 1 | -0/+945 |
We don't have completion-related PRs in flight, so lets do it |