| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | | | | ||||||
| | \ \ | ||||||
| *-. \ \ | Merge #7900 #8000 | bors[bot] | 2021-03-16 | 7 | -82/+155 | |
| |\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]> | |||||
| | * | | | add params_display and ty_display | Josh Mcguigan | 2021-03-12 | 1 | -9/+17 | |
| | | | | | ||||||
| | * | | | show function params in completion detail | Josh Mcguigan | 2021-03-12 | 7 | -82/+147 | |
| | | | | | ||||||
| * | | | | completions: centralize calculation of relevance and ref matches | Josh Mcguigan | 2021-03-16 | 3 | -50/+172 | |
| | |_|/ |/| | | ||||||
| * | | | Merge #8035 | bors[bot] | 2021-03-15 | 3 | -120/+120 | |
| |\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | 8035: unqualfied_path completions aren't responsible for variant pattern completions r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]> | |||||
| | * | | unqualfied_path completions aren't responsible for pattern completions | Lukas Wirth | 2021-03-15 | 3 | -120/+120 | |
| | | | | ||||||
| * | | | implement function completion scoring | Josh Mcguigan | 2021-03-15 | 2 | -1/+76 | |
| |/ / | ||||||
| * | | Drop non-working mark | Laurențiu Nicola | 2021-03-15 | 1 | -2/+0 | |
| | | | ||||||
| * | | remove expected_name_and_type method on completion context in favor of using ↵ | Josh Mcguigan | 2021-03-15 | 1 | -12/+4 | |
| | | | | | | | | | fields added in #8008 | |||||
| * | | update algorithm for determining expected type of completion | Josh Mcguigan | 2021-03-15 | 2 | -26/+286 | |
| | | | ||||||
| * | | some clippy::performance fixes | Matthias Krüger | 2021-03-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | use vec![] instead of Vec::new() + push() avoid redundant clones use chars instead of &str for single char patterns in ends_with() and starts_with() allocate some Vecs with capacity to avoid unneccessary resizing | |||||
| * | | increase completion relevance for items in local scope | Josh Mcguigan | 2021-03-14 | 2 | -30/+86 | |
| | | | ||||||
| * | | Skip ref_match on same types, remove sorting in tests | ivan770 | 2021-03-14 | 1 | -38/+25 | |
| | | | ||||||
| * | | Added both references and original matches to tests | ivan770 | 2021-03-13 | 1 | -34/+42 | |
| | | | ||||||
| * | | Fix incorrect DerefMut test reference type | ivan770 | 2021-03-13 | 1 | -1/+1 | |
| | | | ||||||
| * | | Make relevance tests display references, suggest derefs only when needed | ivan770 | 2021-03-13 | 1 | -15/+83 | |
| | | | ||||||
| * | | Simplify call site and deref completion test | ivan770 | 2021-03-13 | 1 | -85/+16 | |
| | | | ||||||
| * | | Count derefs as matched types if possible | ivan770 | 2021-03-13 | 1 | -3/+125 | |
| |/ | ||||||
| * | update relevance score u8 -> u32 | Josh Mcguigan | 2021-03-12 | 1 | -2/+2 | |
| | | ||||||
| * | add relevance score test | Josh Mcguigan | 2021-03-12 | 1 | -0/+60 | |
| | | ||||||
| * | remove unused CompletionScore enum | Josh Mcguigan | 2021-03-12 | 2 | -12/+1 | |
| | | ||||||
| * | add completion relevance score | Josh Mcguigan | 2021-03-12 | 3 | -23/+58 | |
| | | ||||||
| * | Unify naming | Aleksey Kladov | 2021-03-12 | 13 | -103/+90 | |
| | | ||||||
| * | use references in CompletionItem's builder | yonip23 | 2021-03-11 | 17 | -166/+183 | |
| | | ||||||
| * | Future proof completion scores | Aleksey Kladov | 2021-03-09 | 3 | -70/+92 | |
| | | ||||||
| * | Cleanup auto-ref in completion | Aleksey Kladov | 2021-03-09 | 2 | -22/+81 | |
| | | ||||||
| * | Cleanup | Aleksey Kladov | 2021-03-09 | 1 | -4/+4 | |
| | | ||||||
| * | Cleanup | Aleksey Kladov | 2021-03-09 | 2 | -8/+7 | |
| | | ||||||
| * | Merge #7873 #7933 | bors[bot] | 2021-03-09 | 4 | -92/+268 | |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7873: Consider unresolved qualifiers during flyimport r=matklad a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/7679 Takes unresolved qualifiers into account, providing better completions (or none, if the path is resolved or do not match). Does not handle cases when both path qualifier and some trait has to be imported: there are many extra issues with those (such as overlapping imports, for instance) that will require large diffs to address. Also does not do a fuzzy search on qualifier, that requires some adjustments in `import_map` for better queries and changes to the default replace range which also seems relatively big to include here.  7933: Improve compilation speed r=matklad a=matklad bors r+ 🤖 Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> | |||||
| | * | Less lifetines: derive SemanticsScope in place | Kirill Bulatov | 2021-03-08 | 2 | -4/+9 | |
| | | | ||||||
| | * | Rebase leftovers | Kirill Bulatov | 2021-03-08 | 1 | -5/+2 | |
| | | | ||||||
| | * | Cleanup | Kirill Bulatov | 2021-03-08 | 1 | -6/+0 | |
| | | | ||||||
| | * | Restrict fuzzy qualifiers for now | Kirill Bulatov | 2021-03-08 | 1 | -4/+3 | |
| | | | ||||||
| | * | Test for fuzzy unresolved path maatch | Kirill Bulatov | 2021-03-08 | 1 | -0/+22 | |
| | | | ||||||
| | * | Fix the completion labels and tests | Kirill Bulatov | 2021-03-08 | 3 | -34/+48 | |
| | | | ||||||
| | * | Work towards better import labels | Kirill Bulatov | 2021-03-08 | 4 | -83/+92 | |
| | | | ||||||
| | * | Update the docs | Kirill Bulatov | 2021-03-08 | 1 | -0/+39 | |
| | | | ||||||
| | * | Simplify | Kirill Bulatov | 2021-03-08 | 1 | -25/+18 | |
| | | | ||||||
| | * | Refactor the import location | Kirill Bulatov | 2021-03-08 | 1 | -60/+5 | |
| | | | ||||||
| | * | Do not propose already imported imports | Kirill Bulatov | 2021-03-08 | 1 | -16/+7 | |
| | | | ||||||
| | * | Properly handle turbofishes in qualifiers | Kirill Bulatov | 2021-03-08 | 1 | -1/+1 | |
| | | | ||||||
| | * | Fix some tests | Kirill Bulatov | 2021-03-08 | 2 | -7/+65 | |
| | | | ||||||
| | * | Return more data about located imports | Kirill Bulatov | 2021-03-08 | 4 | -36/+37 | |
| | | | ||||||
| | * | Draft the qualifier import resolution | Kirill Bulatov | 2021-03-08 | 1 | -3/+81 | |
| | | | ||||||
| | * | Test and initial refactoring | Kirill Bulatov | 2021-03-08 | 1 | -3/+34 | |
| | | | ||||||
| * | | Fix format | Duong Do Minh Chau | 2021-03-09 | 1 | -9/+2 | |
| | | | ||||||
| * | | Add trailing commas | Duong Do Minh Chau | 2021-03-09 | 1 | -2/+2 | |
| | | | ||||||
| * | | Update the test to match the change | Duong Do Minh Chau | 2021-03-09 | 1 | -0/+4 | |
| | | | ||||||
| * | | Add completion to turn x.err into Err(x) | Duong Do Minh Chau | 2021-03-09 | 1 | -2/+19 | |
| |/ | ||||||
| * | Use upstream cov-mark | Laurențiu Nicola | 2021-03-08 | 11 | -63/+41 | |
| | | ||||||
 |
index : rust-analyzer | |
| [FORK] modified to work on wasm targets |
| aboutsummaryrefslogtreecommitdiff |