aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_completion/src
Commit message (Collapse)AuthorAgeFilesLines
* Paper over #8931 a bit moreFlorian Diebold2021-05-231-0/+1
| | | | | | | | | The problem was the skipping of binders in `resolve_method_call_as_callable`; this still doesn't use the _correct_ substitution, but at least it doesn't return a type with free variables in it. Fixes #8931.
* Add test for #8931 and better checkingFlorian Diebold2021-05-231-0/+29
|
* Fix compilation of hir and ide cratesFlorian Diebold2021-05-211-1/+1
|
* Replace ImportGranularity::Guess with guessing boolean flagLukas Tobias Wirth2021-05-191-0/+1
|
* MergeBehavior -> ImportGranularityLukas Tobias Wirth2021-05-181-2/+5
|
* simplifyLukas Wirth2021-05-151-12/+10
|
* Merge #8794bors[bot]2021-05-101-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8794: Give MergeBehaviour variants better names r=Veykril a=Veykril I never really liked the variant names I gave this enum from the beginning and then I found out about rustfmt's `imports_granularity` config: > imports_granularity > > How imports should be grouped into use statements. Imports will be merged or split to the configured level of granularity. > > Default value: Preserve > Possible values: Preserve, Crate, Module, Item > Stable: No I personally prefer using `crate` over `full` and `module` over last, they seem more descriptive. Keeping these similar between tooling also seems like a good plus point to me. We might even wanna take over the entire enum at some point if we have a `format/cleanup imports` assists in the future which would probably want to also have the `preserve` and `item` options. Co-authored-by: Lukas Wirth <[email protected]>
| * Give MergeBehaviour variants better namesLukas Wirth2021-05-101-1/+1
| |
* | Corrected 2 typos on line 83mixio2021-05-101-1/+1
|/
* Add `=` to pattern recoveryLukas Wirth2021-05-081-1/+22
|
* Small macro fixKirill Bulatov2021-05-061-1/+1
|
* internal: use API stabilized in 1.52Aleksey Kladov2021-05-061-1/+1
|
* SimplifyEdwin Cheng2021-05-061-6/+2
|
* Fix: Do not overwrite comments and attrs in trait impl completionJesse Bakker2021-05-061-8/+65
|
* simplifyLukas Tobias Wirth2021-05-054-38/+35
|
* Add some cov marks for qualified_path completionLukas Tobias Wirth2021-05-041-5/+8
|
* Complete enum variants through type aliasesLukas Tobias Wirth2021-05-041-7/+33
|
* Make CompletionContext expected_type smarterLukas Tobias Wirth2021-05-032-117/+113
|
* Fix feature description inconsistencyBrandon2021-05-011-1/+1
|
* internal: normalize nameAleksey Kladov2021-04-302-3/+3
| | | | All def types in hir are unsubstituted
* Split out merge_imports module from helpers::insert_useLukas Wirth2021-04-241-4/+1
|
* Add cov_marks to insert_use testsLukas Wirth2021-04-202-2/+2
|
* Remove SyntaxRewriter usage in insert_use in favor of tedLukas Wirth2021-04-201-4/+4
|
* Exclude inherent traits from flyimportsKirill Bulatov2021-04-161-0/+23
|
* Do not show flyimports in trait or impl declarationsKirill Bulatov2021-04-151-0/+50
|
* Use CompletionTextEdit::InsertAndReplace if supported by the clientLukas Wirth2021-04-081-1/+1
|
* Fix typomemoryruins2021-04-071-2/+2
|
* Do not import on the fly during fields of record literal syntaxmemoryruins2021-04-061-0/+43
|
* internal: document hypothetical completion problemAleksey Kladov2021-04-051-0/+28
|
* Resolve associated typesLukas Wirth2021-04-011-1/+1
|
* Merge #8267bors[bot]2021-03-312-0/+4
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8267: Adding gifs and screenshots for features in manual r=matklad a=MozarellaMan For #6539 This includes most of gif or screenshot examples of most items in the "Features" header. With the exceptions of: - **On Typing Assists** - couldn't get it to work for a demo, I'm probably missing something? - **Structural search and replace** - looked to be already a visual example of the feature - **Workspace symbol** - wasn't sure how best to show this, all of the examples maybe? Also wasn't sure of the best code example to show it off - **Semantic Syntax Highlighting** - seemed obvious enough to not need a screenshot, but I could easily add this All the gifs/pngs are hosted in this [comment](https://github.com/rust-analyzer/rust-analyzer/issues/6539#issuecomment-809574840). Please let me know if any of them aren't suitable (and why) and I'll improve it! Or if you don't like the theme/font Co-authored-by: Ayomide Bamidele <[email protected]>
| * Gifs and screenshots for features in manualAyomide Bamidele2021-03-312-0/+4
| |
* | Rename target_ty to self_tyLukas Wirth2021-03-293-3/+3
|/
* completion relevance distinguish between exact type match and could unifyJosh Mcguigan2021-03-264-43/+80
|
* completion relevance consider if types can be unifiedJosh Mcguigan2021-03-261-1/+32
|
* Merge hir::MacroDef::is_* into hir::MacroDef::kindLukas Wirth2021-03-231-1/+2
|
* add unit test to demonstrate struct fields/methods do not get ref match ↵Josh Mcguigan2021-03-231-0/+38
| | | | completions
* implement a temporary workaround for #8058Josh Mcguigan2021-03-224-7/+37
|
* Merge #8132bors[bot]2021-03-212-1/+36
|\ | | | | | | | | | | | | | | 8132: Add `'` to trigger_characters, allowing more direct lifetime completions r=Veykril a=Veykril Fixes having to type a character after `'` to complete lifetimes and labels Co-authored-by: Lukas Wirth <[email protected]>
| * Add `'` to trigger_characters, allowing more direct lifetime completionsLukas Wirth2021-03-212-1/+36
| |
* | clippy::complexity simplifications related to IteratorsMatthias Krüger2021-03-211-1/+1
| |
* | Less reallocationsKirill Bulatov2021-03-211-1/+0
| |
* | Use smart case in flyimport items lookupKirill Bulatov2021-03-211-3/+58
| |
* | Merge #8123bors[bot]2021-03-212-10/+50
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 8123: Do not display unqualified assoc item completions r=SomeoneToIgnore a=SomeoneToIgnore Part of https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/autoimport.20weirdness Removes all flyimport completions for any unqualified associated type, effectively reverting https://github.com/rust-analyzer/rust-analyzer/pull/8095 I've explained the reasoning in the corresponding FIXME and open to discussions. As an alternative way, we could add yet another parameter in the method that's used by the `qualify_path` and enable it for the qualify assists only. Co-authored-by: Kirill Bulatov <[email protected]>
| * Disable unqualified assoc items completion for nowKirill Bulatov2021-03-201-1/+1
| |
| * DocsKirill Bulatov2021-03-201-2/+2
| |
| * Do not query item search by name eagerlyKirill Bulatov2021-03-201-10/+18
| |
| * Do not propose assoc items without qualifiersKirill Bulatov2021-03-201-0/+32
| |
* | Fix incorrect scoping in while expressionsLukas Wirth2021-03-212-13/+40
| |
* | Add label completionLukas Wirth2021-03-214-7/+100
| |