aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_completion
Commit message (Collapse)AuthorAgeFilesLines
* don't clone types that are copy (clippy::clone_on_copy)Matthias Krüger2021-03-172-3/+3
|
* avoid converting types into themselves via .into() (clippy::useless-conversion)Matthias Krüger2021-03-172-2/+2
| | | | example: let x: String = String::from("hello world").into();
* Merge #8052bors[bot]2021-03-161-27/+21
|\ | | | | | | | | | | | | | | | | | | 8052: minor style fixes per feedback on #8036 r=JoshMcguigan a=JoshMcguigan cc @matklad - this PR addresses your comments in #8036. changelog fixup #8036 Co-authored-by: Josh Mcguigan <[email protected]>
| * minor style fixes per feedback on #8036Josh Mcguigan2021-03-161-27/+21
| |
* | Merge #8051bors[bot]2021-03-161-3/+3
|\ \ | |/ |/| | | | | | | | | | | | | | | 8051: Fix more unused wariable warnings r=lnicola a=lnicola bors r+ changelog skip Co-authored-by: Laurențiu Nicola <[email protected]>
| * Fix more unused wariable warningsLaurențiu Nicola2021-03-161-3/+3
| |
* | Merge #7498bors[bot]2021-03-164-22/+18
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 7498: Clone for update r=matklad a=matklad rowan counterpart https://github.com/rust-analyzer/rowan/pull/93 #6857 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Upgrade rowanAleksey Kladov2021-03-164-22/+18
| | | | | | | | | | | | Notably, new rowan comes with support for mutable syntax trees.
| | |
| \ \
*-. \ \ Merge #7900 #8000bors[bot]2021-03-167-82/+155
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7900: show function params in completion detail r=matklad a=JoshMcguigan This resolves #7842 by updating the detail for function completions from `-> T` to `fn(T, U) -> V`. I added an expicit unit test for this, `ide_completion::render::fn_detail_includes_args_and_return_type`, which passes. Lots of other unit tests fail (~60 of them) due to this change, although I believe the failures are purely cosmetic (they were testing the exact format of this output). I'm happy to go update those tests, but before I do that I'd like to make sure this is in fact the format we want for the detail? edit - I realized `UPDATE_EXPECT=1 cargo test` automatically updates `expect!` tests. Big :+1: to whoever worked on that! So I'll go ahead and update all these tests soon. But I still would like to confirm `fn(T, U) -> V` is the desired content in the `detail` field. 8000: Use hir formatter for hover text r=matklad a=oxalica Fix #2765 , (should) fix #4665 Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: oxalica <[email protected]>
| * | | add params_display and ty_displayJosh Mcguigan2021-03-121-9/+17
| | | |
| * | | show function params in completion detailJosh Mcguigan2021-03-127-82/+147
| | | |
* | | | completions: centralize calculation of relevance and ref matchesJosh Mcguigan2021-03-163-50/+172
| |_|/ |/| |
* | | Merge #8035bors[bot]2021-03-153-120/+120
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | 8035: unqualfied_path completions aren't responsible for variant pattern completions r=Veykril a=Veykril bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * | unqualfied_path completions aren't responsible for pattern completionsLukas Wirth2021-03-153-120/+120
| | |
* | | implement function completion scoringJosh Mcguigan2021-03-152-1/+76
|/ /
* | Drop non-working markLaurențiu Nicola2021-03-151-2/+0
| |
* | Enable thread-local coverage marksLaurențiu Nicola2021-03-151-1/+1
| |
* | remove expected_name_and_type method on completion context in favor of using ↵Josh Mcguigan2021-03-151-12/+4
| | | | | | | | fields added in #8008
* | update algorithm for determining expected type of completionJosh Mcguigan2021-03-152-26/+286
| |
* | some clippy::performance fixesMatthias Krüger2021-03-151-1/+1
| | | | | | | | | | | | | | use vec![] instead of Vec::new() + push() avoid redundant clones use chars instead of &str for single char patterns in ends_with() and starts_with() allocate some Vecs with capacity to avoid unneccessary resizing
* | increase completion relevance for items in local scopeJosh Mcguigan2021-03-142-30/+86
| |
* | Skip ref_match on same types, remove sorting in testsivan7702021-03-141-38/+25
| |
* | Added both references and original matches to testsivan7702021-03-131-34/+42
| |
* | Fix incorrect DerefMut test reference typeivan7702021-03-131-1/+1
| |
* | Make relevance tests display references, suggest derefs only when neededivan7702021-03-131-15/+83
| |
* | Simplify call site and deref completion testivan7702021-03-131-85/+16
| |
* | Count derefs as matched types if possibleivan7702021-03-131-3/+125
|/
* update relevance score u8 -> u32Josh Mcguigan2021-03-121-2/+2
|
* add relevance score testJosh Mcguigan2021-03-121-0/+60
|
* remove unused CompletionScore enumJosh Mcguigan2021-03-122-12/+1
|
* add completion relevance scoreJosh Mcguigan2021-03-123-23/+58
|
* Unify namingAleksey Kladov2021-03-1213-103/+90
|
* use references in CompletionItem's builderyonip232021-03-1117-166/+183
|
* Compilation speedAleksey Kladov2021-03-091-1/+1
|
* Future proof completion scoresAleksey Kladov2021-03-093-70/+92
|
* Cleanup auto-ref in completionAleksey Kladov2021-03-092-22/+81
|
* CleanupAleksey Kladov2021-03-091-4/+4
|
* CleanupAleksey Kladov2021-03-092-8/+7
|
* Merge #7873 #7933bors[bot]2021-03-094-92/+268
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7873: Consider unresolved qualifiers during flyimport r=matklad a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/7679 Takes unresolved qualifiers into account, providing better completions (or none, if the path is resolved or do not match). Does not handle cases when both path qualifier and some trait has to be imported: there are many extra issues with those (such as overlapping imports, for instance) that will require large diffs to address. Also does not do a fuzzy search on qualifier, that requires some adjustments in `import_map` for better queries and changes to the default replace range which also seems relatively big to include here. ![qualifier_completion](https://user-images.githubusercontent.com/2690773/110040808-0af8dc00-7d4c-11eb-83db-65af94e843bb.gif) 7933: Improve compilation speed r=matklad a=matklad bors r+ 🤖 Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| * Less lifetines: derive SemanticsScope in placeKirill Bulatov2021-03-082-4/+9
| |
| * Rebase leftoversKirill Bulatov2021-03-081-5/+2
| |
| * CleanupKirill Bulatov2021-03-081-6/+0
| |
| * Restrict fuzzy qualifiers for nowKirill Bulatov2021-03-081-4/+3
| |
| * Test for fuzzy unresolved path maatchKirill Bulatov2021-03-081-0/+22
| |
| * Fix the completion labels and testsKirill Bulatov2021-03-083-34/+48
| |
| * Work towards better import labelsKirill Bulatov2021-03-084-83/+92
| |
| * Update the docsKirill Bulatov2021-03-081-0/+39
| |
| * SimplifyKirill Bulatov2021-03-081-25/+18
| |
| * Refactor the import locationKirill Bulatov2021-03-081-60/+5
| |
| * Do not propose already imported importsKirill Bulatov2021-03-081-16/+7
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 20:47:03 +0000