aboutsummaryrefslogtreecommitdiff
path: root/crates/ide_db
Commit message (Collapse)AuthorAgeFilesLines
*-. Merge #6331 #6342bors[bot]2020-10-245-0/+1050
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6331: correct hover text for items with doc attribute with raw strings r=matklad a=JoshMcguigan Fixes #6300 by improving the handling of raw string literals in attribute style doc comments. This still has a bug where it could consume too many `"` at the start or end of the comment text, just as the original code had. Not sure if we want to fix that as part of this PR or not? If so, I think I'd prefer to add a unit test for either the `as_simple_key_value` function (I'm not exactly sure where this would belong / how to set this up) or create a `fn(&SmolStr) -> &SmolStr` to unit test by factoring out the `trim` operations from `as_simple_key_value`. Thoughts on this? 6342: Shorter dependency chain r=matklad a=popzxc Continuing implementing suggestions from the `Completion refactoring` zulip thread. This PR does the following: - Removes dependency of `completions` on `assists` by moving required functionality into `ide_db`. - Moves completely `call_info` crate into `ide_db` as it looks like it fits perfect there. - Adds a bunch of new tests and docs. - Adds the re-export of `base_db` to the `ide_db` and removes direct dependency on `base_db` from other crates. The last point is controversial, I guess, but I noticed that in places where `ide_db` is used, `base_db` is also *always* used. Thus I think the dependency on the `base_db` is implied by the fact of `ide_db` interfaces, and thus it makes sense to just provide `base_db` out of the box. Co-authored-by: Josh Mcguigan <[email protected]> Co-authored-by: Igor Aleksanov <[email protected]>
| | * Re-export base_db from ide_dbIgor Aleksanov2020-10-241-0/+3
| | |
| | * Add tests for traits functions in ide_dbIgor Aleksanov2020-10-241-0/+149
| | |
| | * Make call_info a part of ide_dbIgor Aleksanov2020-10-243-0/+760
| | |
| | * Remove dependency on 'assists' from 'completion' crateIgor Aleksanov2020-10-243-0/+138
| |/
* / Bump depsLaurențiu Nicola2020-10-241-1/+1
|/
* Clarify the names one more timeAleksey Kladov2020-10-153-9/+18
|
* More idiomatic classification APIAleksey Kladov2020-10-153-174/+174
|
* More clarificationsAleksey Kladov2020-10-152-12/+12
|
* Unconfuse expression and pattern field init shorthandsAleksey Kladov2020-10-152-7/+11
|
* Clarify NameClass names a bitAleksey Kladov2020-10-152-3/+3
|
* Treat `ast::Name` in field patterns as useJonas Schievink2020-10-091-43/+73
|
* Move ide::AnalysisChange -> base_db::ChangeAleksey Kladov2020-10-022-73/+7
| | | | | | This seems like a better factoring logically; ideally, clients shouldn't touch `set_` methods of the database directly. Additionally, I think this should remove the unfortunate duplication in fixture code.
* Remove periodic gc stubAleksey Kladov2020-09-293-46/+3
|
* Rename record_field_pat to record_pat_fieldPavan Kumar Sunkara2020-09-101-5/+5
|
* Add description for crates that will be publishedPavan Kumar Sunkara2020-08-241-0/+1
|
* Add version to deps in cargo.tomlPavan Kumar Sunkara2020-08-241-7/+7
|
* Optimize reference searchAleksey Kladov2020-08-191-25/+38
|
* **Remove Unused Parameter** refactoringAleksey Kladov2020-08-191-1/+1
|
* Future proof find-usages APIAleksey Kladov2020-08-191-13/+35
| | | | | | We might want to provide more efficient impls for check if usages exist, limiting the search, filtering and cancellation, so let's violate YAGNI a bit here.
* Introduce LabelAleksey Kladov2020-08-182-0/+50
|
* Rename ra_ide -> ideAleksey Kladov2020-08-132-2/+2
|
* Rename ra_assists -> assistsAleksey Kladov2020-08-131-2/+2
|
* Rename ra_ide_db -> ide_dbAleksey Kladov2020-08-1310-0/+2009
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 21:54:41 +0100