Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #65 | bors[bot] | 2018-09-08 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | | | 65: simplify r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | simplify | Aleksey Kladov | 2018-09-08 | 1 | -1/+1 |
| | | |||||
* | | Fix yet another parser infinite loop | Aleksey Kladov | 2018-09-08 | 2 | -8/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is an example of fixing a common parser error: infinite loop due to error recovery. This error typically happens when we parse a list of items and fail to parse a specific item at the current position. One choices is to skip a token and try to parse a list item at the next position. This is a good, but not universal, default. When parsing a list of arguments in a function call, you, for example, don't want to skip over `fn`, because it's most likely that it is a function declaration, and not a mistyped arg: ``` fn foo() { quux(1, 2 fn bar() { } ``` Another choice is to bail out of the loop immediately, but it isn't perfect either: sometimes skipping over garbage helps: ``` quux(1, foo:, 92) // should skip over `:`, b/c that's part of `foo::bar` ``` In general, parser tries to balance these two cases, though we don't have a definitive strategy yet. However, if the parser accidentally neither skips over a token, nor breaks out of the loop, then it becomes stuck in the loop infinitely (there's an internal counter to self-check this situation and panic though), and that's exactly what is demonstrated by the test. To fix such situation, first of all, add the test case to tests/data/parser/{err,fuzz-failures}. Then, run ``` RUST_BACKTRACE=short cargo test --package libsyntax2 ```` to verify that parser indeed panics, and to get an idea what grammar production is the culprit (look for `_list` functions!). In this case, I see ``` 10: libsyntax2::grammar::expressions::atom::match_arm_list at crates/libsyntax2/src/grammar/expressions/atom.rs:309 ``` and that's look like it might be a culprit. I verify it by adding `eprintln!("loopy {:?}", p.current());` and indeed I see that this is printed repeatedly. Diagnosing this a bit shows that the problem is that `pattern::pattern` function does not consume anything if the next token is `let`. That is a good default to make cases like ``` let let foo = 92; ``` where the user hasn't typed the pattern yet, to parse in a reasonable they correctly. For match arms, pretty much the single thing we expect is a pattern, so, for a fix, I introduce a special variant of pattern that does not do recovery. | ||||
* | | Add fuzz failures dir | Aleksey Kladov | 2018-09-08 | 2 | -4/+213 |
|/ | |||||
* | move fuzz-invariants to the library | Aleksey Kladov | 2018-09-08 | 3 | -41/+44 |
| | |||||
* | Add trivial fuzzer for parser | Pascal Hertleif | 2018-09-08 | 3 | -0/+38 |
| | | | | | | | | | | | | | As described in #61, fuzz testing some parts of this would be ~~fun~~ helpful. So, I started with the most trivial fuzzer I could think of: Put random stuff into File::parse and see what happens. To speed things up, I also did cp src/**/*.rs fuzz/corpus/parser/ in the `crates/libsyntax2/` directory (running the fuzzer once will generate the necessary directories). | ||||
* | Fix block structure in enums | Aleksey Kladov | 2018-09-08 | 5 | -25/+274 |
| | |||||
* | simplify | Aleksey Kladov | 2018-09-08 | 5 | -9/+14 |
| | |||||
* | Don't get stuck in tuple exprs | Aleksey Kladov | 2018-09-08 | 4 | -96/+484 |
| | |||||
* | Don't get stuck in macros | Aleksey Kladov | 2018-09-08 | 3 | -1/+54 |
| | |||||
* | fix stuck parser | Aleksey Kladov | 2018-09-08 | 7 | -2/+719 |
| | |||||
* | fix labled expressions | Aleksey Kladov | 2018-09-08 | 7 | -12/+308 |
| | |||||
* | nested mod completion | Aleksey Kladov | 2018-09-07 | 3 | -24/+21 |
| | |||||
* | Remove dyn dispatch | Aleksey Kladov | 2018-09-07 | 3 | -21/+65 |
| | |||||
* | Moved TokenSet into it's own file. | Zac Winter | 2018-09-06 | 4 | -37/+41 |
| | |||||
* | Added tests for Ptr. | Zach Lute | 2018-09-05 | 1 | -0/+78 |
| | |||||
* | Updated Ptr methods to better match Parser method names. | Zach Lute | 2018-09-05 | 5 | -45/+59 |
| | |||||
* | simplify | Aleksey Kladov | 2018-09-04 | 1 | -5/+5 |
| | |||||
* | for types in bounds | Aleksey Kladov | 2018-09-04 | 16 | -190/+309 |
| | |||||
* | accidentally quadratic | Aleksey Kladov | 2018-09-04 | 1 | -16/+35 |
| | |||||
* | extern blocks | Aleksey Kladov | 2018-09-03 | 5 | -2/+1005 |
| | |||||
* | faster text len | Aleksey Kladov | 2018-09-03 | 2 | -2/+2 |
| | |||||
* | completion for trait params | Aleksey Kladov | 2018-09-03 | 2 | -0/+2 |
| | |||||
* | Complete params | Aleksey Kladov | 2018-09-03 | 8 | -160/+178 |
| | |||||
* | method call scope | Aleksey Kladov | 2018-09-03 | 3 | -6/+18 |
| | |||||
* | match scope | Aleksey Kladov | 2018-09-02 | 2 | -6/+36 |
| | |||||
* | Type aliases to scope | Aleksey Kladov | 2018-09-01 | 2 | -1/+4 |
| | |||||
* | complete self | Aleksey Kladov | 2018-08-31 | 2 | -0/+23 |
| | |||||
* | handle shadowing | Aleksey Kladov | 2018-08-31 | 1 | -1/+1 |
| | |||||
* | default method name to type name | Aleksey Kladov | 2018-08-31 | 3 | -83/+47 |
| | |||||
* | tweak extend selection | Aleksey Kladov | 2018-08-31 | 1 | -0/+12 |
| | |||||
* | start item recovery | Aleksey Kladov | 2018-08-31 | 7 | -9/+40 |
| | |||||
* | break/continue completion | Aleksey Kladov | 2018-08-30 | 3 | -16/+13 |
| | |||||
* | complete imports | Aleksey Kladov | 2018-08-30 | 2 | -5/+106 |
| | |||||
* | Complete types | Aleksey Kladov | 2018-08-30 | 2 | -1/+20 |
| | |||||
* | fix tests | Aleksey Kladov | 2018-08-29 | 2 | -24/+23 |
| | |||||
* | add impl works with lifetimes | Aleksey Kladov | 2018-08-28 | 4 | -8/+119 |
| | |||||
* | simplify | Aleksey Kladov | 2018-08-28 | 1 | -0/+3 |
| | |||||
* | be more careful with adding semis | Aleksey Kladov | 2018-08-28 | 1 | -0/+6 |
| | |||||
* | Add ret type | Aleksey Kladov | 2018-08-28 | 12 | -55/+91 |
| | |||||
* | better pattern recovery | Aleksey Kladov | 2018-08-28 | 5 | -8/+90 |
| | |||||
* | complete items from module scope | Aleksey Kladov | 2018-08-28 | 2 | -0/+5 |
| | |||||
* | join any block | Aleksey Kladov | 2018-08-28 | 2 | -0/+23 |
| | |||||
* | Simplify API | Aleksey Kladov | 2018-08-28 | 2 | -5/+1 |
| | |||||
* | Avoid materializing strings | Aleksey Kladov | 2018-08-28 | 5 | -21/+129 |
| | |||||
* | tone down on eq typed | Aleksey Kladov | 2018-08-28 | 1 | -1/+1 |
| | |||||
* | better recovery for exprs | Aleksey Kladov | 2018-08-28 | 9 | -21/+167 |
| | |||||
* | Log errors | Aleksey Kladov | 2018-08-27 | 1 | -0/+10 |
| | |||||
* | Add runnables | Aleksey Kladov | 2018-08-27 | 2 | -1/+13 |
| | |||||
* | Fix error blocks | Aleksey Kladov | 2018-08-27 | 4 | -0/+17 |
| |