| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
throughs cargo
|
| |
|
| |
|
|
|
|
|
|
|
| |
At the moment,the popup is just a bazillion of Cargo's "Compiling this\nCompiling that",
which is not that useful.
--quiet still displays error, which is what we needc
|
|
|
|
|
|
|
| |
reading both stdout & stderr is a common gotcha, you need to drain them
concurrently to avoid deadlocks. Not sure why I didn't do the right
thing from the start. Seems like I assumed the stderr is short? That's
not the case when cargo spams `compiling xyz` messages
|
| |
|
|
|
|
|
|
| |
status bar
closes #3155
|
| |
|
|
|
|
| |
Work towards #3155
|
| |
|
|
|
|
|
|
|
| |
use vec![] instead of Vec::new() + push()
avoid redundant clones
use chars instead of &str for single char patterns in ends_with() and starts_with()
allocate some Vecs with capacity to avoid unneccessary resizing
|
| |
|
| |
|
|
|
|
| |
This reverts commit ddce6bb282764692d53b719bff4c37e3512d4556.
|
| |
|
|
|
|
| |
It's worse than I thought...
|
|
|
|
|
| |
Also add some more detailed comments
Extract into function deleted the previous comments
|
|
|
|
|
|
| |
This gives the advantage that
A future extension would be to check for `feature(rustc_private)` instead
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This is a hack to work around miri being included in
our analysis of rustc-dev
Really, we should probably use an include set of the actual root libraries
I'm not sure how those are determined however
|
| |
|
| |
|
| |
|
|
|
|
|
| |
If the configured rustcSource is set to "discover", try to automatically
detect a source from the sysroot rustc directory.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
I've noticed a bunch of "main loop too long" warnings in console when
typing in Cargo.toml. Profiling showed that the culprit is `rustc
--print cfg` call.
I moved it to the background project loading phase, where it belongs.
This highlighted a problem: we generally use single `cfg`, while it
really should be per crate.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
| |
https://github.com/rust-analyzer/rust-analyzer/issues/5040#issuecomment-759853153
|
|
|
|
| |
It now pulls in a newer version of semver-parser.
|
| |
|
|
|
|
| |
This adds a description for `TargetData` and all its fields.
|
|
|
|
| |
This adds a description for `PackageData` and all its fields.
|
|
|
|
|
| |
This makes them discoverable through documentation.
They were already publicly accessible through `Package` and `Target`.
|
|
|
|
|
|
|
| |
Rather than eagerly converting JSON, we losslessly keep it as is, and
change the shape of user-submitted data at the last moment.
This also allows us to remove a bunch of wrong Defaults
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
7071: Pass --all-targets to "cargo check" when discovering external resources r=matklad a=WasabiFan
There is a repro case and background in the linked issue.
In short, the goal of this MR is to allow rust-analyzer to discover proc-macros which come from your tests (including, most importantly, dev-dependencies).
By default, `cargo check` implies the equivalent of `--lib --bins`, meaning it'll check your libraries and binaries -- but not tests! This means proc-macros (or, I guess, build scripts as well) weren't discovered by rust-analyzer if they came from tests.
One solution would be to manually add `--lib --bins --tests` (i.e., just augment the effective options to include tests). However, in this MR, I threw in `--all-targets`, which [according to the docs](https://doc.rust-lang.org/cargo/commands/cargo-check.html#target-selection) implies `--benches --examples` too. I have absolutely no idea what repercussions that will have on rust-analyzer for other projects, nor do I know if it's a problem that build scripts will now be discovered for tests/examples/benches. But I am not aware of a reason you _wouldn't_ want to discover these things in your examples too.
I think the main drawback of this change is that it will likely slow down the `cargo check`. At a minimum, it'll now be checking your tests _and_ their dependencies. The `cargo check` docs also say that including `--tests` as I have here may cause your lib crate to be built _twice_, once for the normal target and again for unit tests. My reading of that caveat suggests that "building twice" means it's built once for the tests _inside_ your lib, with a test profile, and again for any consumers of your lib, now using a normal release profile or similar. This doesn't seem surprising.
Very minor caveat: `--tests` will not include tests within a binary if it has `test = false` set in `Cargo.toml`. (I discovered this manually by trial-and-error, but hey, it actually says that in the docs!) This is likely not an issue, but _does_ mean that if you are -- for whatever reason -- disabling tests like that and then manually specifying `cargo test --package <...> --bin <...>` to run them, rust-analyzer will remain unaware of proc-macros in your tests.
I have confirmed this fixes the original issue in my sandbox example linked in #7034 and in my own project in which I originally discovered this. I've left it configured as my default RA language server and will report back if I notice any unexpected side-effects.
Fixes #7034
Co-authored-by: Kaelin Laundry <[email protected]>
|
| | |
|
| | |
|
|/ |
|