aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_assists/src/handlers
Commit message (Collapse)AuthorAgeFilesLines
* Correctly fill default type parametersFedor Sakharov2020-05-131-0/+50
|
*---. Merge #4406 #4410 #4411 #4417bors[bot]2020-05-102-29/+194
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4406: Update cargo-metadata r=matklad a=edwin0cheng This PR update `cargo-metadata` to 0.10.0 and it also relax the` serde-derive` deps to 1.0 for tests in `proc-macro-srv`. cc @robojumper r= @matklad , I think you would have something to say related to https://github.com/serde-rs/json/issues/647#issue-593788429 ? 4410: Improve wording in comment r=matklad a=edwin0cheng 4411: do not remove then block when you unwrap else block #4361 r=matklad a=bnjjj close #4361 4417: Omit default types in HirDisplay SourceCode mode r=matklad a=TimoFreiberg Closes #4390 Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Timo Freiberg <[email protected]>
| | | * Omit default types in HirDisplay SourceCode modeTimo Freiberg2020-05-101-1/+1
| |_|/ |/| |
| | * do not remove then block when you unwrap else block #4361Benjamin Coenen2020-05-101-28/+193
| |/ |/| | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #4392bors[bot]2020-05-091-14/+11
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4392: Add From should not move the cursor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add From should not move the cursorAleksey Kladov2020-05-091-14/+11
| | |
* | | Ascribe more correct typesAleksey Kladov2020-05-091-9/+10
|/ /
* | unindent -> dedentAleksey Kladov2020-05-091-1/+1
| |
* | More fluent indent APIAleksey Kladov2020-05-096-21/+32
| |
* | Use new HirDisplay variant in add_function assistTimo Freiberg2020-05-081-58/+116
|/
* SimplifyAleksey Kladov2020-05-074-4/+4
|
* Refactor assists API to be more convenient for adding new assistsAleksey Kladov2020-05-0734-410/+372
| | | | It now duplicates completion API in its shape.
* add Ok wrappingBenjamin Coenen2020-05-061-0/+971
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* SimplifyAleksey Kladov2020-05-061-7/+7
|
* Fix TODOAleksey Kladov2020-05-061-15/+9
|
* Move target to AssistLabelAleksey Kladov2020-05-0633-236/+276
| | | | | Target is used for assists sorting, so we need it before we compute the action.
* Merge assits::test_helpers and testsAleksey Kladov2020-05-0632-32/+32
|
* Rename ImplItem to AssocItemEdwin Cheng2020-05-052-15/+15
|
* Merge #4265bors[bot]2020-05-051-3/+10
|\ | | | | | | | | | | | | | | 4265: Make `change_visibility` assist work for tuple struct fields r=matklad a=Jesse-Bakker Fixes #4206 Co-authored-by: Jesse Bakker <[email protected]>
| * Make `change_visibility` assist work for tuple struct field visibilityJesse Bakker2020-05-021-3/+10
| |
* | SimplifyAleksey Kladov2020-05-041-33/+34
| |
* | SimplifyAleksey Kladov2020-05-041-13/+13
| |
* | Support auto-import in macroEdwin Cheng2020-05-022-9/+35
|/
* Add unwrap block assist #4156Benjamin Coenen2020-05-021-3/+2
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-026-90/+129
|\
| * Add missing members generates indented blocksAleksey Kladov2020-05-021-78/+116
| |
| * Introduce EffectExprAleksey Kladov2020-05-024-11/+12
| |
| * Remove lower_path from AssistCtx to SemanticEdwin Cheng2020-05-011-1/+1
| |
| * Introduce LowerCtx for path loweringEdwin Cheng2020-05-011-1/+1
| |
* | Add unwrap block assist #4156Benjamin Coenen2020-05-021-76/+13
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Add unwrap block assist #4156Benjamin Coenen2020-05-011-46/+23
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge branch 'master' of github.com:rust-analyzer/rust-analyzerBenjamin Coenen2020-05-014-89/+127
|\|
| * More principled approach for finding From traitAleksey Kladov2020-04-291-36/+34
| |
| * Use specific pattern when translating if-let-else to matchAleksey Kladov2020-04-293-10/+76
| | | | | | | | | | | | We *probably* should actually use the same machinery here, as we do for fill match arms, but just special-casing options and results seems to be a good first step.
| * Move shared assist code to utilsAleksey Kladov2020-04-292-47/+21
| |
* | Add unwrap block assist #4156Benjamin Coenen2020-04-291-2/+2
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Add unwrap block assist #4156Benjamin Coenen2020-04-291-0/+435
|/ | | | Signed-off-by: Benjamin Coenen <[email protected]>
* Switch to TryFromAleksey Kladov2020-04-254-6/+6
|
* Convert code to text-sizeAleksey Kladov2020-04-2519-49/+49
|
* Add `pub(crate)` to functions generated in other moduleTimo Freiberg2020-04-211-46/+23
|
* Jump to sourceChanges in other filesTimo Freiberg2020-04-211-11/+2
|
* Add target file information to AssistActionTimo Freiberg2020-04-211-14/+57
|
* Make add_function generate functions in other modules via qualified pathTimo Freiberg2020-04-211-24/+195
|
* Do not add default and closure types in 'add explicit type' assistKirill Bulatov2020-04-211-5/+43
|
* Fix panic in split_imports assistAleksey Kladov2020-04-201-1/+6
| | | | | | | | | | | | | | | The fix is admittedly quit literally just papering over. Long-term, I see two more principled approaches: * we switch to a fully tree-based impl, without parse . to_string step; with this approach, there shouldn't be any panics. The results might be nonsensical, but so was the original input. * we preserve the invariant that re-parsing constructed node is an identity, and make all the `make_xxx` method return an `Option`. closes #4044
* Some clippy fixesJeremy Kolb2020-04-193-3/+3
|
* Change add_function assist to use todo!()Timo Freiberg2020-04-131-27/+27
|
* Fix PRIceSentry2020-04-131-14/+8
|
* Generalize test and clean up importsIceSentry2020-04-131-8/+7
|
* Fix double comma when merge imports on second lineIceSentry2020-04-131-3/+37
| | | | | | | | | | | This fixes the a bug when merging imports from the second line when it already has a comma it would previously insert a comma. There's probably a better way to check for a COMMA. This also ends up with a weird indentation, but rust-fmt can easily deal with it so I'm not sure how to resolve that. Closes #3832