Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Merge #4445 | bors[bot] | 2020-05-14 | 1 | -0/+50 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4445: Correctly fill default type parameters r=flodiebold a=montekki Fixes #3877 So, basically even if the parameters are omitted from the `impl` block, check the parameters in `trait` if they have a default type, and if they do go from `hir` to `ast::TypeArg`. I've added a helper for that but I am not sure that it's a proper way to go from `hir` to `ast` here. Co-authored-by: Fedor Sakharov <[email protected]> | |||||
| * | | Correctly fill default type parameters | Fedor Sakharov | 2020-05-13 | 1 | -0/+50 | |
| | | | ||||||
* | | | Use back ticks instead of single quotes around code | Trevor Spiteri | 2020-05-14 | 2 | -2/+2 | |
|/ / | ||||||
| | | ||||||
| \ | ||||||
| \ | ||||||
| \ | ||||||
*---. \ | Merge #4406 #4410 #4411 #4417 | bors[bot] | 2020-05-10 | 2 | -29/+194 | |
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4406: Update cargo-metadata r=matklad a=edwin0cheng This PR update `cargo-metadata` to 0.10.0 and it also relax the` serde-derive` deps to 1.0 for tests in `proc-macro-srv`. cc @robojumper r= @matklad , I think you would have something to say related to https://github.com/serde-rs/json/issues/647#issue-593788429 ? 4410: Improve wording in comment r=matklad a=edwin0cheng 4411: do not remove then block when you unwrap else block #4361 r=matklad a=bnjjj close #4361 4417: Omit default types in HirDisplay SourceCode mode r=matklad a=TimoFreiberg Closes #4390 Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Timo Freiberg <[email protected]> | |||||
| | | * | Omit default types in HirDisplay SourceCode mode | Timo Freiberg | 2020-05-10 | 1 | -1/+1 | |
| |_|/ |/| | | ||||||
| | * | do not remove then block when you unwrap else block #4361 | Benjamin Coenen | 2020-05-10 | 1 | -28/+193 | |
| |/ |/| | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | | Merge #4392 | bors[bot] | 2020-05-09 | 1 | -14/+11 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4392: Add From should not move the cursor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | |||||
| * | | Add From should not move the cursor | Aleksey Kladov | 2020-05-09 | 1 | -14/+11 | |
| | | | ||||||
* | | | Ascribe more correct types | Aleksey Kladov | 2020-05-09 | 1 | -9/+10 | |
|/ / | ||||||
* | | unindent -> dedent | Aleksey Kladov | 2020-05-09 | 1 | -1/+1 | |
| | | ||||||
* | | More fluent indent API | Aleksey Kladov | 2020-05-09 | 6 | -21/+32 | |
| | | ||||||
* | | Use new HirDisplay variant in add_function assist | Timo Freiberg | 2020-05-08 | 1 | -58/+116 | |
|/ | ||||||
* | Simplify | Aleksey Kladov | 2020-05-07 | 4 | -4/+4 | |
| | ||||||
* | Refactor assists API to be more convenient for adding new assists | Aleksey Kladov | 2020-05-07 | 34 | -410/+372 | |
| | | | | It now duplicates completion API in its shape. | |||||
* | add Ok wrapping | Benjamin Coenen | 2020-05-06 | 1 | -0/+971 | |
| | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | Simplify | Aleksey Kladov | 2020-05-06 | 1 | -7/+7 | |
| | ||||||
* | Fix TODO | Aleksey Kladov | 2020-05-06 | 1 | -15/+9 | |
| | ||||||
* | Move target to AssistLabel | Aleksey Kladov | 2020-05-06 | 33 | -236/+276 | |
| | | | | | Target is used for assists sorting, so we need it before we compute the action. | |||||
* | Merge assits::test_helpers and tests | Aleksey Kladov | 2020-05-06 | 32 | -32/+32 | |
| | ||||||
* | Rename ImplItem to AssocItem | Edwin Cheng | 2020-05-05 | 2 | -15/+15 | |
| | ||||||
* | Merge #4265 | bors[bot] | 2020-05-05 | 1 | -3/+10 | |
|\ | | | | | | | | | | | | | | | 4265: Make `change_visibility` assist work for tuple struct fields r=matklad a=Jesse-Bakker Fixes #4206 Co-authored-by: Jesse Bakker <[email protected]> | |||||
| * | Make `change_visibility` assist work for tuple struct field visibility | Jesse Bakker | 2020-05-02 | 1 | -3/+10 | |
| | | ||||||
* | | Simplify | Aleksey Kladov | 2020-05-04 | 1 | -33/+34 | |
| | | ||||||
* | | Simplify | Aleksey Kladov | 2020-05-04 | 1 | -13/+13 | |
| | | ||||||
* | | Support auto-import in macro | Edwin Cheng | 2020-05-02 | 2 | -9/+35 | |
|/ | ||||||
* | Add unwrap block assist #4156 | Benjamin Coenen | 2020-05-02 | 1 | -3/+2 | |
| | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | Merge branch 'master' of github.com:rust-analyzer/rust-analyzer | Benjamin Coenen | 2020-05-02 | 6 | -90/+129 | |
|\ | ||||||
| * | Add missing members generates indented blocks | Aleksey Kladov | 2020-05-02 | 1 | -78/+116 | |
| | | ||||||
| * | Introduce EffectExpr | Aleksey Kladov | 2020-05-02 | 4 | -11/+12 | |
| | | ||||||
| * | Remove lower_path from AssistCtx to Semantic | Edwin Cheng | 2020-05-01 | 1 | -1/+1 | |
| | | ||||||
| * | Introduce LowerCtx for path lowering | Edwin Cheng | 2020-05-01 | 1 | -1/+1 | |
| | | ||||||
* | | Add unwrap block assist #4156 | Benjamin Coenen | 2020-05-02 | 1 | -76/+13 | |
| | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | | Add unwrap block assist #4156 | Benjamin Coenen | 2020-05-01 | 1 | -46/+23 | |
| | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzer | Benjamin Coenen | 2020-05-01 | 4 | -89/+127 | |
|\| | ||||||
| * | More principled approach for finding From trait | Aleksey Kladov | 2020-04-29 | 1 | -36/+34 | |
| | | ||||||
| * | Use specific pattern when translating if-let-else to match | Aleksey Kladov | 2020-04-29 | 3 | -10/+76 | |
| | | | | | | | | | | | | We *probably* should actually use the same machinery here, as we do for fill match arms, but just special-casing options and results seems to be a good first step. | |||||
| * | Move shared assist code to utils | Aleksey Kladov | 2020-04-29 | 2 | -47/+21 | |
| | | ||||||
* | | Add unwrap block assist #4156 | Benjamin Coenen | 2020-04-29 | 1 | -2/+2 | |
| | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | | Add unwrap block assist #4156 | Benjamin Coenen | 2020-04-29 | 1 | -0/+435 | |
|/ | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | Switch to TryFrom | Aleksey Kladov | 2020-04-25 | 4 | -6/+6 | |
| | ||||||
* | Convert code to text-size | Aleksey Kladov | 2020-04-25 | 19 | -49/+49 | |
| | ||||||
* | Add `pub(crate)` to functions generated in other module | Timo Freiberg | 2020-04-21 | 1 | -46/+23 | |
| | ||||||
* | Jump to sourceChanges in other files | Timo Freiberg | 2020-04-21 | 1 | -11/+2 | |
| | ||||||
* | Add target file information to AssistAction | Timo Freiberg | 2020-04-21 | 1 | -14/+57 | |
| | ||||||
* | Make add_function generate functions in other modules via qualified path | Timo Freiberg | 2020-04-21 | 1 | -24/+195 | |
| | ||||||
* | Do not add default and closure types in 'add explicit type' assist | Kirill Bulatov | 2020-04-21 | 1 | -5/+43 | |
| | ||||||
* | Fix panic in split_imports assist | Aleksey Kladov | 2020-04-20 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | The fix is admittedly quit literally just papering over. Long-term, I see two more principled approaches: * we switch to a fully tree-based impl, without parse . to_string step; with this approach, there shouldn't be any panics. The results might be nonsensical, but so was the original input. * we preserve the invariant that re-parsing constructed node is an identity, and make all the `make_xxx` method return an `Option`. closes #4044 | |||||
* | Some clippy fixes | Jeremy Kolb | 2020-04-19 | 3 | -3/+3 | |
| | ||||||
* | Change add_function assist to use todo!() | Timo Freiberg | 2020-04-13 | 1 | -27/+27 | |
| | ||||||
* | Fix PR | IceSentry | 2020-04-13 | 1 | -14/+8 | |
| |