aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_assists/src/handlers
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5554bors[bot]2020-07-291-9/+85
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5554: Fix remove_dbg r=matklad a=petr-tik Closes #5129 Addresses two issues: - keep the parens from dbg!() in case the call is chained or there is semantic difference if parens are excluded - Exclude the semicolon after the dbg!(); by checking if it was accidentally included in the macro_call investigated, but decided against: fix ast::MacroCall extraction to never include semicolons at the end - this logic lives in rowan. Defensively shorten the macro_range if there is a semicolon token. Deleted unneccessary temp variable macro_args Renamed macro_content to "paste_instead_of_dbg", because it isn't a simple extraction of text inside dbg!() anymore Co-authored-by: petr-tik <[email protected]>
| * Addressed code reviewpetr-tik2020-07-291-27/+41
| | | | | | | | | | | | | | replaced match with let-if variable assignment removed the unnecessary semicolon_on_end variable converted all code and expected test variables to raw strings and inlined them in asserts
| * Fixed #5129petr-tik2020-07-271-8/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses two issues: - keep the parens from dbg!() in case the call is chained or there is semantic difference if parens are excluded - Exclude the semicolon after the dbg!(); by checking if it was accidentally included in the macro_call investigated, but decided against: fix ast::MacroCall extraction to never include semicolons at the end - this logic lives in rowan. Defensively shorten the macro_range if there is a semicolon token. Deleted unneccessary temp variable macro_args Renamed macro_content to "paste_instead_of_dbg", because it isn't a simple extraction of text inside dbg!() anymore
| * Make all test fn names consistent in remove_dbgpetr-tik2020-07-271-3/+29
| |
| * Added failing testspetr-tik2020-07-271-0/+21
| |
* | Rename NomialDef -> AdtDefAleksey Kladov2020-07-292-3/+3
|/
* assists: change_return_type_to_result: clarify assist descriptionMatthias Krüger2020-07-221-1/+1
| | | | | | | | I had a -> Option<PathBuf> fn, which I wanted to change to Result<PathBuf, _>, but despite advertising to do so, the assist did not change the result type to Result<PathBuf, _> but instead just wrapped it in a Result: <Result<Option<PathBuf>, _>. I changed the assist description to "Wrap return type in Result" to clarify that the assist only wraps the preexisting type and does not do any deep Option-to-Result refactoring.
* Replace existing visibility modifier in fix_visibilityTimo Freiberg2020-07-211-15/+75
|
* Cleanup extact variableAleksey Kladov2020-07-211-48/+55
|
* minorAleksey Kladov2020-07-211-2/+2
|
* Minor perf tweaks per clippyJeremy Kolb2020-07-192-2/+2
|
* Add turbo-fish works after `()`Aleksey Kladov2020-07-181-1/+28
|
* More precise ranges in remove hashes assistAleksey Kladov2020-07-171-79/+52
|
* Move remove_bounds to edit.rsJonas Schievink2020-07-141-9/+1
|
* missing impl members: remove assoc. type boundsJonas Schievink2020-07-141-0/+33
|
* change vis works on staticsAleksey Kladov2020-07-121-3/+13
|
* Better caret placement when filling match armsAleksey Kladov2020-07-101-124/+86
|
* Don't mess with cursor position when adding hashesAleksey Kladov2020-07-091-9/+22
|
* Add AssistKind::GenerateAleksey Kladov2020-07-035-25/+30
|
* Unify naming of generating assistsAleksey Kladov2020-07-035-87/+96
|
* Don't categorize things we don't care aboutkjeremy2020-07-023-62/+52
|
* Move AssistKind into AssistIdkjeremy2020-07-0238-118/+72
|
* Recategorize a fewkjeremy2020-07-023-3/+3
|
* Categorize assistsJeremy Kolb2020-07-0238-497/+682
|
* Record and suggest trait items via ImportMapJonas Schievink2020-07-021-0/+140
|
* Reuse Semantics instancesLaurențiu Nicola2020-07-012-2/+2
|
* Use the existing Semantics in auto_importLaurențiu Nicola2020-07-011-6/+6
|
* Remove db from AssistsContextLaurențiu Nicola2020-07-0110-32/+32
|
* Use more of FxHash*Laurențiu Nicola2020-06-291-3/+3
|
* Get rid of unused importsVeetaha2020-06-282-10/+3
|
* Follow matklad suggestionsVeetaha2020-06-283-17/+3
| | | | | | - Move vis_offset() to utils.rs - Shorten explicit ra_syntax::ast -> ast - Undo refactoring exhaustive pattern to non-exhaustive
* Simlify with matches!()Veetaha2020-06-283-17/+5
|
* introduce_variable -> extract_variableAleksey Kladov2020-06-271-53/+53
|
* Merge #4945bors[bot]2020-06-261-2/+31
|\ | | | | | | | | | | | | | | 4945: do not suggest assist for return type to result in bad case r=matklad a=bnjjj close #4826 Co-authored-by: Benjamin Coenen <[email protected]>
| * do not suggest assist for return type to result in bad case #4826Benjamin Coenen2020-06-211-0/+3
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * do not suggest assist for return type to result in bad case #4826Benjamin Coenen2020-06-181-2/+28
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Smarter introduce variableAleksey Kladov2020-06-251-8/+49
| | | | | | | | Use field init shorthand
* | Centralize fixture parsing for assistsAleksey Kladov2020-06-234-35/+40
| |
* | More principled indentation trimming in fixturesAleksey Kladov2020-06-233-123/+127
| |
* | Fix panic in split and merge import assistsLaurențiu Nicola2020-06-232-1/+21
| |
* | Remove RelativePathBuf from fixtureAleksey Kladov2020-06-223-3/+3
|/ | | | | The paths in fixture are not really relative (the default one is `/main.rs`), so it doesn't make sense to use `RelativePathBuf` here.
* Merge #4878bors[bot]2020-06-161-50/+230
|\ | | | | | | | | | | | | | | 4878: Make "Replace qualified name with use" replace *all* mentions of the path r=matklad a=jonas-schievink Fixes https://github.com/rust-analyzer/rust-analyzer/issues/4836 Co-authored-by: Jonas Schievink <[email protected]>
| * Operate only on AST paths instead of HIRJonas Schievink2020-06-151-30/+36
| |
| * SimplifyJonas Schievink2020-06-151-13/+6
| |
| * It's fookin' rawJonas Schievink2020-06-151-48/+48
| |
| * Shorten *all* qualified paths when adding useJonas Schievink2020-06-131-10/+191
| |
* | fill_match_arms bind pattern implementationToby Dimmick2020-06-141-2/+14
| |
* | fill_match_arms bind pattern testToby Dimmick2020-06-141-0/+34
|/
* Respect casing when searching for importsJonas Schievink2020-06-101-0/+25
|
* Add test for macro generated itemsJonas Schievink2020-06-101-0/+31
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 09:52:31 +0000