Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | review comments | Josh Mcguigan | 2020-03-23 | 1 | -16/+108 | |
| | | ||||||
* | | implement fill match arm assist for tuple of enums | Josh Mcguigan | 2020-03-23 | 1 | -14/+149 | |
|/ | ||||||
* | disable invert if assist for if-let to fix #3281 | Josh Mcguigan | 2020-03-21 | 1 | -0/+13 | |
| | ||||||
* | Address nits and suggestions. | Steffen Lyngbaek | 2020-03-19 | 1 | -140/+32 | |
| | | | | | Simplify the logic a lot by removing the check for a placeholder pat. This means the auto-fill no longer returns a compile-able value. | |||||
* | Don't show assist if all arms are present | Steffen Lyngbaek | 2020-03-19 | 1 | -33/+37 | |
| | ||||||
* | 'Fill match arms' should work with existing match arms | Steffen Lyngbaek | 2020-03-19 | 1 | -25/+281 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses #3039 This essentially adds missing match arms. The algorithm for this can get complicated rather quickly so bail in certain conditions and rely on a PlaceholderPat. The algorighm works as such: - Iterate through the Enum Def Variants - Attempt to see if the variant already exists as a match arm - If yes, skip the enum variant. If no, include it. - If it becomes complicated, rather than exhaustively deal with every branch, mark it as a "partial match" and simply include the placeholder. Conditions for "complication": - The match arm contains a match guard - Any kind of nested destrucuring Order the resulting merged match branches as such: 1. Provided match arms 2. Missing enum variant branch arms 3. End with Placeholder if required - Add extra tests | |||||
* | Cleanup imports | Aleksey Kladov | 2020-03-19 | 6 | -13/+17 | |
| | ||||||
* | Merge nested use trees | Aleksey Kladov | 2020-03-19 | 1 | -20/+52 | |
| | ||||||
* | Generalize | Aleksey Kladov | 2020-03-19 | 2 | -13/+10 | |
| | ||||||
* | Use match_ast | Aleksey Kladov | 2020-03-18 | 1 | -10/+13 | |
| | ||||||
* | Merge imports assist | Aleksey Kladov | 2020-03-18 | 5 | -25/+178 | |
| | | | | Work towards #2220 | |||||
* | Reduce visibility | Aleksey Kladov | 2020-03-18 | 1 | -28/+28 | |
| | ||||||
* | Simplify | Aleksey Kladov | 2020-03-13 | 2 | -8/+5 | |
| | ||||||
* | Don't use generic DB where a concrete one will do | Aleksey Kladov | 2020-03-13 | 1 | -6/+2 | |
| | ||||||
* | Remove some TextUnit->usize escapees | CAD97 | 2020-03-13 | 1 | -1/+1 | |
| | ||||||
* | Rerail split_import API onto AST | Aleksey Kladov | 2020-03-06 | 1 | -19/+33 | |
| | | | | | The code is more verbose and less efficient now, but should be reusable in add_import context as well | |||||
* | Unfold groups with single assists into plain assists | Kirill Bulatov | 2020-03-05 | 2 | -8/+6 | |
| | ||||||
* | Remove old find refs infra | Aleksey Kladov | 2020-03-04 | 2 | -13/+21 | |
| | ||||||
* | Highlight assist tests | Aleksey Kladov | 2020-03-03 | 2 | -48/+52 | |
| | ||||||
* | Fix applicability of inline local | Aleksey Kladov | 2020-03-03 | 3 | -10/+34 | |
| | ||||||
* | One more assert | Aleksey Kladov | 2020-03-02 | 1 | -1/+6 | |
| | ||||||
* | Rename ast::ImplBlock -> ast::ImplDef | Aleksey Kladov | 2020-02-29 | 5 | -21/+21 | |
| | ||||||
* | Add a FIXME | Aleksey Kladov | 2020-02-29 | 1 | -0/+2 | |
| | ||||||
* | Fix typo | Aleksey Kladov | 2020-02-29 | 2 | -2/+2 | |
| | ||||||
* | Cleanup editing API | Aleksey Kladov | 2020-02-29 | 1 | -1/+1 | |
| | ||||||
* | More orthogonal API for building paths | Aleksey Kladov | 2020-02-29 | 2 | -11/+18 | |
| | ||||||
* | Simplify | Aleksey Kladov | 2020-02-28 | 3 | -23/+3 | |
| | ||||||
* | Move insert_use util to utils | Aleksey Kladov | 2020-02-28 | 5 | -533/+538 | |
| | ||||||
* | introduce const visibility assist | Douglas Campos | 2020-02-28 | 1 | -4/+9 | |
| | ||||||
* | Refactor string literals | Aleksey Kladov | 2020-02-27 | 1 | -1/+2 | |
| | ||||||
* | Refactor primary IDE API | Aleksey Kladov | 2020-02-26 | 10 | -153/+100 | |
| | | | | | | | | | | This introduces the new type -- Semantics. Semantics maps SyntaxNodes to various semantic info, such as type, name resolution or macro expansions. To do so, Semantics maintains a HashMap which maps every node it saw to the file from which the node originated. This is enough to get all the necessary hir bits just from syntax. | |||||
* | Remove code duplication in tests | Aleksey Kladov | 2020-02-26 | 2 | -101/+73 | |
| | ||||||
* | Replace generic with a concrete type | Aleksey Kladov | 2020-02-25 | 1 | -12/+13 | |
| | ||||||
* | Add `remove_mut` assist | Aleksey Kladov | 2020-02-19 | 3 | -0/+51 | |
| | ||||||
* | Cleanup | Shotaro Yamada | 2020-02-19 | 1 | -1/+1 | |
| | ||||||
* | More manual clippy fixes | Kirill Bulatov | 2020-02-18 | 2 | -5/+5 | |
| | ||||||
* | Run cargo +nightly fix --clippy -Z unstable-options | Kirill Bulatov | 2020-02-18 | 4 | -6/+6 | |
| | ||||||
* | Merge #3108 | bors[bot] | 2020-02-17 | 3 | -36/+88 | |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3108: Magic Completion for `impl Trait for` Associated Items r=matklad a=kdelorey # Summary This PR adds a set of magic completions to auto complete associated trait items (functions/consts/types). ![Associated Trait Impl](https://user-images.githubusercontent.com/2295721/74493144-d8f1af00-4e96-11ea-93a4-82725bf89646.gif) ## Notes Since the assist and completion share the same logic when figuring out the associated items that are missing, a shared utility was created in the `ra_assists::utils` module. Resolves #1046 As this is my first PR to the rust-analyzer project, I'm new to the codebase, feedback welcomed! Co-authored-by: Kevin DeLorey <[email protected]> | |||||
| * | Fixing minor suggestions and added module level documentation. | Kevin DeLorey | 2020-02-11 | 1 | -2/+1 | |
| | | ||||||
| * | Removed doc comments entirely from the changes. | Kevin DeLorey | 2020-02-11 | 1 | -2/+0 | |
| | | ||||||
| * | Formatted changes. | Kevin DeLorey | 2020-02-11 | 2 | -7/+7 | |
| | | ||||||
| * | Fixed warning generated after refactoring. | Kevin DeLorey | 2020-02-11 | 1 | -1/+1 | |
| | | ||||||
| * | Updated the `add_missing_impl_members` to use the shared utility. | Kevin DeLorey | 2020-02-11 | 2 | -34/+15 | |
| | | ||||||
| * | Adjusted the hashset buckets to lump functions/consts together as their ↵ | Kevin DeLorey | 2020-02-11 | 1 | -9/+10 | |
| | | | | | | | | names must be unique. | |||||
| * | Added a utility function that can be used to determine the missing impl items. | Kevin DeLorey | 2020-02-09 | 2 | -3/+76 | |
| | | ||||||
* | | Do not collect all traits | Kirill Bulatov | 2020-02-12 | 1 | -102/+53 | |
| | | ||||||
* | | Support associated consts | Kirill Bulatov | 2020-02-12 | 1 | -18/+133 | |
| | | ||||||
* | | Also consider associated constants | Kirill Bulatov | 2020-02-12 | 1 | -8/+8 | |
| | | ||||||
* | | Fix post-rebase issues | Kirill Bulatov | 2020-02-12 | 1 | -14/+13 | |
| | | ||||||
* | | Refactor the code | Kirill Bulatov | 2020-02-12 | 1 | -96/+93 | |
| | |