| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | Unfold groups with single assists into plain assists | Kirill Bulatov | 2020-03-05 | 2 | -8/+6 | |
| | | ||||||
| * | Remove old find refs infra | Aleksey Kladov | 2020-03-04 | 2 | -13/+21 | |
| | | ||||||
| * | Highlight assist tests | Aleksey Kladov | 2020-03-03 | 2 | -48/+52 | |
| | | ||||||
| * | Fix applicability of inline local | Aleksey Kladov | 2020-03-03 | 3 | -10/+34 | |
| | | ||||||
| * | One more assert | Aleksey Kladov | 2020-03-02 | 1 | -1/+6 | |
| | | ||||||
| * | Rename ast::ImplBlock -> ast::ImplDef | Aleksey Kladov | 2020-02-29 | 5 | -21/+21 | |
| | | ||||||
| * | Add a FIXME | Aleksey Kladov | 2020-02-29 | 1 | -0/+2 | |
| | | ||||||
| * | Fix typo | Aleksey Kladov | 2020-02-29 | 2 | -2/+2 | |
| | | ||||||
| * | Cleanup editing API | Aleksey Kladov | 2020-02-29 | 1 | -1/+1 | |
| | | ||||||
| * | More orthogonal API for building paths | Aleksey Kladov | 2020-02-29 | 2 | -11/+18 | |
| | | ||||||
| * | Simplify | Aleksey Kladov | 2020-02-28 | 3 | -23/+3 | |
| | | ||||||
| * | Move insert_use util to utils | Aleksey Kladov | 2020-02-28 | 5 | -533/+538 | |
| | | ||||||
| * | introduce const visibility assist | Douglas Campos | 2020-02-28 | 1 | -4/+9 | |
| | | ||||||
| * | Refactor string literals | Aleksey Kladov | 2020-02-27 | 1 | -1/+2 | |
| | | ||||||
| * | Refactor primary IDE API | Aleksey Kladov | 2020-02-26 | 10 | -153/+100 | |
| | | | | | | | | | | | This introduces the new type -- Semantics. Semantics maps SyntaxNodes to various semantic info, such as type, name resolution or macro expansions. To do so, Semantics maintains a HashMap which maps every node it saw to the file from which the node originated. This is enough to get all the necessary hir bits just from syntax. | |||||
| * | Remove code duplication in tests | Aleksey Kladov | 2020-02-26 | 2 | -101/+73 | |
| | | ||||||
| * | Replace generic with a concrete type | Aleksey Kladov | 2020-02-25 | 1 | -12/+13 | |
| | | ||||||
| * | Add `remove_mut` assist | Aleksey Kladov | 2020-02-19 | 3 | -0/+51 | |
| | | ||||||
| * | Cleanup | Shotaro Yamada | 2020-02-19 | 1 | -1/+1 | |
| | | ||||||
| * | More manual clippy fixes | Kirill Bulatov | 2020-02-18 | 2 | -5/+5 | |
| | | ||||||
| * | Run cargo +nightly fix --clippy -Z unstable-options | Kirill Bulatov | 2020-02-18 | 4 | -6/+6 | |
| | | ||||||
| * | Merge #3108 | bors[bot] | 2020-02-17 | 3 | -36/+88 | |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3108: Magic Completion for `impl Trait for` Associated Items r=matklad a=kdelorey # Summary This PR adds a set of magic completions to auto complete associated trait items (functions/consts/types).  ## Notes Since the assist and completion share the same logic when figuring out the associated items that are missing, a shared utility was created in the `ra_assists::utils` module. Resolves #1046 As this is my first PR to the rust-analyzer project, I'm new to the codebase, feedback welcomed! Co-authored-by: Kevin DeLorey <[email protected]> | |||||
| | * | Fixing minor suggestions and added module level documentation. | Kevin DeLorey | 2020-02-11 | 1 | -2/+1 | |
| | | | ||||||
| | * | Removed doc comments entirely from the changes. | Kevin DeLorey | 2020-02-11 | 1 | -2/+0 | |
| | | | ||||||
| | * | Formatted changes. | Kevin DeLorey | 2020-02-11 | 2 | -7/+7 | |
| | | | ||||||
| | * | Fixed warning generated after refactoring. | Kevin DeLorey | 2020-02-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | Updated the `add_missing_impl_members` to use the shared utility. | Kevin DeLorey | 2020-02-11 | 2 | -34/+15 | |
| | | | ||||||
| | * | Adjusted the hashset buckets to lump functions/consts together as their ↵ | Kevin DeLorey | 2020-02-11 | 1 | -9/+10 | |
| | | | | | | | | | names must be unique. | |||||
| | * | Added a utility function that can be used to determine the missing impl items. | Kevin DeLorey | 2020-02-09 | 2 | -3/+76 | |
| | | | ||||||
| * | | Do not collect all traits | Kirill Bulatov | 2020-02-12 | 1 | -102/+53 | |
| | | | ||||||
| * | | Support associated consts | Kirill Bulatov | 2020-02-12 | 1 | -18/+133 | |
| | | | ||||||
| * | | Also consider associated constants | Kirill Bulatov | 2020-02-12 | 1 | -8/+8 | |
| | | | ||||||
| * | | Fix post-rebase issues | Kirill Bulatov | 2020-02-12 | 1 | -14/+13 | |
| | | | ||||||
| * | | Refactor the code | Kirill Bulatov | 2020-02-12 | 1 | -96/+93 | |
| | | | ||||||
| * | | Adjust the assist group name | Kirill Bulatov | 2020-02-12 | 1 | -9/+25 | |
| | | | ||||||
| * | | Add profiling | Kirill Bulatov | 2020-02-12 | 1 | -0/+3 | |
| | | | ||||||
| * | | Support trait method call autoimports | Kirill Bulatov | 2020-02-12 | 1 | -100/+206 | |
| | | | ||||||
| * | | Trait location draft | Kirill Bulatov | 2020-02-12 | 1 | -9/+120 | |
| | | | ||||||
| * | | Refactor path for imports extraction | Kirill Bulatov | 2020-02-12 | 1 | -20/+92 | |
| | | | ||||||
| * | | Add method tests | Kirill Bulatov | 2020-02-12 | 1 | -3/+116 | |
| | | | ||||||
| * | | Resolve methods and functions better | Kirill Bulatov | 2020-02-12 | 1 | -3/+20 | |
| | | | ||||||
| * | | Introduce AttrKind | Kirill Bulatov | 2020-02-12 | 1 | -2/+1 | |
| | | | ||||||
| * | | Do not add imports before inner attributes | Kirill Bulatov | 2020-02-12 | 1 | -1/+29 | |
| | | | ||||||
| * | | Add or- and parenthesized-patterns | Matthew Jasper | 2020-02-09 | 3 | -10/+10 | |
| |/ | ||||||
| * | Fix rebase leftovers | Kirill Bulatov | 2020-02-09 | 1 | -2/+2 | |
| | | ||||||
| * | Do not import anything if first segment of FQN resolves | Kirill Bulatov | 2020-02-09 | 1 | -12/+36 | |
| | | ||||||
| * | Set auto-import target | Aleksey Kladov | 2020-02-09 | 1 | -1/+17 | |
| | | | | | closes #3067 | |||||
| * | Simplify Assists interface | Aleksey Kladov | 2020-02-09 | 3 | -95/+54 | |
| | | | | | | Instead of building a physical tree structure, just "tag" related assists with the same group | |||||
| * | Slightly simpler API for groups | Aleksey Kladov | 2020-02-09 | 2 | -48/+77 | |
| | | ||||||
| * | Merge #3050 | bors[bot] | 2020-02-09 | 1 | -4/+10 | |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3050: Refactor type parameters, implement argument position impl trait r=matklad a=flodiebold I wanted to implement APIT by lowering to type parameters because we need to do that anyway for correctness and don't need Chalk support for it; this grew into some more wide-ranging refactoring of how type parameters are handled :sweat_smile: - use Ty::Bound instead of Ty::Param to represent polymorphism, and explicitly count binders. This gets us closer to Chalk's way of doing things, and means that we now only use Param as a placeholder for an unknown type, e.g. within a generic function. I.e. we're never using Param in a situation where we want to substitute it, and the method to do that is gone; `subst` now always works on bound variables. (This changes how the types of generic functions print; previously, you'd get something like `fn identity<i32>(T) -> T`, but now we display the substituted signature `fn identity<i32>(i32) -> i32`, which I think makes more sense.) - once we do this, it's more natural to represent `Param` by a globally unique ID; the use of indices was mostly to make substituting easier. This also means we fix the bug where `Param` loses its name when going through Chalk. - I would actually like to rename `Param` to `Placeholder` to better reflect its use and get closer to Chalk, but I'll leave that to a follow-up. - introduce a context for type lowering, to allow lowering `impl Trait` to different things depending on where we are. And since we have that, we can also lower type parameters directly to variables instead of placeholders. Also, we'll be able to use this later to collect diagnostics. - implement argument position impl trait by lowering it to type parameters. I've realized that this is necessary to correctly implement it; e.g. consider `fn foo(impl Display) -> impl Something`. It's observable that the return type of e.g. `foo(1u32)` unifies with itself, but doesn't unify with e.g. `foo(1i32)`; so the return type needs to be parameterized by the argument type. This fixes a few bugs as well: - type parameters 'losing' their name when they go through Chalk, as mentioned above (i.e. getting `[missing name]` somewhere) - impl trait not being considered as implementing the super traits (very noticeable for the `db` in RA) - the fact that argument impl trait was only turned into variables when the function got called caused type mismatches when the function was used as a value (fixes a few type mismatches in RA) The one thing I'm not so happy with here is how we're lowering `impl Trait` types to variables; since `TypeRef`s don't have an identity currently, we just count how many of them we have seen while going through the function signature. That's quite fragile though, since we have to do it while desugaring generics and while lowering the type signature, and in the exact same order in both cases. We could consider either giving only `TypeRef::ImplTrait` a local id, or maybe just giving all `TypeRef`s an identity after all (we talked about this before)... Follow-up tasks: - handle return position impl trait; we basically need to create a variable and some trait obligations for that variable - rename `Param` to `Placeholder` Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Florian Diebold <[email protected]> | |||||
 |
index : rust-analyzer | |
| [FORK] modified to work on wasm targets |
| aboutsummaryrefslogtreecommitdiff |