aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_assists
Commit message (Collapse)AuthorAgeFilesLines
* Merge #3705bors[bot]2020-03-241-1/+1
|\ | | | | | | | | | | | | | | | | | | | | 3705: Align naming r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Align namingAleksey Kladov2020-03-241-1/+1
| |
* | Merge #3700bors[bot]2020-03-242-47/+47
|\ \ | |/ |/| | | | | | | | | | | | | | | 3700: fill match arms with empty block rather than unit tuple r=matklad a=JoshMcguigan As requested by @Veetaha in #3689 and #3687, this modifies the fill match arms assist to create match arms as an empty block `{}` rather than a unit tuple `()`. In one test I left one of the pre-existing match arms as a unit tuple, and added a body to another match arm, to demonstrate that the contents of existing match arms persist. Co-authored-by: Josh Mcguigan <[email protected]>
| * fill match arms with empty block rather than unit tupleJosh Mcguigan2020-03-242-47/+47
| |
* | Add a testKirill Bulatov2020-03-242-9/+45
| |
* | Use more generic public apiKirill Bulatov2020-03-244-24/+26
| |
* | Auto import macrosKirill Bulatov2020-03-243-16/+25
|/
* update itertools version to 0.9.0Josh Mcguigan2020-03-231-1/+1
|
* review commentsJosh Mcguigan2020-03-231-16/+108
|
* implement fill match arm assist for tuple of enumsJosh Mcguigan2020-03-232-14/+150
|
* disable invert if assist for if-let to fix #3281Josh Mcguigan2020-03-211-0/+13
|
* Address nits and suggestions.Steffen Lyngbaek2020-03-191-140/+32
| | | | | Simplify the logic a lot by removing the check for a placeholder pat. This means the auto-fill no longer returns a compile-able value.
* Don't show assist if all arms are presentSteffen Lyngbaek2020-03-191-33/+37
|
* 'Fill match arms' should work with existing match armsSteffen Lyngbaek2020-03-191-25/+281
| | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses #3039 This essentially adds missing match arms. The algorithm for this can get complicated rather quickly so bail in certain conditions and rely on a PlaceholderPat. The algorighm works as such: - Iterate through the Enum Def Variants - Attempt to see if the variant already exists as a match arm - If yes, skip the enum variant. If no, include it. - If it becomes complicated, rather than exhaustively deal with every branch, mark it as a "partial match" and simply include the placeholder. Conditions for "complication": - The match arm contains a match guard - Any kind of nested destrucuring Order the resulting merged match branches as such: 1. Provided match arms 2. Missing enum variant branch arms 3. End with Placeholder if required - Add extra tests
* Cleanup importsAleksey Kladov2020-03-196-13/+17
|
* Merge nested use treesAleksey Kladov2020-03-191-20/+52
|
* GeneralizeAleksey Kladov2020-03-192-13/+10
|
* Use match_astAleksey Kladov2020-03-181-10/+13
|
* Merge imports assistAleksey Kladov2020-03-185-25/+178
| | | | Work towards #2220
* Reduce visibilityAleksey Kladov2020-03-181-28/+28
|
* SimplifyAleksey Kladov2020-03-132-8/+5
|
* Don't use generic DB where a concrete one will doAleksey Kladov2020-03-131-6/+2
|
* Remove some TextUnit->usize escapeesCAD972020-03-131-1/+1
|
* Rerail split_import API onto ASTAleksey Kladov2020-03-061-19/+33
| | | | | The code is more verbose and less efficient now, but should be reusable in add_import context as well
* Unfold groups with single assists into plain assistsKirill Bulatov2020-03-052-8/+6
|
* Remove old find refs infraAleksey Kladov2020-03-042-13/+21
|
* Highlight assist testsAleksey Kladov2020-03-032-48/+52
|
* Fix applicability of inline localAleksey Kladov2020-03-033-10/+34
|
* One more assertAleksey Kladov2020-03-021-1/+6
|
* Rename ast::ImplBlock -> ast::ImplDefAleksey Kladov2020-02-295-21/+21
|
* Add a FIXMEAleksey Kladov2020-02-291-0/+2
|
* Fix typoAleksey Kladov2020-02-292-2/+2
|
* Cleanup editing APIAleksey Kladov2020-02-291-1/+1
|
* More orthogonal API for building pathsAleksey Kladov2020-02-292-11/+18
|
* SimplifyAleksey Kladov2020-02-283-23/+3
|
* Move insert_use util to utilsAleksey Kladov2020-02-285-533/+538
|
* introduce const visibility assistDouglas Campos2020-02-281-4/+9
|
* Refactor string literalsAleksey Kladov2020-02-271-1/+2
|
* Remove unused dependenciesShotaro Yamada2020-02-271-1/+0
|
* Refactor primary IDE APIAleksey Kladov2020-02-2610-153/+100
| | | | | | | | | | This introduces the new type -- Semantics. Semantics maps SyntaxNodes to various semantic info, such as type, name resolution or macro expansions. To do so, Semantics maintains a HashMap which maps every node it saw to the file from which the node originated. This is enough to get all the necessary hir bits just from syntax.
* Remove code duplication in testsAleksey Kladov2020-02-262-101/+73
|
* Replace generic with a concrete typeAleksey Kladov2020-02-251-12/+13
|
* Add `remove_mut` assistAleksey Kladov2020-02-193-0/+51
|
* CleanupShotaro Yamada2020-02-191-1/+1
|
* Update versionsKirill Bulatov2020-02-181-2/+2
|
* More manual clippy fixesKirill Bulatov2020-02-182-5/+5
|
* Run cargo +nightly fix --clippy -Z unstable-optionsKirill Bulatov2020-02-184-6/+6
|
* Merge #3108bors[bot]2020-02-173-36/+88
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3108: Magic Completion for `impl Trait for` Associated Items r=matklad a=kdelorey # Summary This PR adds a set of magic completions to auto complete associated trait items (functions/consts/types). ![Associated Trait Impl](https://user-images.githubusercontent.com/2295721/74493144-d8f1af00-4e96-11ea-93a4-82725bf89646.gif) ## Notes Since the assist and completion share the same logic when figuring out the associated items that are missing, a shared utility was created in the `ra_assists::utils` module. Resolves #1046 As this is my first PR to the rust-analyzer project, I'm new to the codebase, feedback welcomed! Co-authored-by: Kevin DeLorey <[email protected]>
| * Fixing minor suggestions and added module level documentation.Kevin DeLorey2020-02-111-2/+1
| |
| * Removed doc comments entirely from the changes.Kevin DeLorey2020-02-111-2/+0
| |