Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Simplify Assists interface | Aleksey Kladov | 2020-02-09 | 3 | -95/+54 |
| | | | | | Instead of building a physical tree structure, just "tag" related assists with the same group | ||||
* | Slightly simpler API for groups | Aleksey Kladov | 2020-02-09 | 2 | -48/+77 |
| | |||||
* | Merge #3050 | bors[bot] | 2020-02-09 | 1 | -4/+10 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3050: Refactor type parameters, implement argument position impl trait r=matklad a=flodiebold I wanted to implement APIT by lowering to type parameters because we need to do that anyway for correctness and don't need Chalk support for it; this grew into some more wide-ranging refactoring of how type parameters are handled :sweat_smile: - use Ty::Bound instead of Ty::Param to represent polymorphism, and explicitly count binders. This gets us closer to Chalk's way of doing things, and means that we now only use Param as a placeholder for an unknown type, e.g. within a generic function. I.e. we're never using Param in a situation where we want to substitute it, and the method to do that is gone; `subst` now always works on bound variables. (This changes how the types of generic functions print; previously, you'd get something like `fn identity<i32>(T) -> T`, but now we display the substituted signature `fn identity<i32>(i32) -> i32`, which I think makes more sense.) - once we do this, it's more natural to represent `Param` by a globally unique ID; the use of indices was mostly to make substituting easier. This also means we fix the bug where `Param` loses its name when going through Chalk. - I would actually like to rename `Param` to `Placeholder` to better reflect its use and get closer to Chalk, but I'll leave that to a follow-up. - introduce a context for type lowering, to allow lowering `impl Trait` to different things depending on where we are. And since we have that, we can also lower type parameters directly to variables instead of placeholders. Also, we'll be able to use this later to collect diagnostics. - implement argument position impl trait by lowering it to type parameters. I've realized that this is necessary to correctly implement it; e.g. consider `fn foo(impl Display) -> impl Something`. It's observable that the return type of e.g. `foo(1u32)` unifies with itself, but doesn't unify with e.g. `foo(1i32)`; so the return type needs to be parameterized by the argument type. This fixes a few bugs as well: - type parameters 'losing' their name when they go through Chalk, as mentioned above (i.e. getting `[missing name]` somewhere) - impl trait not being considered as implementing the super traits (very noticeable for the `db` in RA) - the fact that argument impl trait was only turned into variables when the function got called caused type mismatches when the function was used as a value (fixes a few type mismatches in RA) The one thing I'm not so happy with here is how we're lowering `impl Trait` types to variables; since `TypeRef`s don't have an identity currently, we just count how many of them we have seen while going through the function signature. That's quite fragile though, since we have to do it while desugaring generics and while lowering the type signature, and in the exact same order in both cases. We could consider either giving only `TypeRef::ImplTrait` a local id, or maybe just giving all `TypeRef`s an identity after all (we talked about this before)... Follow-up tasks: - handle return position impl trait; we basically need to create a variable and some trait obligations for that variable - rename `Param` to `Placeholder` Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | Fix add_new assist (kind of) | Florian Diebold | 2020-02-07 | 1 | -5/+10 |
| | | |||||
| * | Clean up RPIT a bit | Florian Diebold | 2020-02-07 | 1 | -0/+1 |
| | | |||||
* | | Rename add import assist | Kirill Bulatov | 2020-02-07 | 4 | -79/+77 |
|/ | |||||
* | Introduce assists utils | Aleksey Kladov | 2020-02-07 | 5 | -26/+32 |
| | |||||
* | Name assist handlers | Aleksey Kladov | 2020-02-07 | 27 | -33/+17 |
| | |||||
* | Cleanups | Aleksey Kladov | 2020-02-07 | 1 | -2/+5 |
| | |||||
* | Cleanup imports | Aleksey Kladov | 2020-02-07 | 1 | -1/+1 |
| | |||||
* | Cleanup | Aleksey Kladov | 2020-02-07 | 2 | -4/+11 |
| | |||||
* | Cleanup | Aleksey Kladov | 2020-02-07 | 1 | -3/+4 |
| | |||||
* | Simplify | Aleksey Kladov | 2020-02-07 | 2 | -42/+29 |
| | |||||
* | Cleanup early return assist | Aleksey Kladov | 2020-02-07 | 1 | -3/+8 |
| | |||||
* | Generalize invert_if to just always work | Aleksey Kladov | 2020-02-07 | 2 | -17/+30 |
| | |||||
* | A tiny bit more consistent API | Aleksey Kladov | 2020-02-06 | 1 | -1/+1 |
| | |||||
* | Minor rename | Aleksey Kladov | 2020-02-06 | 2 | -7/+9 |
| | |||||
* | Remove the leftovers after ImportLocator removal | Kirill Bulatov | 2020-02-06 | 1 | -2/+2 |
| | |||||
* | Doctest autoimport | Aleksey Kladov | 2020-02-06 | 3 | -10/+8 |
| | |||||
* | Fix tests | Aleksey Kladov | 2020-02-06 | 1 | -12/+23 |
| | |||||
* | Mostly remove ImoportLocator infra | Aleksey Kladov | 2020-02-06 | 2 | -177/+20 |
| | |||||
* | Assists are not generic | Aleksey Kladov | 2020-02-06 | 27 | -84/+59 |
| | |||||
* | Remove assists TestDB | Aleksey Kladov | 2020-02-06 | 2 | -47/+0 |
| | |||||
* | Start switching assists to a root database | Aleksey Kladov | 2020-02-06 | 3 | -39/+42 |
| | |||||
* | Make assists use ImportsLocator directly | Aleksey Kladov | 2020-02-06 | 2 | -9/+10 |
| | |||||
* | Add profiling around add_impl_members | Aleksey Kladov | 2020-02-06 | 2 | -0/+2 |
| | | | | | | | | | This intention is pretty slow for `impl Interator`, because it has a ton of default methods which need to be substituted. The proper fix here is to not compute the actual edit until the user triggers the action, but that's awkward to do in the LSP right now, so let's just put a profiling code for now. | ||||
* | Refactor if-let -> match assist to use ast::make | Aleksey Kladov | 2020-02-05 | 1 | -27/+22 |
| | |||||
* | Better cursor placement when merging arms | Aleksey Kladov | 2020-02-05 | 1 | -4/+17 |
| | |||||
* | Merge match arms works with many arms | Aleksey Kladov | 2020-02-05 | 1 | -29/+70 |
| | |||||
* | Cleanup | Aleksey Kladov | 2020-02-05 | 1 | -11/+12 |
| | |||||
* | Merge #2948 | bors[bot] | 2020-02-04 | 1 | -6/+48 |
|\ | | | | | | | | | | | | | | | 2948: Allow add_explicit_type to replace a placeholder type r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]> | ||||
| * | Allow add_explicit_type to replace a placeholder type | Laurențiu Nicola | 2020-02-03 | 1 | -6/+48 |
| | | |||||
* | | Use proper import name in the label | Kirill Bulatov | 2020-02-03 | 1 | -10/+6 |
| | | |||||
* | | Simplify paths searches | Kirill Bulatov | 2020-02-03 | 1 | -4/+3 |
| | | |||||
* | | Use name only when searching for an import candidate | Kirill Bulatov | 2020-02-02 | 1 | -6/+16 |
|/ | |||||
* | Merge #2982 | bors[bot] | 2020-02-02 | 2 | -15/+36 |
|\ | | | | | | | | | | | | | | | 2982: Merge imports when auto importing r=flodiebold a=SomeoneToIgnore Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | Remove obsolete rustdoc | Kirill Bulatov | 2020-02-02 | 1 | -1/+0 |
| | | |||||
| * | Require ModPath for importing | Kirill Bulatov | 2020-02-02 | 2 | -10/+8 |
| | | |||||
| * | Merge imports when auto importing | Kirill Bulatov | 2020-02-02 | 1 | -6/+30 |
| | | |||||
* | | Auto import functions | Kirill Bulatov | 2020-02-01 | 1 | -0/+24 |
|/ | |||||
* | Improve auto import message | Laurențiu Nicola | 2020-01-31 | 1 | -6/+10 |
| | |||||
* | Properly select a target for auto importing | Kirill Bulatov | 2020-01-29 | 1 | -29/+17 |
| | |||||
* | Code review fixes | Kirill Bulatov | 2020-01-27 | 2 | -7/+8 |
| | |||||
* | Enforce alphabetical import sorting | Kirill Bulatov | 2020-01-26 | 1 | -2/+3 |
| | |||||
* | Adjust the tests | Kirill Bulatov | 2020-01-26 | 2 | -61/+149 |
| | |||||
* | Have a better trait interface | Kirill Bulatov | 2020-01-26 | 2 | -17/+19 |
| | |||||
* | Remove unnecessary lifetime parameter | Kirill Bulatov | 2020-01-26 | 2 | -8/+8 |
| | |||||
* | Initial auto import action implementation | Kirill Bulatov | 2020-01-26 | 5 | -15/+317 |
| | |||||
* | fixed inline_local_variable bug | Tomáš | 2020-01-25 | 1 | -0/+15 |
| | |||||
* | added eq_token() method to LetStmt | TomasKralCZ | 2020-01-19 | 1 | -2/+1 |
| |