aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_assists
Commit message (Collapse)AuthorAgeFilesLines
*-. Merge #4521 #4522bors[bot]2020-05-206-70/+113
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4521: Use snippets in add_function r=matklad a=matklad bors r+ 🤖 4522: Explain the purpose of `ast::make` module more clearly r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Explain the purpose of `ast::make` module more clearlyAleksey Kladov2020-05-201-1/+1
| |/ |/|
| * Moderate cleanup of add_functionAleksey Kladov2020-05-202-34/+54
| |
| * Use snippets in add functionAleksey Kladov2020-05-203-39/+66
| |
| * CleanupAleksey Kladov2020-05-201-5/+2
| |
| * CleanupAleksey Kladov2020-05-201-3/+2
|/
* New assist: add turbo fishAleksey Kladov2020-05-194-0/+157
|
* Server side of SnippetTextEditAleksey Kladov2020-05-191-10/+0
|
* Add snippet support for some assistsAleksey Kladov2020-05-194-56/+67
|
* Add AssistConfigAleksey Kladov2020-05-194-28/+103
|
* Merge #4273bors[bot]2020-05-141-1/+515
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4273: Trigger add_vis assist on paths/record fields as well r=flodiebold a=TimoFreiberg Resolves #4037. - [x] Function defs - [x] ADT defs - [x] Enum variants - [x] Consts - [x] Statics - [x] Traits - [x] Type aliases - [x] Modules - [x] Record fields (using different implementation) - [x] struct fields - [x] enum variant fields - :x: union fields (`Semantics::resolve_record_field` seems to not work for union fields, so I think this can be handled in a future PR) - [x] More tests? - [x] Improve test fixture code and documentation a bit (see [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/resolve_path.20between.20fixture.20files)) Co-authored-by: Timo Freiberg <[email protected]>
| * Trigger change_visibility assist when on an invisible struct fieldTimo Freiberg2020-05-101-61/+248
| | | | | | | | Union fields apparently don't work :(
| * Trigger change_visibility assist when on a path to an invisible defTimo Freiberg2020-05-101-1/+328
| |
* | Merge #4445bors[bot]2020-05-142-2/+72
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 4445: Correctly fill default type parameters r=flodiebold a=montekki Fixes #3877 So, basically even if the parameters are omitted from the `impl` block, check the parameters in `trait` if they have a default type, and if they do go from `hir` to `ast::TypeArg`. I've added a helper for that but I am not sure that it's a proper way to go from `hir` to `ast` here. Co-authored-by: Fedor Sakharov <[email protected]>
| * | Fix formattingFedor Sakharov2020-05-141-1/+1
| | |
| * | Change type_arg to type_ref funcFedor Sakharov2020-05-141-2/+1
| | |
| * | Use generic_defaults and display_source_codeFedor Sakharov2020-05-142-10/+12
| | |
| * | Correctly fill default type parametersFedor Sakharov2020-05-133-1/+70
| | |
* | | Use back ticks instead of single quotes around codeTrevor Spiteri2020-05-142-2/+2
|/ /
* | Merge #4358bors[bot]2020-05-111-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4358: add if let and while let postfix for Option and Result #4348 r=matklad a=bnjjj close #4348 I also added `while let` for iterator or stream it could be useful ![iflet](https://user-images.githubusercontent.com/5719034/81278000-676c6b80-9055-11ea-87ad-6b8476dd983f.gif) Co-authored-by: Benjamin Coenen <[email protected]>
| * | add if let and while let postfix for Option and ResultBenjamin Coenen2020-05-101-2/+2
| |/ | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| |
| \
| \
| \
*---. \ Merge #4406 #4410 #4411 #4417bors[bot]2020-05-102-29/+194
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4406: Update cargo-metadata r=matklad a=edwin0cheng This PR update `cargo-metadata` to 0.10.0 and it also relax the` serde-derive` deps to 1.0 for tests in `proc-macro-srv`. cc @robojumper r= @matklad , I think you would have something to say related to https://github.com/serde-rs/json/issues/647#issue-593788429 ? 4410: Improve wording in comment r=matklad a=edwin0cheng 4411: do not remove then block when you unwrap else block #4361 r=matklad a=bnjjj close #4361 4417: Omit default types in HirDisplay SourceCode mode r=matklad a=TimoFreiberg Closes #4390 Co-authored-by: Edwin Cheng <[email protected]> Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Timo Freiberg <[email protected]>
| | | * Omit default types in HirDisplay SourceCode modeTimo Freiberg2020-05-101-1/+1
| |_|/ |/| |
| | * do not remove then block when you unwrap else block #4361Benjamin Coenen2020-05-101-28/+193
| |/ |/| | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Merge #4392bors[bot]2020-05-091-14/+11
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4392: Add From should not move the cursor r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add From should not move the cursorAleksey Kladov2020-05-091-14/+11
| | |
* | | Ascribe more correct typesAleksey Kladov2020-05-091-9/+10
|/ /
* | unindent -> dedentAleksey Kladov2020-05-091-1/+1
| |
* | More fluent indent APIAleksey Kladov2020-05-096-21/+32
| |
* | Fix visibilityAleksey Kladov2020-05-091-1/+1
| |
* | Use new HirDisplay variant in add_function assistTimo Freiberg2020-05-081-58/+116
|/
* SimplifyAleksey Kladov2020-05-075-6/+5
|
* Nicer APIAleksey Kladov2020-05-072-41/+41
|
* Rename AssitLabel -> AssistAleksey Kladov2020-05-073-21/+21
|
* Refactor assists API to be more convenient for adding new assistsAleksey Kladov2020-05-0738-593/+521
| | | | It now duplicates completion API in its shape.
* add Ok wrappingBenjamin Coenen2020-05-063-0/+986
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* SimplifyAleksey Kladov2020-05-063-33/+17
|
* RenameAleksey Kladov2020-05-063-12/+12
|
* Use SourceChange for assistsAleksey Kladov2020-05-063-35/+33
|
* Fix TODOAleksey Kladov2020-05-062-19/+13
|
* Move target to AssistLabelAleksey Kladov2020-05-0636-256/+292
| | | | | Target is used for assists sorting, so we need it before we compute the action.
* RegenerateAleksey Kladov2020-05-062-38/+40
|
* Merge doc_tests and testsAleksey Kladov2020-05-064-41/+28
|
* Merge assits::test_helpers and testsAleksey Kladov2020-05-0635-180/+172
|
* Fixup testsAleksey Kladov2020-05-052-13/+13
|
* Rename AtomTextEdit -> IndelAleksey Kladov2020-05-051-3/+1
|
* Minor cleanupsAleksey Kladov2020-05-052-6/+9
|
* Fix compilationAleksey Kladov2020-05-051-1/+1
|
* Move group_label where it belongsAleksey Kladov2020-05-052-7/+6
|
* use GroupLabel for type safetyAleksey Kladov2020-05-051-3/+4
|