Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #2924 | bors[bot] | 2020-01-28 | 1 | -2/+4 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | 2924: Modify ordering of drops in check watcher to only ever have one cargo r=matklad a=kiljacken Due to the way drops are ordered when assigning to a mutable variable we were launching a new cargo sub-process before letting the old one quite. By explicitly replacing the original watcher with a dummy first, we ensure it is dropped and the process is completed, before we start the new process. Co-authored-by: Emil Lauridsen <[email protected]> | ||||
| * | Modify ordering of drops in check watcher to only ever have one cargo | Emil Lauridsen | 2020-01-28 | 1 | -2/+4 |
| | | | | | | | | | | | | | | | | | | Due to the way drops are ordered when assigning to a mutable variable we were launching a new cargo sub-process before letting the old one quite. By explicitly replacing the original watcher with a dummy first, we ensure it is dropped and the process is completed, before we start the new process. | ||||
* | | Don't do check progress update for fresh crates | Emil Lauridsen | 2020-01-28 | 1 | -0/+8 |
|/ | |||||
* | Buffer reads from cargo check's stdout | Laurențiu Nicola | 2020-01-27 | 1 | -1/+4 |
| | |||||
* | Move snaps to new naming scheme | Jeremy Kolb | 2020-01-26 | 7 | -0/+0 |
| | |||||
* | Remove RWLock from check watcher. | Emil Lauridsen | 2020-01-23 | 2 | -6/+5 |
| | | | | | | | | | | | | | | @matklad mentioned this might be a good idea. So the general idea is that we don't really need the lock, as we can just clone the check watcher state when creating a snapshot. We can then use `Arc::get_mut` to get mutable access to the state from `WorldState` when needed. Running with this it seems to improve responsiveness a bit while cargo is running, but I have no hard numbers to prove it. In any case, a serialization point less is always better when we're trying to be responsive. | ||||
* | Tweak naming slightly | Emil Lauridsen | 2020-01-15 | 1 | -5/+5 |
| | |||||
* | Manage check state updates in main_loop to reduce lock contention | Emil Lauridsen | 2020-01-15 | 1 | -39/+35 |
| | |||||
* | Defer cargo check until after workspace load | Emil Lauridsen | 2020-01-13 | 1 | -2/+11 |
| | |||||
* | Disable cargo checking in workspaces with no cargo projects | Emil Lauridsen | 2020-01-11 | 1 | -0/+6 |
| | |||||
* | Fix unused import for windows in cargo_watch test | Edwin Cheng | 2020-01-03 | 1 | -0/+2 |
| | |||||
* | Disable cargo_watch snapshot tests on windows | Emil Lauridsen | 2020-01-01 | 1 | -0/+7 |
| | |||||
* | Merge #2681 | bors[bot] | 2019-12-29 | 3 | -2/+307 |
|\ | | | | | | | | | | | | | | | 2681: cargo-watcher: Resolve macro call site in more cases r=matklad a=kiljacken This resolves the actual macro call site in a few more cases, f.x. when a macro invokes `compile_error!` (I'm looking at you `ra_hir_def::path::__path`). Co-authored-by: Emil Lauridsen <[email protected]> | ||||
| * | Add related information with original error site | Emil Lauridsen | 2019-12-29 | 3 | -1/+306 |
| | | |||||
| * | Resolve macro call site in more cases | Emil Lauridsen | 2019-12-29 | 1 | -1/+1 |
| | | |||||
* | | Lowercase drive letters when getting paths from cargo check | Emil Lauridsen | 2019-12-29 | 2 | -2/+68 |
|/ | |||||
* | Reduce visibility | Aleksey Kladov | 2019-12-29 | 1 | -3/+3 |
| | |||||
* | Fix busy-waiting issue in main cargo watch thread | Emil Lauridsen | 2019-12-27 | 1 | -3/+5 |
| | |||||
* | Don't finish main cargo watch thread when subprocess finishes. | Emil Lauridsen | 2019-12-27 | 1 | -2/+1 |
| | |||||
* | Fix shutdown behavoir of main cargo-watch thread. | Emil Lauridsen | 2019-12-27 | 1 | -7/+8 |
| | | | | | Even though this didn't error, it became clear to me that it was closing the wrong channel, resulting in the child thread never finishing. | ||||
* | Add doc comment to module | Emil Lauridsen | 2019-12-27 | 1 | -0/+2 |
| | |||||
* | Cargo fmt run | Emil Lauridsen | 2019-12-27 | 1 | -7/+1 |
| | |||||
* | Shutdown/cancelation story for main cargo watch thread | Emil Lauridsen | 2019-12-27 | 1 | -15/+32 |
| | |||||
* | Consistent, hopefully robust, shutdown/cancelation story for cargo check ↵ | Emil Lauridsen | 2019-12-27 | 1 | -16/+50 |
| | | | | subprocess | ||||
* | Move cargo watch functionality to separate crate | Emil Lauridsen | 2019-12-27 | 9 | -0/+1681 |