Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Rename ra_syntax -> syntax | Aleksey Kladov | 2020-08-12 | 1 | -2/+2 |
| | |||||
* | Rename ra_prof -> profile | Aleksey Kladov | 2020-08-12 | 1 | -3/+2 |
| | |||||
* | Merge #5553 | bors[bot] | 2020-08-12 | 1 | -12/+6 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5553: Add fix ranges for diagnostics r=matklad a=SomeoneToIgnore A follow-up of https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Less.20red.20in.20the.20code Now diagnostics can apply fixes in a range that's different from the range used to highlight the diagnostics. Previous logic did not consider the fix range, having both ranges equal, which could cause a lot of red noise in the editor. Now, the fix range gets used with the fix, the diagnostics range is used for everything else which allows to improve the error highlighting. before: <img width="191" alt="image" src="https://user-images.githubusercontent.com/2690773/88590727-df9a6a00-d063-11ea-97ed-9809c1c5e6e6.png"> after: <img width="222" alt="image" src="https://user-images.githubusercontent.com/2690773/88590734-e1fcc400-d063-11ea-9b7c-25701cbd5352.png"> `MissingFields` and `MissingPatFields` diagnostics now have the fix range as `ast::RecordFieldList` of the expression with an error (as it was before this PR), and the diagnostics range as a `ast::Path` of the expression, if it's present (do you have any example of `ast::Expr::RecordLit` that has no path btw?). The rest of the diagnostics have both ranges equal, same as it was before this PR. Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | Better naming and docs | Kirill Bulatov | 2020-08-11 | 1 | -4/+4 |
| | | |||||
| * | Improve the ide diagnostics trait API | Kirill Bulatov | 2020-08-11 | 1 | -4/+1 |
| | | |||||
| * | Move the DiagnosticsWithFix trait on the ide level | Kirill Bulatov | 2020-08-11 | 1 | -9/+3 |
| | | |||||
| * | Make the fix AST source Optional | Kirill Bulatov | 2020-08-11 | 1 | -4/+4 |
| | | |||||
| * | Refactor the diagnostics | Kirill Bulatov | 2020-08-11 | 1 | -18/+10 |
| | | |||||
| * | Better naming | Kirill Bulatov | 2020-08-11 | 1 | -0/+11 |
| | | |||||
* | | Fix type names broken by rebase, redo expected test because of rebase | Paul Daniel Faria | 2020-08-10 | 1 | -9/+13 |
| | | |||||
* | | Move unsafe semantics methods into `SemanticsImpl` and reference them in ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -71/+83 |
| | | | | | | | | `Semantics` | ||||
* | | Return bool from is_unsafe_method_call and cleanup usages | Paul Daniel Faria | 2020-08-10 | 1 | -19/+19 |
| | | |||||
* | | Move semantic logic into Semantics, fix missing tag for safe amp operator, ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -35/+75 |
| | | | | | | | | using functional methods rather than clunky inline closure | ||||
* | | Move unsafe packed ref logic to Semantics, use `Attrs::by_key` to simplify ↵ | Paul Daniel Faria | 2020-08-10 | 1 | -0/+41 |
|/ | | | | repr attr lookup | ||||
* | Add support for extern crate | Paul Daniel Faria | 2020-08-08 | 1 | -3/+22 |
| | | | | | This adds syntax highlighting, hover and goto def functionality for extern crate | ||||
* | Rename BindPat -> IdentPat | Aleksey Kladov | 2020-07-31 | 1 | -3/+3 |
| | |||||
* | Allign RecordPat with RecordExpr | Aleksey Kladov | 2020-07-31 | 1 | -2/+2 |
| | |||||
* | Finalize impl Grammar | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Finalize Trait grammar | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Finalize const&static grammar | Aleksey Kladov | 2020-07-30 | 1 | -2/+2 |
| | |||||
* | Rename EnumVariant -> Variant | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Rename EnumDef -> Enum | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Rename StructDef -> Struct | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Finalize union grammar | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Rename FieldDef -> Field | Aleksey Kladov | 2020-07-30 | 1 | -2/+2 |
| | |||||
* | Rename RecordLit -> RecordExpr | Aleksey Kladov | 2020-07-30 | 1 | -6/+9 |
| | |||||
* | Rename TypeAliasDef -> TypeAlias | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Rename FnDef -> Fn | Aleksey Kladov | 2020-07-30 | 1 | -1/+1 |
| | |||||
* | Cache macro expansion in semantics | Aleksey Kladov | 2020-07-24 | 1 | -2/+14 |
| | | | | | #5497 accidentally made syntax highlighting quadratic, due to repeated tokentreeizing of macros. | ||||
* | Add missing cancellation point | Aleksey Kladov | 2020-07-24 | 1 | -0/+1 |
| | |||||
* | Add profiling call | Aleksey Kladov | 2020-07-24 | 1 | -0/+1 |
| | |||||
* | Semantical call info | Aleksey Kladov | 2020-07-16 | 1 | -5/+20 |
| | |||||
* | Fix goto definition for type alias type parameters | Aleksey Kladov | 2020-07-11 | 1 | -0/+1 |
| | | | | closes https://github.com/rust-analyzer/rust-analyzer/issues/5042 | ||||
* | Reduce visibility | Aleksey Kladov | 2020-07-11 | 1 | -31/+31 |
| | |||||
* | Speed up completion | Aleksey Kladov | 2020-07-11 | 1 | -0/+1 |
| | |||||
* | Dont expose ID | Aleksey Kladov | 2020-07-10 | 1 | -4/+3 |
| | |||||
* | Rename | Aleksey Kladov | 2020-07-10 | 1 | -1/+1 |
| | |||||
* | Goto type definition works for self | Aleksey Kladov | 2020-07-10 | 1 | -0/+9 |
| | |||||
* | Make less code generic | Laurențiu Nicola | 2020-07-01 | 1 | -69/+47 |
| | |||||
* | Try to reduce Semantics monomorphisations | Laurențiu Nicola | 2020-07-01 | 1 | -23/+186 |
| | |||||
* | Make SemanticsScope non-generic | Laurențiu Nicola | 2020-07-01 | 1 | -8/+8 |
| | |||||
* | Add quickfix to add a struct field | Timo Freiberg | 2020-06-12 | 1 | -2/+13 |
| | |||||
* | Don't guess macro expansion crate | Aleksey Kladov | 2020-06-11 | 1 | -1/+2 |
| | |||||
* | Add doc comment for resolve_hir_path_qualifier | Hasan Ali | 2020-05-16 | 1 | -0/+13 |
| | |||||
* | Fix completion and hover for module and function of same name | Hasan Ali | 2020-05-16 | 1 | -1/+5 |
| | |||||
* | Remove lower_path from AssistCtx to Semantic | Edwin Cheng | 2020-05-01 | 1 | -1/+6 |
| | |||||
* | ? | Jonas Schievink | 2020-04-29 | 1 | -5/+1 |
| | |||||
* | Use or-patterns more | Jonas Schievink | 2020-04-29 | 1 | -10/+9 |
| | |||||
* | Remove `.clone()` | Jonas Schievink | 2020-04-29 | 1 | -8/+8 |
| | |||||
* | Rename to associated_type_shorthand_candidates | Jonas Schievink | 2020-04-29 | 1 | -2/+2 |
| |