Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Reduce copy-paste some more | Aleksey Kladov | 2019-12-20 | 1 | -13/+1 |
| | |||||
* | Use generic ItemLoc for impls | Aleksey Kladov | 2019-12-20 | 1 | -23/+4 |
| | |||||
* | Remove more copy-paste | Aleksey Kladov | 2019-12-20 | 1 | -121/+29 |
| | |||||
* | Remove more copy-paste | Aleksey Kladov | 2019-12-20 | 1 | -57/+30 |
| | |||||
* | Support for nested traits | Aleksey Kladov | 2019-12-20 | 1 | -3/+3 |
| | |||||
* | Support for nested statics, consts and type aliases | Aleksey Kladov | 2019-12-20 | 1 | -3/+3 |
| | |||||
* | Support for nested ADT | Aleksey Kladov | 2019-12-20 | 1 | -4/+5 |
| | |||||
* | Introduce `ContainerId` | Aleksey Kladov | 2019-12-20 | 1 | -4/+18 |
| | |||||
* | Rename ContainerId -> AssocContainerId | Aleksey Kladov | 2019-12-20 | 1 | -9/+9 |
| | |||||
* | Add body as a possible container for items | Aleksey Kladov | 2019-12-19 | 1 | -12/+12 |
| | |||||
* | Remove old location infra | Aleksey Kladov | 2019-12-12 | 1 | -61/+4 |
| | |||||
* | Move enum&union to new loc | Aleksey Kladov | 2019-12-12 | 1 | -13/+37 |
| | |||||
* | Move structs to new loc | Aleksey Kladov | 2019-12-12 | 1 | -6/+18 |
| | |||||
* | Move traits to the new loc | Aleksey Kladov | 2019-12-12 | 1 | -9/+21 |
| | |||||
* | Switch to the new location for impls | Aleksey Kladov | 2019-12-12 | 1 | -9/+21 |
| | |||||
* | Rename GenericParam -> TypeParam | Aleksey Kladov | 2019-12-07 | 1 | -4/+4 |
| | | | | We don't have LifetimeParam yet, but they are planned! | ||||
* | Classify name works for TypeParams | Aleksey Kladov | 2019-12-07 | 1 | -0/+14 |
| | |||||
* | Store GenericParams in arena | Aleksey Kladov | 2019-12-07 | 1 | -0/+10 |
| | |||||
* | DynMap | Aleksey Kladov | 2019-12-06 | 1 | -1/+4 |
| | | | | | This might, or might not help us to reduce boilerplate associated with plumbing values from analysis to the IDE layer | ||||
* | Introduce ChildFromSource | Aleksey Kladov | 2019-12-05 | 1 | -0/+1 |
| | |||||
* | Move source-related traits to a separate module | Aleksey Kladov | 2019-11-28 | 1 | -51/+3 |
| | |||||
* | Use InFile for AstId | Aleksey Kladov | 2019-11-28 | 1 | -5/+5 |
| | |||||
* | Rename Source -> InFile | Aleksey Kladov | 2019-11-28 | 1 | -13/+13 |
| | |||||
* | Rename module_id -> local_id | Aleksey Kladov | 2019-11-27 | 1 | -1/+1 |
| | |||||
* | Move Ty | Aleksey Kladov | 2019-11-27 | 1 | -1/+1 |
| | |||||
* | Decouple | Aleksey Kladov | 2019-11-27 | 1 | -0/+10 |
| | |||||
* | Introduce hir::Type | Aleksey Kladov | 2019-11-26 | 1 | -0/+10 |
| | | | | It should provide a convenient API over more low-level Ty | ||||
* | Fixme for union fields | Aleksey Kladov | 2019-11-25 | 1 | -0/+1 |
| | |||||
* | Fix hir for ast::UnionDef | Aleksey Kladov | 2019-11-25 | 1 | -18/+14 |
| | |||||
* | Merge #2396 | bors[bot] | 2019-11-24 | 1 | -6/+7 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2396: Switch to variant-granularity field type inference r=flodiebold a=matklad r? @flodiebold Previously, we had a `ty` query for each field. This PR switcthes to a query per struct, which returns an `ArenaMap` with `Ty`s. I don't know which approach is better. What is bugging me about the original approach is that, if we do all queries on the "leaf" defs, in practice we get a ton of queries which repeatedly reach into the parent definition to compute module, resolver, etc. This *seems* wasteful (but I don't think this is really what causes any perf problems for us). At the same time, I've been looking at Kotlin, and they seem to use the general pattern of analyzing the *parent* definition, and storing info about children into a `BindingContext`. I don't really which way is preferable. I think I want to try this approach, where query granularity generally mirrors the data granularity. The primary motivation for me here is probably just hope that we can avoid adding a ton of helpers to a `StructField`, and maybe in general avoid the need to switch to a global `StructField`, using `LocalStructFieldId` most of the time internally. For external API (ie, for `ra_ide_api`), I think we should continue with fine-grained `StructField::ty` approach, which internally fetches the table for the whole struct and indexes into it. In terms of actual memory savings, the results are as follows: ``` This PR: 142kb FieldTypesQuery (deps) 38kb FieldTypesQuery Status Quo: 208kb TypeForFieldQuery (deps) 18kb TypeForFieldQuery ``` Note how the table itself occupies more than twice as much space! I don't have an explanation for this: a plausible hypothesis is that single-field structs are very common and for them the table is a pessimisation. THere's noticiable wallclock time difference. Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | Switch to variant-granularity field type inference | Aleksey Kladov | 2019-11-24 | 1 | -6/+7 |
| | | |||||
* | | Implement HasModule for AdtId | Aleksey Kladov | 2019-11-24 | 1 | -0/+10 |
|/ | |||||
* | Cleanup | Aleksey Kladov | 2019-11-24 | 1 | -6/+9 |
| | |||||
* | Simplify | Aleksey Kladov | 2019-11-24 | 1 | -15/+0 |
| | |||||
* | Switch to StaticLoc for statics | Aleksey Kladov | 2019-11-24 | 1 | -5/+32 |
| | |||||
* | Pull macro up | Aleksey Kladov | 2019-11-24 | 1 | -14/+1 |
| | |||||
* | Move ModuleSource back to hir | Aleksey Kladov | 2019-11-23 | 1 | -60/+2 |
| | |||||
* | Privatise nameres | Aleksey Kladov | 2019-11-23 | 1 | -3/+2 |
| | |||||
* | Rename CrateModuleId | Aleksey Kladov | 2019-11-23 | 1 | -3/+3 |
| | |||||
* | Move ImportId | Aleksey Kladov | 2019-11-23 | 1 | -0/+4 |
| | |||||
* | Get rid of DefDatabase2 | Aleksey Kladov | 2019-11-23 | 1 | -24/+21 |
| | |||||
* | Move docs to hir_def | Aleksey Kladov | 2019-11-23 | 1 | -0/+1 |
| | |||||
* | Move lang_items to hir_def | Aleksey Kladov | 2019-11-23 | 1 | -0/+1 |
| | |||||
* | Use attrs rather than syntax for lang items | Aleksey Kladov | 2019-11-23 | 1 | -1/+3 |
| | |||||
* | Move attrs query to hir_def | Aleksey Kladov | 2019-11-23 | 1 | -3/+30 |
| | |||||
* | More principled sources for enums and fields | Aleksey Kladov | 2019-11-22 | 1 | -1/+12 |
| | |||||
* | Move data to a single file | Aleksey Kladov | 2019-11-22 | 1 | -4/+1 |
| | |||||
* | Move FunctionData to hir_def | Aleksey Kladov | 2019-11-22 | 1 | -0/+1 |
| | |||||
* | Move TypeAlias to hir_def | Aleksey Kladov | 2019-11-22 | 1 | -0/+1 |
| | |||||
* | Move resolver to hir_def | Aleksey Kladov | 2019-11-21 | 1 | -0/+1 |
| |