| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | Merge #4596 | bors[bot] | 2020-05-27 | 1 | -1/+59 | |
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example  Co-authored-by: Yuki Kodama <[email protected]> | |||||
| | * | | Trim at presentation layer | Yuki Kodama | 2020-05-25 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | Fix test to consider multiple underscores | Yuki Kodama | 2020-05-25 | 1 | -7/+7 | |
| | | | | ||||||
| | * | | Separate assertions | Yuki Kodama | 2020-05-25 | 1 | -7/+65 | |
| | | | | ||||||
| | * | | Reflect test case | Yuki Kodama | 2020-05-25 | 1 | -7/+7 | |
| | |/ | ||||||
| | | | ||||||
| | \ | ||||||
| *-. \ | Merge #4625 #4629 | bors[bot] | 2020-05-27 | 1 | -3/+3 | |
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]> | |||||
| | | * | | Fix the `should_panic` snippet | Andrew Chin | 2020-05-26 | 1 | -3/+3 | |
| | |/ / | | | | | | | | | | Closes #4628 | |||||
| * / / | Pass trivially copy types as copy | kjeremy | 2020-05-26 | 1 | -32/+29 | |
| |/ / | ||||||
| * | | Merge #4534 | bors[bot] | 2020-05-26 | 1 | -0/+59 | |
| |\ \ | |/ |/| | | | | | | | | | | | | | | | 4534: Add call postfix completion r=matklad a=vain0x To make it easier to wrap an expression with Ok/Some/Rc::new etc. Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use. Co-authored-by: vain0x <[email protected]> | |||||
| | * | Add call postfix completion | vain0x | 2020-05-20 | 1 | -0/+59 | |
| | | | | | | | | | To make it easier to wrap an expression with Ok/Some/Rc::new etc. | |||||
| * | | Cleanup TextEdit | Aleksey Kladov | 2020-05-21 | 1 | -2/+2 | |
| |/ | ||||||
| * | Switch to new magic marks | Aleksey Kladov | 2020-05-20 | 3 | -20/+20 | |
| | | ||||||
| * | Add AssistConfig | Aleksey Kladov | 2020-05-19 | 1 | -1/+1 | |
| | | ||||||
| * | Fix completion and hover for module and function of same name | Hasan Ali | 2020-05-16 | 1 | -1/+29 | |
| | | ||||||
| * | Prioritize locals with correct types | Aleksey Kladov | 2020-05-14 | 2 | -5/+55 | |
| | | ||||||
| * | add more specific match postfix for Result and Option | Benjamin Coenen | 2020-05-12 | 1 | -15/+43 | |
| | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
| * | Merge #4423 | bors[bot] | 2020-05-11 | 1 | -0/+26 | |
| |\ | | | | | | | | | | | | | | | 4423: add tests module snippet r=bnjjj a=bnjjj Request from a friend coming from intellij Rust Co-authored-by: Benjamin Coenen <[email protected]> | |||||
| | * | add tests module snippet | Benjamin Coenen | 2020-05-11 | 1 | -0/+8 | |
| | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
| | * | add tests module snippet | Benjamin Coenen | 2020-05-11 | 1 | -0/+18 | |
| | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
| * | | add if let and while let postfix for Option and Result | Benjamin Coenen | 2020-05-10 | 1 | -38/+44 | |
| | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
| * | | add if let and while let postfix for Option and Result #4348 | Benjamin Coenen | 2020-05-07 | 1 | -1/+199 | |
| |/ | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
| * | Minor | Aleksey Kladov | 2020-05-06 | 1 | -1/+2 | |
| | | ||||||
| * | Rename AtomTextEdit -> Indel | Aleksey Kladov | 2020-05-05 | 2 | -4/+4 | |
| | | ||||||
| * | Rename ImplItem to AssocItem | Edwin Cheng | 2020-05-05 | 2 | -21/+27 | |
| | | ||||||
| * | Remove false positive attr compleitons | Aleksey Kladov | 2020-05-04 | 2 | -4/+40 | |
| | | ||||||
| * | Qualify ast types | Aleksey Kladov | 2020-05-04 | 1 | -6/+5 | |
| | | ||||||
| * | Cleanup imports | Aleksey Kladov | 2020-05-04 | 1 | -4/+6 | |
| | | ||||||
| * | Fix derive argument parsing | Kirill Bulatov | 2020-05-02 | 1 | -26/+40 | |
| | | ||||||
| * | Propose custom derives in completion | Kirill Bulatov | 2020-05-02 | 1 | -8/+32 | |
| | | ||||||
| * | Complete standard derives | Kirill Bulatov | 2020-05-02 | 2 | -16/+245 | |
| | | ||||||
| * | Introduce EffectExpr | Aleksey Kladov | 2020-05-02 | 1 | -1/+1 | |
| | | ||||||
| * | if let -> match | Jonas Schievink | 2020-04-29 | 1 | -4/+3 | |
| | | ||||||
| * | Complete assoc. items on type parameters | Jonas Schievink | 2020-04-29 | 1 | -11/+262 | |
| | | ||||||
| * | Better filtering of qualified enum variants in completion | Aleksey Kladov | 2020-04-29 | 2 | -9/+49 | |
| | | ||||||
| * | Complete union fields after dot | Jonas Schievink | 2020-04-28 | 1 | -0/+38 | |
| | | ||||||
| * | Precompute expected type during completion | Aleksey Kladov | 2020-04-26 | 3 | -35/+44 | |
| | | ||||||
| * | Fix broken test | Jonas Schievink | 2020-04-25 | 1 | -1/+1 | |
| | | ||||||
| * | Don't add call parens when an fn type is expected | Jonas Schievink | 2020-04-25 | 1 | -0/+56 | |
| | | ||||||
| * | Rename StructField -> Field | Aleksey Kladov | 2020-04-25 | 1 | -6/+1 | |
| | | ||||||
| * | text-size 1.0.0 | Aleksey Kladov | 2020-04-25 | 1 | -6/+6 | |
| | | ||||||
| * | Convert tests to text-size | Aleksey Kladov | 2020-04-25 | 13 | -790/+789 | |
| | | ||||||
| * | Convert code to text-size | Aleksey Kladov | 2020-04-25 | 4 | -14/+15 | |
| | | ||||||
| * | Merge #4128 | bors[bot] | 2020-04-24 | 1 | -1/+52 | |
| |\ | | | | | | | | | | | | | | | 4128: Include correct item path for variant completions r=matklad a=jonas-schievink The test would previously suggest `E::V`, which is not enough to name the variant as the enum is in a module. Now it correctly suggests the full path `m::E::V`. Co-authored-by: Jonas Schievink <[email protected]> | |||||
| | * | Include correct item path for variant completions | Jonas Schievink | 2020-04-24 | 1 | -1/+52 | |
| | | | ||||||
| * | | Don't omit methods with self from path completion | Jonas Schievink | 2020-04-24 | 1 | -6/+38 | |
| |/ | ||||||
| * | Adds attribute completions (#3941) | Roberto Vidal | 2020-04-24 | 3 | -0/+592 | |
| | | ||||||
| * | Better label for macros completion | Aleksey Kladov | 2020-04-24 | 5 | -48/+59 | |
| | | ||||||
| * | Honor snippet capability | Aleksey Kladov | 2020-04-24 | 1 | -0/+6 | |
| | | | | | closes #2518 | |||||
| * | Make sure that adding a snippet requires corresponding capability | Aleksey Kladov | 2020-04-24 | 6 | -44/+107 | |
| | | ||||||
| * | Introduce internal snippet cap | Aleksey Kladov | 2020-04-24 | 1 | -0/+13 | |
| | | ||||||
 |
index : rust-analyzer | |
| [FORK] modified to work on wasm targets |
| aboutsummaryrefslogtreecommitdiff |