Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #3384 | bors[bot] | 2020-03-01 | 1 | -0/+39 |
|\ | | | | | | | | | | | | | | | | | | | | | | | 3384: fix #2377 super::super::* r=flodiebold a=JoshMcguigan Thanks @matklad for the detailed explanation on #2377. I believe this fixes it. One thing I'm not sure about is you said the fix would involve changing `crates/ra_hir_def/src/path/lower/lower.rs`, but I only changed `crates/ra_hir_def/src/path/lower/lower_use.rs`. I'm not sure what kind of test code I'd have to write to expose the issue in `lower.rs`, but I'd be happy to add it if you are able to provide additional guidance. closes #2377 Co-authored-by: Josh Mcguigan <[email protected]> | ||||
| * | fix completion for super::super:: | Josh Mcguigan | 2020-03-01 | 1 | -0/+39 |
| | | |||||
* | | Rename ast::ImplBlock -> ast::ImplDef | Aleksey Kladov | 2020-02-29 | 2 | -32/+26 |
|/ | |||||
* | Refactor primary IDE API | Aleksey Kladov | 2020-02-26 | 10 | -60/+66 |
| | | | | | | | | | | This introduces the new type -- Semantics. Semantics maps SyntaxNodes to various semantic info, such as type, name resolution or macro expansions. To do so, Semantics maintains a HashMap which maps every node it saw to the file from which the node originated. This is enough to get all the necessary hir bits just from syntax. | ||||
* | Refactor how builtins are resolved | Florian Diebold | 2020-02-21 | 1 | -6/+7 |
| | | | | This fixes autocompletion suggesting e.g. self::usize. | ||||
* | Cleanup | Shotaro Yamada | 2020-02-19 | 1 | -5/+1 |
| | |||||
* | More manual clippy fixes | Kirill Bulatov | 2020-02-18 | 2 | -6/+6 |
| | |||||
* | Merge #3169 | bors[bot] | 2020-02-17 | 1 | -6/+95 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3169: Show record field names in Enum completion r=flodiebold a=adamrk Adresses https://github.com/rust-analyzer/rust-analyzer/issues/2947. Previously the details shown when autocompleting an Enum variant would look like the variant was a tuple even if it was a record: ![2020-02-16-15:59:32_crop](https://user-images.githubusercontent.com/16367467/74607233-64f21980-50d7-11ea-99db-e973e29c71d7.png) This change will show the names of the fields for a record and use curly braces instead of parentheses: ![2020-02-16-15:33:00_crop](https://user-images.githubusercontent.com/16367467/74607251-8ce17d00-50d7-11ea-9d4d-38d198a4aec0.png) This required exposing the type `adt::StructKind` from `ra_hir` and adding a function ``` kind(self, db: &impl HirDatabase) -> StructKind ``` in the `impl` of `EnumVariant`. There was also a previously existing function `is_unit(self, db: &impl HirDatabase) -> bool` for `EnumVariant` which I removed because it seemed redundant after adding `kind`. Co-authored-by: adamrk <[email protected]> | ||||
| * | add space before/after wrapping braces | adamrk | 2020-02-16 | 1 | -2/+2 |
| | | |||||
| * | show names for record fields in enum completion | adamrk | 2020-02-16 | 1 | -6/+95 |
| | | |||||
* | | Added module doc comment to explain the purpose of the completion. | Kevin DeLorey | 2020-02-15 | 1 | -1/+32 |
| | | |||||
* | | Fixed bug that allowed for completion in a nested method. | Kevin DeLorey | 2020-02-15 | 1 | -7/+36 |
| | | |||||
* | | Reordered the `use` items. | Kevin DeLorey | 2020-02-15 | 1 | -9/+8 |
| | | |||||
* | | Adjusted the completion lookups to filter by just the name. | Kevin DeLorey | 2020-02-14 | 1 | -29/+44 |
| | | |||||
* | | Completion now replaces whole fn/const/type def with snippet. | Kevin DeLorey | 2020-02-13 | 1 | -16/+31 |
| | | |||||
* | | Cheese const tests as they requre an ident before becoming a CONST_DEF. | Kevin DeLorey | 2020-02-13 | 1 | -28/+21 |
| | | |||||
* | | Started to refactor the trigger of the trait_impl completion. | Kevin DeLorey | 2020-02-13 | 1 | -33/+77 |
| | | |||||
* | | Formatting. | Kevin DeLorey | 2020-02-11 | 1 | -1/+3 |
| | | |||||
* | | Fixing minor suggestions and added module level documentation. | Kevin DeLorey | 2020-02-11 | 1 | -9/+6 |
| | | |||||
* | | Removed doc comments entirely from the changes. | Kevin DeLorey | 2020-02-11 | 1 | -39/+0 |
| | | |||||
* | | Formatted changes. | Kevin DeLorey | 2020-02-11 | 1 | -22/+16 |
| | | |||||
* | | Removed docs from private method. | Kevin DeLorey | 2020-02-11 | 1 | -8/+0 |
| | | |||||
* | | Added tests to test associated types and consts. | Kevin DeLorey | 2020-02-11 | 1 | -0/+78 |
| | | |||||
* | | Added some documentation to the `complete_trait_impl` completion. | Kevin DeLorey | 2020-02-11 | 1 | -1/+48 |
| | | |||||
* | | Added associated const magic completion. | Kevin DeLorey | 2020-02-10 | 1 | -11/+53 |
| | | |||||
* | | Added a utility function that can be used to determine the missing impl items. | Kevin DeLorey | 2020-02-09 | 1 | -114/+18 |
| | | |||||
* | | Merge branch 'master' into kdelorey/complete-trait-impl | Kevin DeLorey | 2020-02-09 | 3 | -118/+8 |
|\| | |||||
| * | Remove hard-coded auto-import during completion | Aleksey Kladov | 2020-02-09 | 1 | -128/+3 |
| | | | | | | | | We now have a real auto-import system, so we can do a proper thing. | ||||
| * | Rename add import assist | Kirill Bulatov | 2020-02-07 | 1 | -7/+2 |
| | | |||||
| * | cleanup imports | Aleksey Kladov | 2020-02-06 | 1 | -3/+4 |
| | | |||||
| * | Code review fixes | Kirill Bulatov | 2020-02-02 | 1 | -15/+11 |
| | | |||||
| * | Require ModPath for importing | Kirill Bulatov | 2020-02-02 | 1 | -24/+47 |
| | | |||||
* | | Added associated type completion. | Kevin DeLorey | 2020-02-08 | 1 | -3/+15 |
| | | |||||
* | | Cleaning up unessicary code that the Magic completion takes care of. | Kevin DeLorey | 2020-02-08 | 1 | -39/+8 |
| | | |||||
* | | Got the magic completion working. | Kevin DeLorey | 2020-02-08 | 2 | -41/+16 |
| | | |||||
* | | Update completion kind to Magic in the unit tests. | Kevin DeLorey | 2020-02-08 | 1 | -2/+2 |
| | | |||||
* | | Add detection for a user already starting a fn impl and still providing ↵ | Kevin DeLorey | 2020-02-05 | 2 | -38/+157 |
| | | | | | | | | completion. | ||||
* | | Already implemented fn will no longer be suggested for trait implementations. | Kevin DeLorey | 2020-01-29 | 2 | -17/+131 |
| | | |||||
* | | Renamed the trait completion mod. | Kevin DeLorey | 2020-01-23 | 1 | -1/+1 |
| | | |||||
* | | Added basic support for completing `fn` for trait impl. | Kevin DeLorey | 2020-01-23 | 2 | -0/+113 |
|/ | |||||
* | Create modules via SourceBinder | Aleksey Kladov | 2020-01-16 | 1 | -7/+3 |
| | |||||
* | Move Type API to type | Aleksey Kladov | 2020-01-14 | 2 | -19/+24 |
| | |||||
* | Move impls_future to Type, where it belongs | Aleksey Kladov | 2020-01-14 | 1 | -1/+1 |
| | |||||
* | Use lang-items to resolve future trait | Aleksey Kladov | 2020-01-14 | 1 | -0/+1 |
| | |||||
* | Some clippy lints | kjeremy | 2020-01-13 | 1 | -1/+1 |
| | |||||
* | Add macro_rules item snippet | memoryruins | 2020-01-12 | 1 | -0/+8 |
| | |||||
* | visible_from -> is_visible_from | Florian Diebold | 2019-12-27 | 1 | -1/+1 |
| | |||||
* | Hide completions for private struct fields | Florian Diebold | 2019-12-26 | 1 | -1/+56 |
| | |||||
* | Rudimentary name resolution for local items | Aleksey Kladov | 2019-12-22 | 1 | -0/+37 |
| | |||||
* | Remove imports from hir | Aleksey Kladov | 2019-12-21 | 2 | -10/+12 |
| |