aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #3169bors[bot]2020-02-171-6/+95
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3169: Show record field names in Enum completion r=flodiebold a=adamrk Adresses https://github.com/rust-analyzer/rust-analyzer/issues/2947. Previously the details shown when autocompleting an Enum variant would look like the variant was a tuple even if it was a record: ![2020-02-16-15:59:32_crop](https://user-images.githubusercontent.com/16367467/74607233-64f21980-50d7-11ea-99db-e973e29c71d7.png) This change will show the names of the fields for a record and use curly braces instead of parentheses: ![2020-02-16-15:33:00_crop](https://user-images.githubusercontent.com/16367467/74607251-8ce17d00-50d7-11ea-9d4d-38d198a4aec0.png) This required exposing the type `adt::StructKind` from `ra_hir` and adding a function ``` kind(self, db: &impl HirDatabase) -> StructKind ``` in the `impl` of `EnumVariant`. There was also a previously existing function `is_unit(self, db: &impl HirDatabase) -> bool` for `EnumVariant` which I removed because it seemed redundant after adding `kind`. Co-authored-by: adamrk <[email protected]>
| * add space before/after wrapping bracesadamrk2020-02-161-2/+2
| |
| * show names for record fields in enum completionadamrk2020-02-161-6/+95
| |
* | Merge #3099bors[bot]2020-02-172-0/+336
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3099: Init implementation of structural search replace r=matklad a=mikhail-m1 next steps: * ignore space and other minor difference * add support to ra_cli * call rust parser to check pattern * documentation original issue #2267 Co-authored-by: Mikhail Modin <[email protected]>
| * | Init implementation of structural search replaceMikhail Modin2020-02-142-0/+336
| |/
* | Merge #3108bors[bot]2020-02-173-0/+448
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3108: Magic Completion for `impl Trait for` Associated Items r=matklad a=kdelorey # Summary This PR adds a set of magic completions to auto complete associated trait items (functions/consts/types). ![Associated Trait Impl](https://user-images.githubusercontent.com/2295721/74493144-d8f1af00-4e96-11ea-93a4-82725bf89646.gif) ## Notes Since the assist and completion share the same logic when figuring out the associated items that are missing, a shared utility was created in the `ra_assists::utils` module. Resolves #1046 As this is my first PR to the rust-analyzer project, I'm new to the codebase, feedback welcomed! Co-authored-by: Kevin DeLorey <[email protected]>
| * | Added module doc comment to explain the purpose of the completion.Kevin DeLorey2020-02-151-1/+32
| | |
| * | Fixed bug that allowed for completion in a nested method.Kevin DeLorey2020-02-151-7/+36
| | |
| * | Reordered the `use` items.Kevin DeLorey2020-02-151-9/+8
| | |
| * | Adjusted the completion lookups to filter by just the name.Kevin DeLorey2020-02-141-29/+44
| | |
| * | Completion now replaces whole fn/const/type def with snippet.Kevin DeLorey2020-02-131-16/+31
| | |
| * | Cheese const tests as they requre an ident before becoming a CONST_DEF.Kevin DeLorey2020-02-131-28/+21
| | |
| * | Started to refactor the trigger of the trait_impl completion.Kevin DeLorey2020-02-131-33/+77
| | |
| * | Formatting.Kevin DeLorey2020-02-111-1/+3
| | |
| * | Fixing minor suggestions and added module level documentation.Kevin DeLorey2020-02-111-9/+6
| | |
| * | Removed doc comments entirely from the changes.Kevin DeLorey2020-02-111-39/+0
| | |
| * | Formatted changes.Kevin DeLorey2020-02-111-22/+16
| | |
| * | Removed docs from private method.Kevin DeLorey2020-02-111-8/+0
| | |
| * | Added tests to test associated types and consts.Kevin DeLorey2020-02-111-0/+78
| | |
| * | Added some documentation to the `complete_trait_impl` completion.Kevin DeLorey2020-02-111-1/+48
| | |
| * | Added associated const magic completion.Kevin DeLorey2020-02-101-11/+53
| | |
| * | Added a utility function that can be used to determine the missing impl items.Kevin DeLorey2020-02-092-115/+19
| | |
| * | Merge branch 'master' into kdelorey/complete-trait-implKevin DeLorey2020-02-0941-2293/+657
| |\ \
| * | | Added associated type completion.Kevin DeLorey2020-02-081-3/+15
| | | |
| * | | Cleaning up unessicary code that the Magic completion takes care of.Kevin DeLorey2020-02-081-39/+8
| | | |
| * | | Got the magic completion working.Kevin DeLorey2020-02-082-41/+16
| | | |
| * | | Update completion kind to Magic in the unit tests.Kevin DeLorey2020-02-081-2/+2
| | | |
| * | | Add detection for a user already starting a fn impl and still providing ↵Kevin DeLorey2020-02-052-38/+157
| | | | | | | | | | | | | | | | completion.
| * | | Already implemented fn will no longer be suggested for trait implementations.Kevin DeLorey2020-01-292-17/+131
| | | |
| * | | Renamed the trait completion mod.Kevin DeLorey2020-01-232-3/+3
| | | |
| * | | Added basic support for completing `fn` for trait impl.Kevin DeLorey2020-01-233-0/+116
| | | |
* | | | Merge #3153bors[bot]2020-02-172-25/+86
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3153: When a single test is run, do not run others with overlapping names r=matklad a=SomeoneToIgnore Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | Simplify module retrievalKirill Bulatov2020-02-161-7/+5
| | | | |
| * | | | If possible, use --exact flag when running testsKirill Bulatov2020-02-142-25/+88
| | |_|/ | |/| |
* / | | Add module colors to cssAleksey Kladov2020-02-163-0/+3
|/ / /
* | | SimplifyAleksey Kladov2020-02-121-15/+7
| | |
* | | Return early, return oftenAleksey Kladov2020-02-111-27/+33
| | |
* | | Fix join lines when two rules matchAleksey Kladov2020-02-111-23/+46
| | |
* | | Merge #3064bors[bot]2020-02-112-25/+68
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3064: Handle macro token cases for rename r=matklad a=edwin0cheng Fixes #2957 Co-authored-by: Edwin Cheng <[email protected]>
| * | | Use get_or_insert_withEdwin Cheng2020-02-091-4/+3
| | | |
| * | | Handle macro token cases for renameEdwin Cheng2020-02-092-25/+69
| | | |
* | | | Add or- and parenthesized-patternsMatthew Jasper2020-02-091-2/+3
| |_|/ |/| |
* | | Simplify Assists interfaceAleksey Kladov2020-02-091-18/+6
| | | | | | | | | | | | | | | Instead of building a physical tree structure, just "tag" related assists with the same group
* | | Remove hard-coded auto-import during completionAleksey Kladov2020-02-091-128/+3
| | | | | | | | | | | | We now have a real auto-import system, so we can do a proper thing.
* | | Rename add import assistKirill Bulatov2020-02-071-7/+2
|/ /
* | RenameAleksey Kladov2020-02-074-18/+18
| |
* | Remove irrelevant distinctionAleksey Kladov2020-02-075-20/+18
| |
* | Minor renameAleksey Kladov2020-02-061-2/+2
| |
* | Mostly remove ImoportLocator infraAleksey Kladov2020-02-061-1/+1
| |
* | Make assists use ImportsLocator directlyAleksey Kladov2020-02-061-2/+2
| |