aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4346bors[bot]2020-05-071-0/+62
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4346: Fix rename of enum variant visible from module r=matklad a=montekki Probably fixes #4237 It looks like the ref is found correctly in this case but it's visibility is not correctly determined. I took a stab at fixing that by adding an implementation of `HasVisibility` for `EnumVariant` so it works more or less the same way it does for struct fields. In other words, the `search_range` here does not contain the ref since it's not considered visible: https://github.com/rust-analyzer/rust-analyzer/blob/efd8e34c396f1524623a495e47111f1047cf2879/crates/ra_ide_db/src/search.rs#L209-L214 Before that I tried to populate `ItemScope` with visible enum variants but that ended up with breaking tests all over the place and also it looked illogical in the end: `ItemScope` is not populated with, say, public struct fields and the same should be true for `enum` variants. I've added two more or less identical tests: one for the case with a struct field rename and one for enum variant rename; the test for struct should probably be removed and the names should be changed. Co-authored-by: Fedor Sakharov <[email protected]>
| * Fix rename of enum variant visible from moduleFedor Sakharov2020-05-061-0/+62
| |
* | Nicer APIAleksey Kladov2020-05-071-1/+1
| |
* | Rename AssitLabel -> AssistAleksey Kladov2020-05-071-3/+3
| |
* | Fix panic in FunctionSignatureAleksey Kladov2020-05-071-1/+7
| |
* | Merge #4316 #4351bors[bot]2020-05-061-4/+45
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4316: do not truncate display for hover r=matklad a=bnjjj close #4311 4351: Fix Windows server path r=matklad a=lnicola CC @Coder-256. Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Laurențiu Nicola <[email protected]>
| * | do not truncate display for hoverBenjamin Coenen2020-05-061-2/+2
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | do not truncate display for hoverBenjamin Coenen2020-05-061-1/+42
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | Merge branch 'master' of github.com:rust-analyzer/rust-analyzer into fix_4311Benjamin Coenen2020-05-0614-89/+169
| |\ \
| * | | do not truncate display for hover #4311Benjamin Coenen2020-05-051-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | MinorAleksey Kladov2020-05-061-1/+2
| | | |
* | | | RenameAleksey Kladov2020-05-061-1/+1
| |_|/ |/| |
* | | Use SourceChange for assistsAleksey Kladov2020-05-062-49/+24
| | |
* | | Lift SourceChange to the ra_ide_dbAleksey Kladov2020-05-064-132/+11
| | |
* | | Fix capitalizationAleksey Kladov2020-05-061-2/+2
| |/ |/|
* | Fixup testsAleksey Kladov2020-05-057-30/+58
| |
* | Use more natural signature for Edit::applyAleksey Kladov2020-05-051-9/+15
| |
* | Rename AtomTextEdit -> IndelAleksey Kladov2020-05-052-4/+4
| |
* | Normalize naming of diagnosticsAleksey Kladov2020-05-054-13/+15
| |
* | Fix compilationAleksey Kladov2020-05-051-12/+7
| |
* | Merge #4320bors[bot]2020-05-051-0/+43
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4320: add doctest support r=matklad a=bnjjj close #4317 preview: <img width="253" alt="Capture d’écran 2020-05-05 à 17 39 58" src="https://user-images.githubusercontent.com/5719034/81086040-45110b80-8ef8-11ea-9c05-79c6fe400fc3.png"> Co-authored-by: Benjamin Coenen <[email protected]>
| * | add doctest support #4317Benjamin Coenen2020-05-051-0/+43
| |/ | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* / Rename ImplItem to AssocItemEdwin Cheng2020-05-052-21/+27
|/
* Remove false positive attr compleitonsAleksey Kladov2020-05-042-4/+40
|
* Qualify ast typesAleksey Kladov2020-05-041-6/+5
|
* Cleanup importsAleksey Kladov2020-05-041-4/+6
|
* Remove unnecessary conditionAleksey Kladov2020-05-041-17/+14
| | | | | | No tests fail, and quick manual testing shows that there are no false-positives. In general, each completion contributor should be independent from the others.
* Merge #4269 #4293bors[bot]2020-05-041-0/+33
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4269: add support of use alias semantic in definition r=matklad a=bnjjj close #4202 4293: no doctests for flycheck r=matklad a=matklad bors r+ 🤖 Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
| * add support of use alias semantic in definition #4202Benjamin Coenen2020-05-021-1/+16
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * Merge branch 'master' of github.com:rust-analyzer/rust-analyzer into fix_4202Benjamin Coenen2020-05-0211-67/+533
| |\
| * | wipBenjamin Coenen2020-05-011-0/+18
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | Fix focus range for TypeParamAleksey Kladov2020-05-042-8/+12
| | | | | | | | | | | | closes #4274
* | | Add test marksAleksey Kladov2020-05-042-5/+10
| | |
* | | Code review fixesKirill Bulatov2020-05-041-8/+7
| | | | | | | | | | | | Co-authored-by: Edwin Cheng <[email protected]>
* | | Move snake case method to heckKirill Bulatov2020-05-031-15/+2
| | |
* | | Omit name hints for enum names similar to parameter namesKirill Bulatov2020-05-031-12/+52
| | |
* | | Omit name hints for method names similar to parameter namesKirill Bulatov2020-05-031-13/+25
| | |
* | | Fix derive argument parsingKirill Bulatov2020-05-021-26/+40
| | |
* | | Separate macros completion from otherKirill Bulatov2020-05-021-15/+17
| | |
* | | Propose custom derives in completionKirill Bulatov2020-05-021-8/+32
| | |
* | | Complete standard derivesKirill Bulatov2020-05-022-16/+245
| |/ |/|
* | Introduce EffectExprAleksey Kladov2020-05-024-46/+38
| |
* | Test for unsafe traitDiana2020-05-011-0/+11
| |
* | Unsafe traitsDiana2020-05-011-1/+5
| |
* | Fix a bunch of false-positives in join-linesAleksey Kladov2020-04-301-0/+66
| |
* | Merge #4210bors[bot]2020-04-302-0/+65
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4210: Include function qualifiers in signature r=matklad a=oxalica Fixes #2450 It seems there's no test for `ra_ide/display/{short_label,function_signature}`. I'm not sure how to setup it. Manually tested: <img width="428" alt="Screenshot_20200430_004434" src="https://user-images.githubusercontent.com/14816024/80622769-d6f1c200-8a7b-11ea-91f3-e94bfb2703c5.png"> Co-authored-by: oxalica <[email protected]>
| * | Add tests of showing function qualifiersoxalica2020-04-301-0/+25
| | |
| * | Include function qualifiers in signatureoxalica2020-04-291-0/+40
| | |
* | | if let -> matchJonas Schievink2020-04-291-4/+3
| | |
* | | Complete assoc. items on type parametersJonas Schievink2020-04-291-11/+262
|/ /