aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide/src
Commit message (Collapse)AuthorAgeFilesLines
* SimplifyAleksey Kladov2020-02-224-171/+58
|
* Merge #3260bors[bot]2020-02-222-7/+7
|\ | | | | | | | | | | | | | | 3260: Refactor how builtins are resolved r=matklad a=flodiebold This fixes autocompletion suggesting e.g. `self::usize`. (I thought we had a bug for that, but I didn't find it.) Co-authored-by: Florian Diebold <[email protected]>
| * Refactor how builtins are resolvedFlorian Diebold2020-02-212-7/+7
| | | | | | | | This fixes autocompletion suggesting e.g. self::usize.
* | remove unneeded `collect`adamrk2020-02-211-11/+7
| |
* | use Vec::extend instead of Vec::push in loopAdam Bratschi-Kaye2020-02-211-3/+1
| | | | | | | | Co-Authored-By: Laurențiu Nicola <[email protected]>
* | rename module referencesadamrk2020-02-211-0/+112
|/
* Fix off by one in onEnterLaurențiu Nicola2020-02-201-1/+14
|
* Fill missing fields of enum variantsAleksey Kladov2020-02-191-0/+29
|
* Merge #3236bors[bot]2020-02-196-79/+68
|\ | | | | | | | | | | | | | | | | | | | | 3236: Merge NameDefinition and NameKind r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Merge NameDefinition and NameKindAleksey Kladov2020-02-196-79/+68
| |
* | Merge #3235bors[bot]2020-02-192-14/+11
|\| | | | | | | | | | | | | | | | | | | | | 3235: Derive visibility as well r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Derive visibility as wellAleksey Kladov2020-02-192-14/+11
| |
* | Merge #3234bors[bot]2020-02-192-16/+19
|\| | | | | | | | | | | | | | | | | | | | | 3234: Don't store deriveable Module info in NameDefinition r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Don't store deriveable Module info in NameDefinitionAleksey Kladov2020-02-192-16/+19
| |
* | Extend selection handles commas in tuple patsAleksey Kladov2020-02-191-0/+27
|/
* Merge #3228bors[bot]2020-02-191-9/+17
|\ | | | | | | | | | | | | | | | | | | | | | | 3228: Use proper range for hover on macro arguments r=matklad a=edwin0cheng This PR use `original_range` to remap the range of found syntax node in `hover` and thus it should return the proper text range now. fixed #3000 fixed #3135 Co-authored-by: Edwin Cheng <[email protected]>
| * Use proper range for hover on macro argumentsEdwin Cheng2020-02-191-9/+17
| |
* | CleanupShotaro Yamada2020-02-191-5/+1
| |
* | Fix a crash with non-ascii whitespace in doc-commentsShotaro Yamada2020-02-191-0/+17
|/
* Cleanup importsAleksey Kladov2020-02-181-22/+18
|
* Minor simplificationAleksey Kladov2020-02-181-6/+3
|
* More manual clippy fixesKirill Bulatov2020-02-187-18/+21
|
* ra_syntax: SyntaxError::range() now returns by valueVeetaha2020-02-171-1/+1
|
* ra_syntax: reshape SyntaxError for the sake of removing redundancyVeetaha2020-02-171-8/+2
|
* Merge #3169bors[bot]2020-02-171-6/+95
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3169: Show record field names in Enum completion r=flodiebold a=adamrk Adresses https://github.com/rust-analyzer/rust-analyzer/issues/2947. Previously the details shown when autocompleting an Enum variant would look like the variant was a tuple even if it was a record: ![2020-02-16-15:59:32_crop](https://user-images.githubusercontent.com/16367467/74607233-64f21980-50d7-11ea-99db-e973e29c71d7.png) This change will show the names of the fields for a record and use curly braces instead of parentheses: ![2020-02-16-15:33:00_crop](https://user-images.githubusercontent.com/16367467/74607251-8ce17d00-50d7-11ea-9d4d-38d198a4aec0.png) This required exposing the type `adt::StructKind` from `ra_hir` and adding a function ``` kind(self, db: &impl HirDatabase) -> StructKind ``` in the `impl` of `EnumVariant`. There was also a previously existing function `is_unit(self, db: &impl HirDatabase) -> bool` for `EnumVariant` which I removed because it seemed redundant after adding `kind`. Co-authored-by: adamrk <[email protected]>
| * add space before/after wrapping bracesadamrk2020-02-161-2/+2
| |
| * show names for record fields in enum completionadamrk2020-02-161-6/+95
| |
* | Merge #3099bors[bot]2020-02-172-0/+336
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3099: Init implementation of structural search replace r=matklad a=mikhail-m1 next steps: * ignore space and other minor difference * add support to ra_cli * call rust parser to check pattern * documentation original issue #2267 Co-authored-by: Mikhail Modin <[email protected]>
| * | Init implementation of structural search replaceMikhail Modin2020-02-142-0/+336
| |/
* | Merge #3108bors[bot]2020-02-173-0/+448
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3108: Magic Completion for `impl Trait for` Associated Items r=matklad a=kdelorey # Summary This PR adds a set of magic completions to auto complete associated trait items (functions/consts/types). ![Associated Trait Impl](https://user-images.githubusercontent.com/2295721/74493144-d8f1af00-4e96-11ea-93a4-82725bf89646.gif) ## Notes Since the assist and completion share the same logic when figuring out the associated items that are missing, a shared utility was created in the `ra_assists::utils` module. Resolves #1046 As this is my first PR to the rust-analyzer project, I'm new to the codebase, feedback welcomed! Co-authored-by: Kevin DeLorey <[email protected]>
| * | Added module doc comment to explain the purpose of the completion.Kevin DeLorey2020-02-151-1/+32
| | |
| * | Fixed bug that allowed for completion in a nested method.Kevin DeLorey2020-02-151-7/+36
| | |
| * | Reordered the `use` items.Kevin DeLorey2020-02-151-9/+8
| | |
| * | Adjusted the completion lookups to filter by just the name.Kevin DeLorey2020-02-141-29/+44
| | |
| * | Completion now replaces whole fn/const/type def with snippet.Kevin DeLorey2020-02-131-16/+31
| | |
| * | Cheese const tests as they requre an ident before becoming a CONST_DEF.Kevin DeLorey2020-02-131-28/+21
| | |
| * | Started to refactor the trigger of the trait_impl completion.Kevin DeLorey2020-02-131-33/+77
| | |
| * | Formatting.Kevin DeLorey2020-02-111-1/+3
| | |
| * | Fixing minor suggestions and added module level documentation.Kevin DeLorey2020-02-111-9/+6
| | |
| * | Removed doc comments entirely from the changes.Kevin DeLorey2020-02-111-39/+0
| | |
| * | Formatted changes.Kevin DeLorey2020-02-111-22/+16
| | |
| * | Removed docs from private method.Kevin DeLorey2020-02-111-8/+0
| | |
| * | Added tests to test associated types and consts.Kevin DeLorey2020-02-111-0/+78
| | |
| * | Added some documentation to the `complete_trait_impl` completion.Kevin DeLorey2020-02-111-1/+48
| | |
| * | Added associated const magic completion.Kevin DeLorey2020-02-101-11/+53
| | |
| * | Added a utility function that can be used to determine the missing impl items.Kevin DeLorey2020-02-092-115/+19
| | |
| * | Merge branch 'master' into kdelorey/complete-trait-implKevin DeLorey2020-02-0941-2293/+657
| |\ \
| * | | Added associated type completion.Kevin DeLorey2020-02-081-3/+15
| | | |
| * | | Cleaning up unessicary code that the Magic completion takes care of.Kevin DeLorey2020-02-081-39/+8
| | | |
| * | | Got the magic completion working.Kevin DeLorey2020-02-082-41/+16
| | | |