aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge #4596bors[bot]2020-05-271-1/+59
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example ![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png) Co-authored-by: Yuki Kodama <[email protected]>
| * | Trim at presentation layerYuki Kodama2020-05-252-4/+2
| | |
| * | Fix test to consider multiple underscoresYuki Kodama2020-05-251-7/+7
| | |
| * | Use built-in methodYuki Kodama2020-05-251-11/+5
| | |
| * | Separate assertionsYuki Kodama2020-05-251-7/+65
| | |
| * | Reflect test caseYuki Kodama2020-05-251-7/+7
| | |
| * | Strip leading underscoreYuki Kodama2020-05-251-2/+10
| | |
| | |
| \ \
*-. \ \ Merge #4625 #4629bors[bot]2020-05-271-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | | Fix the `should_panic` snippetAndrew Chin2020-05-261-3/+3
| |/ / / | | | | | | | | | | | | Closes #4628
* / / / Pass trivially copy types as copykjeremy2020-05-261-32/+29
|/ / /
* | | Merge #4534bors[bot]2020-05-261-0/+59
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4534: Add call postfix completion r=matklad a=vain0x To make it easier to wrap an expression with Ok/Some/Rc::new etc. Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use. Co-authored-by: vain0x <[email protected]>
| * | | Add call postfix completionvain0x2020-05-201-0/+59
| | | | | | | | | | | | | | | | To make it easier to wrap an expression with Ok/Some/Rc::new etc.
* | | | Hover tooltip module name is monospace once againAaron Loucks2020-05-262-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The line separator is moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues. Fixes #4594 Alternative to #4615
* | | | Fix some clippy perf warningsJeremy Kolb2020-05-251-4/+4
| |/ / |/| |
| | |
| \ \
*-. \ \ Merge #4602 #4603bors[bot]2020-05-253-4/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4602: Add boolean literal semantic token type to package.json r=matklad a=lnicola Closes #4583. CC @GrayJack 4603: Add self keyword semantic token type r=matklad a=lnicola Not sure if this is warranted a new token type or just a modifier. --- CC #4583, @GrayJack Co-authored-by: Laurențiu Nicola <[email protected]>
| | * | | Add self keyword semantic token typeLaurențiu Nicola2020-05-253-4/+7
| |/ / /
* / / / Less rust-analyzer specific onEnterAleksey Kladov2020-05-252-9/+5
|/ / /
* | | Handle more cases in `highlight_name_by_syntax`Matthew Jasper2020-05-241-11/+19
| | |
* | | Highlight `true` and `false` as literalsMatthew Jasper2020-05-247-1/+9
| | |
* | | Fix testsAleksey Kladov2020-05-241-25/+25
| | |
* | | Merge pull request #4548 from bnjjj/fix_4464Aleksey Kladov2020-05-241-12/+131
|\ \ \ | | | | | | | | add support of feature flag for runnables
| * | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-241-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-231-35/+41
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-221-11/+2
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-2115-90/+119
| |\ \ \ | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-211-13/+133
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | Merge pull request #4495 from vsrs/fixture_metaAleksey Kladov2020-05-242-21/+131
|\ \ \ \ \ | | | | | | | | | | | | Test fixtures parsing improvements
| * | | | | Propogate fixture meta to AnalysisHostvsrs2020-05-162-6/+54
| | | | | | | | | | | | | | | | | | | | | | | | Except crate name.
| * | | | | Use FixtureMeta in MockAnalysisvsrs2020-05-161-16/+77
| | | | | |
| * | | | | Remove temporary FixtureEntry parsed_meta field.vsrs2020-05-161-3/+4
| | | | | |
* | | | | | Merge pull request #4474 from georgewfraser/color_attrsAleksey Kladov2020-05-243-3/+9
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Color attribute functions
| * | | | | Color attribute functionsGeorge Fraser2020-05-193-3/+9
| | |/ / / | |/| | |
* | | | | Merge #4559bors[bot]2020-05-232-7/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4559: Module name on hover shows another newline after it r=matklad a=Arthamys This changes the display of hover information to add a newline between the module path of the item and the signature of the item, as suggested in #3813 **Before** ![before_3813](https://user-images.githubusercontent.com/11710698/82609224-5d517d80-9bbc-11ea-9a08-0a1558409c6b.png) **After** ![after_3813](https://user-images.githubusercontent.com/11710698/82609208-562a6f80-9bbc-11ea-8cb6-4430269c5800.png) Co-authored-by: Galilée 'Bill' Enguehard <[email protected]>
| * | | | | Update tests to accept new hover formattingGalilée 'Bill' Enguehard2020-05-221-4/+13
| | | | | |
| * | | | | Fix formatting error when no modpath is presentGalilée 'Bill' Enguehard2020-05-221-3/+3
| | | | | |
| * | | | | Modify hover info to show module path separated by a lineGalilée 'Bill' Enguehard2020-05-221-3/+3
| | | | | |
| * | | | | Merge branch 'master' of github.com:rust-analyzer/rust-analyzer into ↵Galilée 'Bill' Enguehard2020-05-2137-546/+1614
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | modname_spacing
| * | | | | | Add extra newline after module path in hover infoGalilée 'Bill' Enguehard2020-05-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes issue #3813
* | | | | | | KISS SourceChangeAleksey Kladov2020-05-225-86/+84
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The idea behind requiring the label is a noble one, but we are not really using it consistently anyway, and it should be easy to retrofit later, should we need it.
* | | | | | Formalize JoinLines protocol extensionAleksey Kladov2020-05-211-6/+3
| | | | | |
* | | | | | CleanupAleksey Kladov2020-05-213-34/+18
| | | | | |
* | | | | | Cleanup TextEditAleksey Kladov2020-05-213-6/+6
| | | | | |
* | | | | | Remove dead code for handling cursor positionsAleksey Kladov2020-05-213-6/+0
| | | | | |
* | | | | | Transition OnEnter to WorkspaceSnippetEditAleksey Kladov2020-05-211-16/+13
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also changes our handiling of snippet edits on the client side. `editor.insertSnippet` unfortunately forces indentation, which we really don't want to have to deal with. So, let's just implement our manual hacky way of dealing with a simple subset of snippets we actually use in rust-analyzer
* | | | | Remove unused cursor positionsAleksey Kladov2020-05-211-3/+0
| | | | |
* | | | | Remove unused cursor positionsAleksey Kladov2020-05-201-13/+7
| |_|_|/ |/| | |
* | | | Switch to new magic marksAleksey Kladov2020-05-208-52/+34
| | | |
* | | | Remove cross-crate marksAleksey Kladov2020-05-202-12/+1
| | | | | | | | | | | | | | | | | | | | They create quite a bit of friction. Really, we should just move the tests to the same crate, rather than paper over existing split.
* | | | Add AssistConfigAleksey Kladov2020-05-195-7/+12
| | | |
* | | | Fix doctests in an Impl blockCoenen Benjamin2020-05-171-1/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 00:57:24 +0000