aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide
Commit message (Collapse)AuthorAgeFilesLines
* Remove AdtOrTraitvsrs2020-06-182-17/+13
|
* Add associated type test.vsrs2020-06-181-0/+57
|
* Fix type "items" order.vsrs2020-06-181-17/+18
|
* Add `Go to Type Definition` hover action.vsrs2020-06-183-22/+800
|
* Remove special casing for library symbolsAleksey Kladov2020-06-182-6/+11
| | | | | | | | We might as well handle them internally, via queries. I am not sure, but it looks like the current LibraryData setup might even predate salsa? It's not really needed and creates a bunch of complexity.
* Syntax highlighting for escape sequences in stringsLeander Tentrup2020-06-1710-5/+36
|
*-. Merge #4913 #4915 #4916bors[bot]2020-06-173-4/+22
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4913: Remove debugging code for incremental sync r=matklad a=lnicola 4915: Inspect markdown code fences to determine whether to apply syntax highlighting r=matklad a=ltentrup Fixes #4904 4916: Warnings as hint or info r=matklad a=GabbeV Fixes #4229 This PR is my second attempt at providing a solution to the above issue. My last PR(#4721) had to be rolled back(#4862) due to it overriding behavior many users expected. This PR solves a broader problem while trying to minimize surprises for the users. ### Problem description The underlying problem this PR tries to solve is the mismatch between [Rustc lint levels](https://doc.rust-lang.org/rustc/lints/levels.html) and [LSP diagnostic severity](https://microsoft.github.io/language-server-protocol/specification#diagnostic). Rustc currently doesn't have a lint level less severe than warning forcing the user to disable warnings if they think they get to noisy. LSP however provides two severitys below warning, information and hint. This allows editors like VSCode to provide more fine grained control over how prominently to show different diagnostics. Info severity shows a blue squiggly underline in code and can be filtered separately from errors and warnings in the problems panel. ![image](https://user-images.githubusercontent.com/13839236/84830640-0bb8d900-b02a-11ea-9e2f-0561b0e8f1ef.png) ![image](https://user-images.githubusercontent.com/13839236/84826931-ffca1880-b023-11ea-8080-5e5b91a6ac0d.png) Hint severity doesn't show up in the problems panel at all and only show three dots under the affected code or just faded text if the diagnostic also has the unnecessary tag. ![image](https://user-images.githubusercontent.com/13839236/84827165-55062a00-b024-11ea-8bd6-bdbf1217c4c5.png) ### Solution The solution provided by this PR allows the user to configure lists of of warnings to report as info severity and hint severity respectively. I purposefully only convert warnings and not errors as i believe it's a good idea to have the editor show the same severity as the compiler as much as possible. ![image](https://user-images.githubusercontent.com/13839236/84829609-50437500-b028-11ea-80a8-1bbd05680ba7.png) ### Open questions #### Discoverability How do we teach this to new and existing users? Should a section be added to the user manual? If so where and what should it say? #### Defaults Other languages such as TypeScript report unused code as hint by default. Should rust-analyzer similarly report some problems as hint/info by default? Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Leander Tentrup <[email protected]> Co-authored-by: Gabriel Valfridsson <[email protected]>
| | * Inspect markdown code fences to determine whether to apply syntax highlightingLeander Tentrup2020-06-163-4/+22
| |/
* / Remove :expr from placeholdersDavid Lattimore2020-06-171-54/+20
|/ | | | Reasoning discussed at #3186
* Anchor file-system operations to the file, and not to the source root.Aleksey Kladov2020-06-162-62/+49
| | | | | | | | | | | | | | | | Anchoring to the SourceRoot wont' work if the path is absolute: #[path = "/tmp/foo.rs"] mod foo; Anchoring to a file will. However, we *should* anchor, instead of just producing an abs path. I can imagine a situation where, for example, rust-analyzer processes crates from different machines (or, for example, from in-memory git branch), where the same absolute path in different crates might refer to different files in the end!
* Syntactic highlighting of NAME_REF for injectionsLeander Tentrup2020-06-1512-16/+102
| | | | | | This commit adds a function that tries to determine the syntax highlighting class of NAME_REFs based on the usage. It is used for highlighting injections (such as highlighting of doctests) as the semantic logic will most of the time result in unresolved references. It also adds a color to unresolved references in HTML encoding.
* Merge #4877bors[bot]2020-06-153-16/+37
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4877: Fix syntax highlighting of recursive macros r=matklad a=ltentrup Add syntax highlighting for the BANG (`!`) token if the parent is `MACRO_CALL`. Before: <img width="514" alt="before" src="https://user-images.githubusercontent.com/201808/84595030-11f65c00-ae56-11ea-9bb2-b1abe2236990.png"> After: <img width="516" alt="recursive-macro" src="https://user-images.githubusercontent.com/201808/84594981-d196de00-ae55-11ea-8636-f877d5d795ff.png"> Fixes #4694. Co-authored-by: Leander Tentrup <[email protected]>
| * Fix syntax highlighting of recursive macrosLeander Tentrup2020-06-153-16/+37
| | | | | | | | Add syntax highlighting for the BANG (`!`) token if the parent is `MACRO_CALL`.
* | Deprecate hir::Path::from_astAleksey Kladov2020-06-151-0/+1
|/
* Merge #4868bors[bot]2020-06-131-4/+4
|\ | | | | | | | | | | | | | | | | | | | | 4868: Fix if and while postfix completions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix if and while postfix completionsAleksey Kladov2020-06-131-4/+4
| |
* | More concise completion testsAleksey Kladov2020-06-132-182/+146
| |
* | CleanupAleksey Kladov2020-06-134-255/+154
| |
* | Add keywords completions on source file positionMikhail Rakhmanov2020-06-133-21/+124
| |
* | Merge branch 'master' into keyword_completionMikhail Rakhmanov2020-06-1322-257/+1438
|\| | | | | | | | | # Conflicts: # docs/user/generated_features.adoc
| * simplify determining whether the field is a tuple fieldOptimalStrategy2020-06-121-5/+1
| |
| * Fix invalid shorthand initialization diagnostic for tuple structsOptimalStrategy2020-06-121-1/+18
| |
| * Merge #4849bors[bot]2020-06-111-34/+22
| |\ | | | | | | | | | | | | | | | | | | | | | 4849: Make known paths use `core` instead of `std` r=matklad a=jonas-schievink I'm not sure if this causes problems today, but it seems like it easily could, if rust-analyzer processes the libstd sources for the right `--target` and that target is a `#![no_std]`-only target. Co-authored-by: Jonas Schievink <[email protected]>
| | * Update wrap return testsJonas Schievink2020-06-111-29/+17
| | | | | | | | | | | | Update "no diagnostic" tests, use `()` instead of `String`
| | * Make known paths use `core` instead of `std`Jonas Schievink2020-06-111-9/+9
| | |
| * | Indent chain `.` even if there's more stuff afterwardsAleksey Kladov2020-06-111-6/+32
| |/
| * In field patterns, don't highlight local binding as a fieldAleksey Kladov2020-06-102-13/+17
| |
| * SimplifyAleksey Kladov2020-06-084-9/+9
| |
| * Better unsafe highlihgting testsAleksey Kladov2020-06-088-9/+16
| |
| * Highlight only the unsafe operator itselfAleksey Kladov2020-06-081-6/+2
| |
| * Merge #4775bors[bot]2020-06-082-2/+25
| |\ | | | | | | | | | | | | | | | | | | | | | 4775: Add goto def for enum variant field r=matklad a=unexge Closes #4764. I'm not familiar with ra codebase, there might be better ways to do that :smile: Co-authored-by: unexge <[email protected]>
| | * Use explicit match for extracting def from `classify_name`unexge2020-06-081-2/+5
| | |
| | * Add `FieldShorthand` variant to `NameClass`unexge2020-06-082-1/+2
| | |
| | * Add goto def for enum variant fieldunexge2020-06-061-0/+19
| | |
| * | Merge #4683bors[bot]2020-06-084-46/+368
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4683: Implement syntax highlighting for doctests r=ltentrup a=ltentrup The implementation is more complicated than the previous injection logic as the doctest comments consist of multiple ranges. The implementation extracts the doctests together with an offset-mapping, applies the syntax highlighting, and updates the text ranges. <img width="478" alt="Bildschirmfoto 2020-06-01 um 15 45 25" src="https://user-images.githubusercontent.com/201808/83415249-1f0b5800-a41f-11ea-8fa6-c282434d6ff7.png"> Part of #4170. Co-authored-by: Leander Tentrup <[email protected]>
| | * | Implement syntax highlighting for doctestsLeander Tentrup2020-06-084-46/+368
| | | |
| * | | Merge #4773bors[bot]2020-06-082-9/+225
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4773: Run|Debug hover actions. r=matklad a=vsrs ![hover_actions_run](https://user-images.githubusercontent.com/62505555/83335644-dfc1f780-a2b6-11ea-820b-ccaa82290e7d.gif) This hover actions work exactly like corresponding lenses. Co-authored-by: vsrs <[email protected]>
| | * | Apply suggestions from code reviewvsrs2020-06-081-4/+8
| | | |
| | * | Disable runnables lookup in macro-generated code.vsrs2020-06-061-1/+10
| | | |
| | * | Add Run|Debug hover actionsvsrs2020-06-062-9/+134
| | | |
| | * | Preliminary runnables refactoringvsrs2020-06-061-0/+78
| | |/
| * | Merge #4781bors[bot]2020-06-081-32/+27
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4781: Remove redundancy in syntax highlighting tests r=matklad a=ltentrup Follow up from #4683. Improves syntax highlighting testing by introducing a function that contains the boilerplate comparison code. Keeps the `ra_fixture` argument in the first position, thus, the editor syntax highlighting injection still works. Co-authored-by: Leander Tentrup <[email protected]>
| | * | Remove redundancy in syntax highlighting testsLeander Tentrup2020-06-071-32/+27
| | |/
| * / Fix bug in lexer for format specifier where the `type` and `width` were not ↵Leander Tentrup2020-06-071-1/+1
| |/ | | | | | | correctly distinguished
| * Fix type parameter defaultsFlorian Diebold2020-06-052-3/+3
| | | | | | | | | | They should not be applied in expression or pattern contexts, unless there are other explicitly given type args.
| *-. Merge #4729 #4748bors[bot]2020-06-052-13/+137
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4729: Hover actions r=matklad a=vsrs This PR adds a `hoverActions` LSP extension and a `Go to Implementations` action as an example: ![hover_actions_impl](https://user-images.githubusercontent.com/62505555/83335732-6d9de280-a2b7-11ea-8cc3-75253d062fe0.gif) 4748: Add an `ImportMap` and use it to resolve item paths in `find_path` r=matklad a=jonas-schievink Removes the "go faster" queries I added in https://github.com/rust-analyzer/rust-analyzer/pull/4501 and https://github.com/rust-analyzer/rust-analyzer/pull/4506. I've checked this PR on the rustc code base and the assists are still fast. This should fix https://github.com/rust-analyzer/rust-analyzer/issues/4515. Note that this does introduce a change in behavior: We now always refer to items defined in external crates using paths through the external crate. Previously we could also use a local path (if for example the extern crate was reexported locally), as seen in the changed test. If that is undesired I can fix that, but the test didn't say why the previous behavior would be preferable. Co-authored-by: vsrs <[email protected]> Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * | Add enum hover action test.vsrs2020-06-051-0/+15
| | | |
| | * | Rebase on the latest master.vsrs2020-06-051-3/+3
| | | |
| | * | Code formattingvsrs2020-06-052-4/+3
| | | |
| | * | Add hover actions as LSP extensionvsrs2020-06-052-13/+123
| | |/
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-23 21:20:42 +0000