aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_ide
Commit message (Collapse)AuthorAgeFilesLines
* Removed doc comments entirely from the changes.Kevin DeLorey2020-02-111-39/+0
|
* Formatted changes.Kevin DeLorey2020-02-111-22/+16
|
* Removed docs from private method.Kevin DeLorey2020-02-111-8/+0
|
* Added tests to test associated types and consts.Kevin DeLorey2020-02-111-0/+78
|
* Added some documentation to the `complete_trait_impl` completion.Kevin DeLorey2020-02-111-1/+48
|
* Added associated const magic completion.Kevin DeLorey2020-02-101-11/+53
|
* Added a utility function that can be used to determine the missing impl items.Kevin DeLorey2020-02-092-115/+19
|
* Merge branch 'master' into kdelorey/complete-trait-implKevin DeLorey2020-02-0942-2294/+659
|\
| * Simplify Assists interfaceAleksey Kladov2020-02-091-18/+6
| | | | | | | | | | Instead of building a physical tree structure, just "tag" related assists with the same group
| * Remove hard-coded auto-import during completionAleksey Kladov2020-02-091-128/+3
| | | | | | | | We now have a real auto-import system, so we can do a proper thing.
| * Rename add import assistKirill Bulatov2020-02-071-7/+2
| |
| * RenameAleksey Kladov2020-02-074-18/+18
| |
| * Remove irrelevant distinctionAleksey Kladov2020-02-075-20/+18
| |
| * Minor renameAleksey Kladov2020-02-061-2/+2
| |
| * Mostly remove ImoportLocator infraAleksey Kladov2020-02-061-1/+1
| |
| * Make assists use ImportsLocator directlyAleksey Kladov2020-02-061-2/+2
| |
| * Move imports locator to ide_dbAleksey Kladov2020-02-063-78/+2
| |
| * Move NameKind upAleksey Kladov2020-02-065-253/+57
| |
| * SimplifyAleksey Kladov2020-02-061-3/+4
| |
| * Tweak goto parent moduleAleksey Kladov2020-02-062-1/+37
| |
| * CleanupAleksey Kladov2020-02-061-0/+74
| |
| * cleanup importsAleksey Kladov2020-02-0630-99/+101
| |
| * Move to a crateAleksey Kladov2020-02-069-1677/+4
| |
| * Move change to ide-dbAleksey Kladov2020-02-063-5/+5
| |
| * Fix test importsAleksey Kladov2020-02-061-2/+4
| |
| * Move QueryAleksey Kladov2020-02-062-41/+42
| |
| * Move symbol_indexAleksey Kladov2020-02-067-12/+16
| |
| * Move FeatureFlagsAleksey Kladov2020-02-063-4/+3
| |
| * Move line_indexAleksey Kladov2020-02-064-7/+12
| |
| * Move ide-dbAleksey Kladov2020-02-062-132/+132
| |
| * Start ide_dbAleksey Kladov2020-02-062-0/+3
| |
| * Apply the reviews suggestionsKirill Bulatov2020-02-051-2/+4
| |
| * minor, if let else -> matchAleksey Kladov2020-02-041-6/+3
| |
| * ra_syntax: refactored the lexer design as per @matklad and @kiljacken PR reviewVeetaha2020-02-031-2/+4
| |
| * Reimplemented lexer with vectors instead of iteratorsVeetaha2020-02-031-6/+4
| |
| * Fix inlay hints test snippet compilationKirill Bulatov2020-02-031-8/+8
| |
| * Avoid premature pessimizationAleksey Kladov2020-02-021-0/+2
| | | | | | | | | | | | The extra allocation for message should not matter here at all, but using a static string is just as ergonomic, if not more, and there's no reason to write deliberately slow code
| * Code review fixesKirill Bulatov2020-02-021-15/+11
| |
| * Require ModPath for importingKirill Bulatov2020-02-021-24/+47
| |
| * Re-sync queries for memory usage measurnmentAleksey Kladov2020-01-291-11/+40
| |
| * Improves reference search by StructLiteralMikhail Modin2020-01-271-27/+111
| |
| * Merge #2883bors[bot]2020-01-274-111/+208
| |\ | | | | | | | | | | | | | | | | | | | | | 2883: Implement Syntax Highlight inside macro call r=matklad a=edwin0cheng Co-authored-by: Edwin Cheng <[email protected]>
| | * Implement Syntax Highlight inside MacroEdwin Cheng2020-01-204-111/+208
| | |
| * | Merge #2887bors[bot]2020-01-273-3/+81
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2887: Initial auto import action implementation r=matklad a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/2180 Adds an auto import action implementation. This implementation is not ideal and has a few limitations: * The import search functionality should be moved into a separate crate accessible from ra_assists. This requires a lot of changes and a preliminary design. Currently the functionality is provided as a trait impl, more on that here: https://github.com/rust-analyzer/rust-analyzer/issues/2180#issuecomment-575690942 * Due to the design desicion from the previous item, no doctests are run for the new aciton (look for a new FIXME in the PR) * For the same reason, I have to create the mock trait implementaion to test the assist * Ideally, I think we should have this feature as a diagnostics (that detects an absense of an import) that has a corresponding quickfix action that gets evaluated on demand. Curretly we perform the import search every time we resolve the import which looks suboptimal. This requires `classify_name_ref` to be moved from ra_ide, so not done currently. A few improvements to the imports mechanism to be considered later: * Constants like `ra_syntax::SyntaxKind::NAME` are not imported, because they are not present in the database * Method usages are not imported, they are found in the database, but `find_use_path` does not return any import paths for them * Some import paths returned by the `find_use_path` method end up in `core::` or `alloc::` instead of `std:`, for example: `core::fmt::Debug` instead of `std::fmt::Debug`. This is not an error techically, but still looks weird. * No detection of cases where a trait should be imported in order to be able to call a method * Improve `auto_import_text_edit` functionality: refactor it and move away from the place it is now, add better logic for merging the new import with already existing imports Co-authored-by: Kirill Bulatov <[email protected]>
| | * | Code review fixesKirill Bulatov2020-01-271-1/+1
| | | |
| | * | Have a better trait interfaceKirill Bulatov2020-01-261-46/+24
| | | |
| | * | Raise the import search query capKirill Bulatov2020-01-261-2/+3
| | | |
| | * | Remove unnecessary lifetime parameterKirill Bulatov2020-01-261-1/+1
| | | |
| | * | Initial auto import action implementationKirill Bulatov2020-01-263-3/+102
| | | |
| * | | Update cratesJeremy Kolb2020-01-261-1/+1
| |/ /