Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use proper inlay kinds | Kirill Bulatov | 2019-08-04 | 2 | -14/+2 |
| | |||||
* | remove-comment | kjeremy | 2019-07-31 | 1 | -1/+0 |
| | |||||
* | Add explicit newline preserving tests | kjeremy | 2019-07-31 | 1 | -0/+6 |
| | |||||
* | Fixed review comments | Roman Stoliar | 2019-07-30 | 1 | -3/+9 |
| | |||||
* | Hide comments in rust section of doc comments | Roman Stoliar | 2019-07-30 | 3 | -5/+21 |
| | |||||
* | Support destructuring patterns | Kirill Bulatov | 2019-07-28 | 2 | -0/+6 |
| | |||||
* | Improve inlay hinting for types | Kirill Bulatov | 2019-07-26 | 2 | -0/+4 |
| | | | | | | Add hints for types in for loop expressions. Resolve types for every tuple parameter. Refactor the code. | ||||
* | Make Analysis api cancellable | Kirill Bulatov | 2019-07-25 | 3 | -37/+48 |
| | |||||
* | Code review fixes | Kirill Bulatov | 2019-07-22 | 3 | -1/+50 |
| | |||||
* | Do not show the lens with type hints | Kirill Bulatov | 2019-07-21 | 1 | -13/+4 |
| | |||||
* | Resolve types on the server | Kirill Bulatov | 2019-07-21 | 1 | -25/+10 |
| | |||||
* | Refactor server api | Kirill Bulatov | 2019-07-20 | 1 | -28/+42 |
| | |||||
* | If possible, show type lenses for the let bindings | Kirill Bulatov | 2019-07-20 | 1 | -16/+26 |
| | |||||
* | Add "Run" lens for binary runnables | Kirill Bulatov | 2019-07-16 | 1 | -1/+1 |
| | |||||
* | Remove executeCommandProvider: apply_code_action. | Michael Bolin | 2019-07-11 | 2 | -10/+8 |
| | | | | | | | | | | | | | | | | | | | This appears to have been introduced ages ago in https://github.com/rust-analyzer/rust-analyzer/commit/be742a587704f27f4e503c50f549aa9ec1527fcc but has since been removed. As it stands, it is problematic if multiple instances of the rust-analyzer LSP are launched during the same VS Code session because VS Code complains about multiple LSP servers trying to register the same command. Most LSP servers workaround this by parameterizing the command by the process id. For example, this is where `rls` does this: https://github.com/rust-lang/rls/blob/ff0b9057c8f62bc4f8113d741e96c9587ef1a817/rls/src/server/mod.rs#L413-L421 Though `apply_code_action` does not seems to be used, so it seems better to delete it than to parameterize it. | ||||
* | Ignore workspace/didChangeConfiguration notifications. | Michael Bolin | 2019-07-11 | 2 | -4/+11 |
| | |||||
* | don't send LocationLink unless the client opts-in | Aleksey Kladov | 2019-07-08 | 4 | -9/+41 |
| | | | | closes #1474 | ||||
* | simplify | Aleksey Kladov | 2019-07-08 | 2 | -23/+20 |
| | |||||
* | add try_conv_with_to_vec | Aleksey Kladov | 2019-07-08 | 2 | -40/+54 |
| | |||||
* | Simplify responses by using into() | Jeremy Kolb | 2019-07-07 | 1 | -11/+12 |
| | |||||
* | use flatten branch of lsp-types | Jeremy Kolb | 2019-07-07 | 1 | -23/+12 |
| | |||||
* | Formatting again | Jeremy Kolb | 2019-07-05 | 1 | -5/+5 |
| | |||||
* | Symplify by using into() | Jeremy Kolb | 2019-07-05 | 1 | -3/+3 |
| | |||||
* | Formatting | Jeremy Kolb | 2019-07-04 | 1 | -1/+3 |
| | |||||
* | Some clippy fixes for 1.36 | Jeremy Kolb | 2019-07-04 | 2 | -5/+4 |
| | |||||
* | Fix formatting | Jeremy Kolb | 2019-07-04 | 1 | -5/+5 |
| | |||||
* | Change default() | Jeremy Kolb | 2019-07-04 | 1 | -1/+1 |
| | |||||
* | Update to lsp-types 0.58.0 | Jeremy Kolb | 2019-07-04 | 1 | -5/+5 |
| | |||||
* | allow rustfmt to reorder imports | Aleksey Kladov | 2019-07-04 | 11 | -45/+44 |
| | | | | | | This wasn't a right decision in the first place, the feature flag was broken in the last rustfmt release, and syntax highlighting of imports is more important anyway | ||||
* | Swallow expected `rustfmt` errors | Ryan Cumming | 2019-06-26 | 1 | -10/+25 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My workflow in Visual Studio Code + Rust Analyzer has become: 1. Make a change to Rust source code using all the analysis magic 2. Save the file to trigger `cargo watch`. I have format on save enabled for all file types so this also runs `rustfmt` 3. Fix any diagnostics that `cargo watch` finds Unfortunately if the Rust source has any syntax errors the act of saving will pop up a scary "command has failed" message and will switch to the "Output" tab to show the `rustfmt` error and exit code. I did a quick survey of what other Language Servers do in this case. Both the JSON and TypeScript servers will swallow the error and return success. This is consistent with how I remember my workflow in those languages. The syntax error will show up as a diagnostic so it should be clear why the file isn't formatting. I checked the `rustfmt` source code and while it does distinguish "parse errors" from "operational errors" internally they both result in exit status of 1. However, more catastrophic errors (missing `rustfmt`, SIGSEGV, etc) will return 127+ error codes which we can distinguish from a normal failure. This changes our handler to log an info message and feign success if `rustfmt` exits with status 1. Another option I considered was only swallowing the error if the formatting request came from format-on-save. However, the Language Server Protocol doesn't seem to distinguish those cases. | ||||
* | reuse AnalysisHost in batch analysis | Aleksey Kladov | 2019-06-15 | 1 | -1/+1 |
| | |||||
* | re-enable backtraces on panic | Aleksey Kladov | 2019-06-15 | 1 | -2/+1 |
| | |||||
* | cargo format | Muhammad Mominul Huque | 2019-06-15 | 1 | -7/+2 |
| | |||||
* | Get rid of failure: ra_lsp_server & ra_project_model | Muhammad Mominul Huque | 2019-06-14 | 4 | -21/+25 |
| | |||||
* | Temp fix for slow onEnter issue | Aleksey Kladov | 2019-06-13 | 1 | -1/+2 |
| | | | | | | | | | | The issue was windows specific -- cancellation caused collection of bracktraces at some point, and that was slow on windows. The proper fix here is to make sure that we don't collect bracktraces unnecessary (which we currently do due to failure), but, as a temporary fix, let's just not force their collection in the first place! | ||||
* | make LRU cache configurable | Aleksey Kladov | 2019-06-12 | 3 | -6/+18 |
| | |||||
* | make Docs handing more ideomatic | Aleksey Kladov | 2019-06-08 | 2 | -17/+8 |
| | |||||
* | Fix clippy::or_fun_call | Alan Du | 2019-06-04 | 1 | -1/+1 |
| | |||||
* | Fix clippy::identity_conversion | Alan Du | 2019-06-04 | 3 | -20/+15 |
| | |||||
* | rename | Aleksey Kladov | 2019-06-01 | 6 | -80/+86 |
| | |||||
* | move subs inside | Aleksey Kladov | 2019-06-01 | 1 | -4/+2 |
| | |||||
* | use sync queries for join lines and friends | Aleksey Kladov | 2019-05-31 | 1 | -5/+11 |
| | |||||
* | add sync requests | Aleksey Kladov | 2019-05-31 | 2 | -43/+56 |
| | |||||
* | cleanup | Aleksey Kladov | 2019-05-31 | 1 | -39/+42 |
| | |||||
* | cleanup | Aleksey Kladov | 2019-05-31 | 1 | -35/+48 |
| | |||||
* | simplify | Aleksey Kladov | 2019-05-31 | 1 | -51/+52 |
| | |||||
* | move completed requests to a separate file | Aleksey Kladov | 2019-05-31 | 5 | -80/+114 |
| | |||||
* | simplify | Aleksey Kladov | 2019-05-31 | 1 | -3/+3 |
| | |||||
* | introduce constant | Aleksey Kladov | 2019-05-31 | 1 | -7/+13 |
| | |||||
* | minor | Aleksey Kladov | 2019-05-31 | 1 | -1/+1 |
| |