aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_lsp_server
Commit message (Collapse)AuthorAgeFilesLines
* Make Analysis api cancellableKirill Bulatov2019-07-253-37/+48
|
* Merge #1549bors[bot]2019-07-233-1/+50
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1549: Show type lenses for the resolved let bindings r=matklad a=SomeoneToIgnore Types that are fully unresolved are not displayed: <img width="279" alt="image" src="https://user-images.githubusercontent.com/2690773/61518122-8e4ba980-aa11-11e9-9249-6d9f9b202e6a.png"> A few concerns that I have about the current implementation: * I've adjusted the `file_structure` API method to return the information about the `let` bindings. Although it works fine, I have a feeling that adding a new API method would be the better way. But this requires some prior discussion, so I've decided to go for an easy way with an MVP. Would be nice to hear your suggestions. * There's a hardcoded `{undersolved}` check that I was forced to use, since the method that resolves types returns a `String`. Is there a better typed API I can use? This will help, for instance, to add an action to the type lenses that will allow us to navigate to the type. Co-authored-by: Kirill Bulatov <[email protected]>
| * Code review fixesKirill Bulatov2019-07-223-1/+50
| |
| * Do not show the lens with type hintsKirill Bulatov2019-07-211-13/+4
| |
| * Resolve types on the serverKirill Bulatov2019-07-211-25/+10
| |
| * Refactor server apiKirill Bulatov2019-07-201-28/+42
| |
| * If possible, show type lenses for the let bindingsKirill Bulatov2019-07-201-16/+26
| |
* | flexi_logger 0.14kjeremy2019-07-221-1/+1
|/
* Add "Run" lens for binary runnablesKirill Bulatov2019-07-161-1/+1
|
* cargo updatekjeremy2019-07-151-1/+1
|
* Remove executeCommandProvider: apply_code_action.Michael Bolin2019-07-112-10/+8
| | | | | | | | | | | | | | | | | | | This appears to have been introduced ages ago in https://github.com/rust-analyzer/rust-analyzer/commit/be742a587704f27f4e503c50f549aa9ec1527fcc but has since been removed. As it stands, it is problematic if multiple instances of the rust-analyzer LSP are launched during the same VS Code session because VS Code complains about multiple LSP servers trying to register the same command. Most LSP servers workaround this by parameterizing the command by the process id. For example, this is where `rls` does this: https://github.com/rust-lang/rls/blob/ff0b9057c8f62bc4f8113d741e96c9587ef1a817/rls/src/server/mod.rs#L413-L421 Though `apply_code_action` does not seems to be used, so it seems better to delete it than to parameterize it.
* Ignore workspace/didChangeConfiguration notifications.Michael Bolin2019-07-112-4/+11
|
* Remove unused dependenciesShotaro Yamada2019-07-081-1/+0
|
* don't send LocationLink unless the client opts-inAleksey Kladov2019-07-085-12/+62
| | | | closes #1474
* simplifyAleksey Kladov2019-07-082-23/+20
|
* add try_conv_with_to_vecAleksey Kladov2019-07-082-40/+54
|
* Simplify responses by using into()Jeremy Kolb2019-07-072-12/+13
|
* use flatten branch of lsp-typesJeremy Kolb2019-07-073-26/+17
|
* Formatting againJeremy Kolb2019-07-051-5/+5
|
* Symplify by using into()Jeremy Kolb2019-07-051-3/+3
|
* FormattingJeremy Kolb2019-07-041-1/+3
|
* Some clippy fixes for 1.36Jeremy Kolb2019-07-042-5/+4
|
* Fix formattingJeremy Kolb2019-07-041-5/+5
|
* Change default()Jeremy Kolb2019-07-041-1/+1
|
* Update to lsp-types 0.58.0Jeremy Kolb2019-07-042-6/+6
|
* allow rustfmt to reorder importsAleksey Kladov2019-07-0413-58/+52
| | | | | | This wasn't a right decision in the first place, the feature flag was broken in the last rustfmt release, and syntax highlighting of imports is more important anyway
* Move memory usage statistics to ra_profAleksey Kladov2019-06-301-1/+1
|
* Swallow expected `rustfmt` errorsRyan Cumming2019-06-261-10/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My workflow in Visual Studio Code + Rust Analyzer has become: 1. Make a change to Rust source code using all the analysis magic 2. Save the file to trigger `cargo watch`. I have format on save enabled for all file types so this also runs `rustfmt` 3. Fix any diagnostics that `cargo watch` finds Unfortunately if the Rust source has any syntax errors the act of saving will pop up a scary "command has failed" message and will switch to the "Output" tab to show the `rustfmt` error and exit code. I did a quick survey of what other Language Servers do in this case. Both the JSON and TypeScript servers will swallow the error and return success. This is consistent with how I remember my workflow in those languages. The syntax error will show up as a diagnostic so it should be clear why the file isn't formatting. I checked the `rustfmt` source code and while it does distinguish "parse errors" from "operational errors" internally they both result in exit status of 1. However, more catastrophic errors (missing `rustfmt`, SIGSEGV, etc) will return 127+ error codes which we can distinguish from a normal failure. This changes our handler to log an info message and feign success if `rustfmt` exits with status 1. Another option I considered was only swallowing the error if the formatting request came from format-on-save. However, the Language Server Protocol doesn't seem to distinguish those cases.
* Bump cargo_metadata, ena, flexi_loggerkjeremy2019-06-201-1/+1
|
* reuse AnalysisHost in batch analysisAleksey Kladov2019-06-151-1/+1
|
* re-enable backtraces on panicAleksey Kladov2019-06-151-2/+1
|
* cargo formatMuhammad Mominul Huque2019-06-151-7/+2
|
* Get rid of failure: ra_lsp_server & ra_project_modelMuhammad Mominul Huque2019-06-145-23/+25
|
* Temp fix for slow onEnter issueAleksey Kladov2019-06-131-1/+2
| | | | | | | | | | The issue was windows specific -- cancellation caused collection of bracktraces at some point, and that was slow on windows. The proper fix here is to make sure that we don't collect bracktraces unnecessary (which we currently do due to failure), but, as a temporary fix, let's just not force their collection in the first place!
* make LRU cache configurableAleksey Kladov2019-06-123-6/+18
|
* make Docs handing more ideomaticAleksey Kladov2019-06-082-17/+8
|
* Fix clippy::or_fun_callAlan Du2019-06-041-1/+1
|
* Fix clippy::identity_conversionAlan Du2019-06-043-20/+15
|
* Fix clippy::unused_mutAlan Du2019-06-041-1/+1
|
* Fix clippy::unnecessary_mut_passedAlan Du2019-06-041-7/+2
|
* Fix clippy::single_matchAlan Du2019-06-041-4/+3
|
* renameAleksey Kladov2019-06-016-80/+86
|
* move subs insideAleksey Kladov2019-06-011-4/+2
|
* use sync queries for join lines and friendsAleksey Kladov2019-05-311-5/+11
|
* add sync requestsAleksey Kladov2019-05-312-43/+56
|
* cleanupAleksey Kladov2019-05-311-39/+42
|
* cleanupAleksey Kladov2019-05-311-35/+48
|
* simplifyAleksey Kladov2019-05-311-51/+52
|
* move completed requests to a separate fileAleksey Kladov2019-05-315-80/+114
|
* simplifyAleksey Kladov2019-05-311-3/+3
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-27 02:34:26 +0000