aboutsummaryrefslogtreecommitdiff
path: root/crates/rust-analyzer/src/diagnostics
Commit message (Collapse)AuthorAgeFilesLines
* simplifyLukas Wirth2021-06-172-2/+2
|
* clippy::redudant_borrowMaan20032021-06-131-3/+3
|
* Update test fixturesLaurențiu Nicola2021-05-2410-0/+56
|
* Code review feedback.James Leitch2021-04-211-4/+6
|
* Diagnostic Remap Path Prefixes added.James Leitch2021-04-211-35/+32
|
* Diagnostic paths attempt to use VSCode's path join behavior before ↵James Leitch2021-04-211-3/+30
| | | | defaulting to Rust's path join behavior.
* Prevent being able to rename items that are not part of the workspaceLukas Wirth2021-04-186-0/+6
|
* Check for and skip dummy macro filesJonas Schievink2021-04-012-120/+16
|
* Adjust message when pointing at location in macroJonas Schievink2021-04-011-2/+10
|
* Search for a suitable primary locationJonas Schievink2021-03-311-9/+27
|
* Rename `convert_location` -> `location`Jonas Schievink2021-03-311-11/+11
|
* Improve rustc diagnostic mappingJonas Schievink2021-03-303-49/+272
|
* don't clone types that are copy (clippy::clone_on_copy)Matthias Krüger2021-03-171-1/+1
|
* Bump cargo_metadataLaurențiu Nicola2021-03-021-1/+1
|
* Update testsJeremy Kolb2021-02-2010-0/+104
|
* Update Test DataChristopher Serr2021-02-011-1/+46
|
* Don't filter code suggestions on ApplicabilityChristopher Serr2021-02-011-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed that there are various suggestions that rust-analyzer seems to filter out, even if they make sense. Here's an example of where it seems like there should be a suggestion, but there isn't: ![https://i.imgur.com/wsjM6iz.png](https://i.imgur.com/wsjM6iz.png) It turns out that this specific suggestion is not considered `MachineApplicable`, which are the only suggestions that rust-analyzer accepts. However if you read the documentation for `MachineApplicable`, https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L27-L29 then you realize that these are specifically only those suggestions that rust-analyzer could even automatically apply (in some distant future, behind some setting or so). Other suggestions that may have some semantic impact do not use `MachineApplicable`. So all other suggestions are still intended to be suggested to the user, just not automatically applied without the user being consulted. https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L22-L24 So with that in mind, rust-analyzer should almost definitely not filter out `MaybeIncorrect` (which honestly is named horribly, it just means that it's a semantic change, not just a syntactical one). Then there's `HasPlaceholders` which basically is just another semantic one, but with placeholders. The user will have to make some adjustments, but the suggestion still is perfectly valid. rust-analyzer could probably detect those placeholders and put proper "tab through" markers there for the IDE, but that's not necessary for now. Then the last one is `Unspecified` which is so unknown that I don't even know how to judge it, meaning that the suggestion should probably also just be suggested to the user and then they can decide. So with all that in mind, I'm proposing to get rid of the check for Applicability entirely.
* Don't duplicate rustc diagnostics fixesJonas Schievink2021-01-155-282/+32
|
* Filter out empty rustc spansJonas Schievink2020-12-211-0/+4
|
* Apply suggestions from code reviewJonas Schievink2020-12-062-2/+2
| | | Co-authored-by: Laurențiu Nicola <[email protected]>
* Update expect testsJonas Schievink2020-12-067-46/+977
|
* Emit additional diagnostics for hints/help/etcJonas Schievink2020-12-061-73/+116
|
* update diagnostics test_data with code_description changesLukas Wirth2020-11-186-6/+108
|
* Link clippy lint codes in diagnosticsLukas Wirth2020-11-181-7/+22
|
* Link rustc error codes in diagnosticsLukas Wirth2020-11-181-3/+19
|
* Latest LSP 3.16 protocolkjeremy2020-11-161-2/+2
| | | | Pulls in https://github.com/gluon-lang/lsp-types/pull/186
* Update testsAleksey Kladov2020-11-1210-21/+168
|
* Switch to upstream protocol for resolving code actionAleksey Kladov2020-11-105-5/+5
| | | | | | Note that we have to maintain custom implementation on the client side: I don't see how to marry bulitin resolve support with groups and snippets.
* Update testsJeremy A. Kolb2020-10-2610-0/+22
|
* Latest proposed LSP 3.16.0kjeremy2020-10-261-0/+4
| | | | Needs: https://github.com/gluon-lang/lsp-types/pull/183
* Highlight errors in macrosIgor Aleksanov2020-09-062-7/+89
|
* :arrow_up: expect-testAleksey Kladov2020-08-2811-10/+595
|
* Switch to expect_test from crates.ioAleksey Kladov2020-08-211-1/+1
|
* Align diagnostics config with the rest of rust-analyzerAleksey Kladov2020-08-181-9/+9
|
* Rename ra_hir_def -> hir_defAleksey Kladov2020-08-131-6/+6
|
* Mark machine applicable fixes as preferredJeremy Kolb2020-07-161-0/+1
| | | | | | | This allows us to run the auto fix command from vscode to automatically fix all diagnostics in the file. They are also distinguished in the UI.
* Update lsp-types to account for new CodeActionKind structureJeremy Kolb2020-07-111-1/+1
|
* Make sure there are no commands in code actionsAleksey Kladov2020-07-111-1/+0
|
* Always put config firstAleksey Kladov2020-07-091-1/+0
|
* Move diagnostics tests to expectAleksey Kladov2020-07-0911-680/+49
|
* SimplifyAleksey Kladov2020-07-0911-132/+12
|
* Cleanup diagnostic conversion codeAleksey Kladov2020-07-091-102/+71
|
* CleanupAleksey Kladov2020-06-261-3/+3
|
* Rename ra_flycheck -> flycheckAleksey Kladov2020-06-251-9/+10
|
* Warnings as hint or infoGabriel Valfridsson2020-06-163-13/+372
|
* Merge #4867bors[bot]2020-06-131-69/+4
|\ | | | | | | | | | | | | | | | | | | | | 4867: Cleanup URL handling r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Cleanup URL handlingAleksey Kladov2020-06-131-69/+4
| |
* | Revert "Hide squiggly for unused and unnecessary"Gabriel Valfridsson2020-06-122-3/+2
|/ | | | This reverts commit 599c105e6fabb2b81c2d0a11b86c0c96f6ab1b88.
* Merge branch 'master' into compute-lazy-assitsMikhail Rakhmanov2020-06-032-2/+3
|\ | | | | | | | | | | # Conflicts: # crates/rust-analyzer/src/main_loop/handlers.rs # crates/rust-analyzer/src/to_proto.rs
| * Hide squiggly for unused and unnecessaryGabriel Valfridsson2020-06-032-2/+3
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 16:30:51 +0100