aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Merge #6430bors[bot]2020-11-0310-1355/+1781
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6430: Move completions rendering into a separate module r=popzxc a=popzxc This PR extracts rendering-related things from `Completions` structure to the new `render` module. `render` module declares a `Render` structure (which is a generic renderer interface), `RenderContext` (interface for data/methods not required for completions generating, but required for rendering), and a bunch of smaller `*Render` structures which encapsulate logic behind rendering a certain item. This is just a step in full separation direction, since the following this are still to be done: - Move some data from `CompletionContext` to the `RenderContext`; - Forbid any kind of rendering outside of `render` module; - Extract score computing into a separate module. This PR is already pretty big, so not to make it even harder to review I decided to split this process into several subsequent PRs. Co-authored-by: Igor Aleksanov <[email protected]>
| * Remove intra-crate facade from completionsIgor Aleksanov2020-11-032-10/+16
| |
| * Get rid of do-er antipatternIgor Aleksanov2020-11-037-45/+100
| |
| * Provide only explicit constructor for RenderContextIgor Aleksanov2020-11-032-16/+14
| |
| * Add doc-comments to the new filesIgor Aleksanov2020-11-036-1/+17
| |
| * Make structures order more logical in render.rsIgor Aleksanov2020-11-031-5/+5
| |
| * Move rendering tests to the render moduleIgor Aleksanov2020-11-036-1095/+1163
| |
| * Add TypeAliasRenderIgor Aleksanov2020-11-034-19/+54
| |
| * Add ConstRenderIgor Aleksanov2020-11-035-28/+65
| |
| * Introduce render moduleIgor Aleksanov2020-11-037-246/+457
| |
* | Improve decl_check module readabilityIgor Aleksanov2020-11-031-6/+6
| |
* | Remove numbers from comments in decl_check.rsIgor Aleksanov2020-11-031-15/+15
| |
* | Check for allow(..) attributes for case diagnosticIgor Aleksanov2020-11-031-25/+91
|/
* Merge #6445bors[bot]2020-11-021-14/+14
|\ | | | | | | | | | | | | | | | | | | | | 6445: Fix coalescing of prime_caches updates r=jonas-schievink a=jonas-schievink The previous implementation could try to create a progress bar when one was already registered. bors r+ :robot: Co-authored-by: Jonas Schievink <[email protected]>
| * Fix coalescing of prime_caches updatesJonas Schievink2020-11-021-14/+14
| | | | | | | | | | The previous implementation could try to create a progress bar when one was already registered
* | Merge #6365bors[bot]2020-11-022-41/+121
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6365: Do insertion lookahead in algo::diff r=matklad a=Veykril This is the last blocker for #6287 after this I can update that PR to properly fix things through using `SyntaxRewriter`. This PR also shuffles tests around a bit and adds some more. Ideally this is just a hack until we implement a "proper" diff algorithm that approximates a minimal diff. Maybe something like [gumtree](https://github.com/GumTreeDiff/gumtree)? Co-authored-by: Lukas Wirth <[email protected]>
| * | Do insertion lookahead in algo::diffLukas Wirth2020-10-262-41/+121
| | |
| | |
| \ \
*-. \ \ Merge #6393 #6399bors[bot]2020-11-022-15/+275
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6393: Remove repetitive inlay hints (take 2) r=matklad a=lnicola 6399: Keep generic annotations when qualifying things r=matklad a=Veykril The `qualify_path` assists currently eats up already annotated generics in all but one cases which can be annoying if one already pre-fills generics of a type before it's been qualified. Co-authored-by: Matthew Sanetra <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| | * | Keep generic annotations when qualifying thingsLukas Wirth2020-10-291-13/+169
| | | |
| * | | Add check if param name is similar to fn nameMatthew Sanetra2020-10-281-2/+106
| | | |
* | | | Remove unnecessary cloneJonas Schievink2020-11-021-1/+1
| | | |
* | | | Merge #6441bors[bot]2020-11-021-9/+34
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6441: Coalesce prime_caches updates r=matklad a=jonas-schievink This reduces the number of progress bar updates we send to the client by collapsing subsequent updates into one. This doesn't work as well as I'd hoped (which is that we end up sending *no* updates, or only `start` and `end`, when the cache is already fresh), but it does reduce the number considerably: instead of ~720 updates on the rust-analyzer codebase, we now only send ~60. It uses the same approach that is already in use for coalescing VFS events. Hopefully this is enough to fix https://github.com/rust-analyzer/rust-analyzer/issues/6413. Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Remove debug printJonas Schievink2020-11-021-1/+0
| | | | |
| * | | | Coalesce prime_caches updatesJonas Schievink2020-11-021-9/+35
| | | | |
* | | | | Bump chalk and lexerkjeremy2020-11-022-4/+4
|/ / / /
* | | | Remove more unreachable pubsAleksey Kladov2020-11-0235-117/+110
| | | |
* | | | Deny unreachable-pubAleksey Kladov2020-11-0229-149/+148
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's very useful when `pub` is equivalent to "this is crate's public API", let's enforce this! Ideally, we should enforce it for local `cargo test`, and only during CI, but that needs https://github.com/rust-lang/cargo/issues/5034.
* | | | Update Cargo.tomlPavan Kumar Sunkara2020-10-311-1/+1
| | | |
* | | | Merge #6416bors[bot]2020-10-303-58/+62
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6416: Respond with JSON-RPC error if we failed to deserialize request r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Respond with JSON-RPC error if we failed to deserialize requestAleksey Kladov2020-10-303-58/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Historically, we intentinally violated JSON-RPC spec here by hard crashing. The idea was to poke both the clients and servers to fix stuff. However, this is confusing for server implementors, and falls down in one important place -- protocol extension are not always backwards compatible, which causes crashes simply due to version mismatch. We had once such case with our own extension, and one for semantic tokens. So let's be less adventerous and just err on the err side!
* | | | | Upgrade Chalk to 0.36Florian Diebold2020-10-305-319/+179
|/ / / / | | | | | | | | | | | | Quite a few changes, because Chalk got rid of the `ApplicationTy` nesting.
* | | | remove FIXME after rust 1.47 comes outyuqing2020-10-301-6/+1
| | | |
* | | | refactor(hir_ty): do not override DisplayTarget in hir_fmtBenjamin Coenen2020-10-281-45/+68
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #6387bors[bot]2020-10-283-13/+72
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6387: do not use associated types placeholder for inlay hint r=flodiebold a=bnjjj close #6191 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-284-8/+17
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-283-60/+44
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-286-155/+108
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | do not use associated types placeholder for inlay hintBenjamin Coenen2020-10-282-31/+102
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | do not use associated types placeholder for inlay hint #6191Benjamin Coenen2020-10-273-19/+61
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | Merge #6384bors[bot]2020-10-281-3/+67
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6384: add doctest runnables on struct r=lnicola a=bnjjj I will check for how to do the same on trait implementation on another PR. #6356 Co-authored-by: Benjamin Coenen <[email protected]>
| * | | | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | add doctest runnables on struct #6356Benjamin Coenen2020-10-271-3/+67
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | Merge #6379bors[bot]2020-10-273-0/+15
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6379: Highlight never type as BuiltinType r=matklad a=Veykril Fixes #6374 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Highlight never type as BuiltinTypeLukas Wirth2020-10-263-0/+15
| | |/ / | |/| |
* | | | Merge #6376bors[bot]2020-10-274-1/+26
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6376: Avoid impls_fnonce to return true when the trait solving is ambiguous r=flodiebold a=GrayJack This PR should fix #6375 This adds a variation of `method_resolution::implements_trait` called `method_resolution::implements_trait_unique`, that only returns true when the trait solving is unique, and also change `impls_fnonce` to use the later instead. I also added a test just to be sure. Co-authored-by: GrayJack <[email protected]>
| * | | | Fix testGrayJack2020-10-261-158/+158
| | | | |
| * | | | Add test to avoid regressionGrayJack2020-10-262-153/+165
| | | | |
| * | | | Fix case where non FnOnce variables is marked callableGrayJack2020-10-262-1/+14
| | |/ / | |/| |
* | | | Merge #6257bors[bot]2020-10-261-11/+11
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | 6257: Don't suggest extracting out 1-tuple enum variants r=matklad a=repnop Fixes #6241. Co-authored-by: Wesley Norris <[email protected]>
| * | | Don't suggest extracting out 1-tuple enum variantsWesley Norris2020-10-261-11/+11
| | | | | | | | | | | | | | | | Fixes #6241.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 21:55:34 +0000