aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Prepare to recompute completions on every keystrokeAleksey Kladov2020-11-161-1/+2
| | | | | If we set `is_incomplete: true`, VS Code will re-query completions after every keypress.
* Merge #6563bors[bot]2020-11-161-0/+46
|\ | | | | | | | | | | | | | | 6563: Don't complete keywords in struct initializers r=matklad a=Veykril Fixes #6562 Co-authored-by: Lukas Wirth <[email protected]>
| * Don't complete keywords in struct literalsLukas Wirth2020-11-161-0/+46
| |
* | Merge #6558bors[bot]2020-11-163-0/+26
|\ \ | |/ |/| | | | | | | | | | | | | 6558: format string highlighting: handle hex + debug type specifier r=matklad a=ruabmbua Should fix https://github.com/rust-analyzer/rust-analyzer/issues/6427 Co-authored-by: Roland Ruckerbauer <[email protected]>
| * format string highlighting: handle hex + debug type specifierRoland Ruckerbauer2020-11-153-0/+26
| |
* | Merge #6552bors[bot]2020-11-155-26/+206
|\ \ | |/ |/| | | | | | | | | | | 6552: Properly handle shorthands in destructure patterns when renaming r=SomeoneToIgnore a=Veykril Fixes #6548 and #6551. Co-authored-by: Lukas Wirth <[email protected]>
| * Cleanup edit_text_range_for_record_field_expr_or_patLukas Wirth2020-11-151-46/+59
| |
| * Use shorthand field syntax in destructuresLukas Wirth2020-11-143-29/+84
| |
| * Properly handle shorthands in destructure patterns when renamingLukas Wirth2020-11-142-6/+69
| |
| * Use shorthand record syntax when renaming struct initializer fieldLukas Wirth2020-11-144-19/+68
| |
* | Merge #6544bors[bot]2020-11-133-4/+117
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6544: add suggestion ..Default::default() for remaining struct fields in a constructor r=bnjjj a=bnjjj I'm not sure I should import `assists` crate inside `completions`, maybe we should move out `FamousDefs` from `assists` ? Let me know :) close #6492 Signed-off-by: Benjamin Coenen <[email protected]> Co-authored-by: Benjamin Coenen <[email protected]>
| * | add suggestion ..Default::default() for remaining struct fields in a ↵Benjamin Coenen2020-11-131-1/+1
| | | | | | | | | | | | | | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]>
| * | add suggestion ..Default::default() for remaining struct fields in a ↵Benjamin Coenen2020-11-133-4/+117
| | | | | | | | | | | | | | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]>
* | | Remove dead codeAleksey Kladov2020-11-131-15/+0
| | |
* | | Cleanup workspace loading a tiny bitAleksey Kladov2020-11-136-41/+35
| | |
* | | Move tricky workspace logic to a separate moduleAleksey Kladov2020-11-132-602/+611
| | |
* | | cleanupAleksey Kladov2020-11-131-0/+0
| | |
* | | Merge #6519bors[bot]2020-11-135-6/+40
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6519: Add "Open Cargo.toml" action r=matklad a=p3achyjr ## What is it? This adds an "open cargo.toml" action from the vscode shell, resolves #6462 ## Test Ran ```cargo xtask install --server``` and ```cargo xtask install --client```, then ```Developer: Reload Window```. ![image](https://user-images.githubusercontent.com/8763808/98614382-2a578f00-22ad-11eb-9811-4a72a54ff6fb.png) When clicked: ![image](https://user-images.githubusercontent.com/8763808/98618176-77d7fa00-22b5-11eb-8788-35256542f3a6.png) Co-authored-by: Anatol Liu <[email protected]>
| * | add open Cargo.toml actionAnatol Liu2020-11-138-38/+46
| | |
* | | Merge #6524bors[bot]2020-11-124-69/+225
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6524: Add support for loading rustc private crates r=matklad a=xldenis This PR presents a solution to the problem of making`rustc_private` crates visible to `rust-analyzer`. Currently developers add dependencies to those crates behind a `cfg(NOT_A_TARGET)` target to prevent `cargo` from building them. This solution is unsatisfactory since it requires modifying `Cargo.toml` and causes problems for collaboration or CI. The proposed solution suggested by @matklad is to allow users to give RA a path where the `rustc` sources could be found and then load that like a normal workspace. This PR implements this solution by adding a `rustcSource` configuration item and adding the cargo metadata to the crate graph if it is provided. ------ I have no idea how this should be tested, or if this code is generally tested at all. I've locally run the extension with these changes and it correctly loads the relevant crates on a `rustc_private` project of mine. Co-authored-by: Xavier Denis <[email protected]>
| * | | Address review commentsXavier Denis2020-11-121-3/+2
| | | |
| * | | Reorder rustc_private loadingXavier Denis2020-11-111-87/+86
| | | |
| * | | Add support for loading rustc private cratesXavier Denis2020-11-114-69/+227
| | | |
* | | | Merge #6514bors[bot]2020-11-121-28/+92
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6514: Fix extract_struct_from_enum_variant not updating record references r=Veykril a=Veykril Related to #6510 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Add extra test to extract_struct_from_enum_variantLukas Wirth2020-11-121-1/+28
| | | | |
| * | | | Use Module::find_use_path_prefixed in extract_struct_from_enum_variant assistLukas Wirth2020-11-121-5/+9
| | | | |
| * | | | Fix extract_struct_from_enum_variant not updating record referencesLukas Wirth2020-11-121-26/+59
| | | | |
* | | | | Merge #6513bors[bot]2020-11-121-1/+82
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6513: Support qualified function calls in remove_unused_param r=Veykril a=Veykril Also adds a test to check that it removes unused params across files. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Support qualified function calls in remove_unused_paramLukas Wirth2020-11-121-1/+49
| | | | | |
| * | | | | Add multiple file edit tes to remove_unused_param assistLukas Wirth2020-11-091-0/+33
| |/ / / /
* | | | | Remove the fixmeKirill Bulatov2020-11-121-36/+15
| | | | |
* | | | | Add a FIXME for non-unified inner attributesKirill Bulatov2020-11-121-2/+7
| | | | |
* | | | | Do not insert imports before inner commentsKirill Bulatov2020-11-121-18/+92
| |_|_|/ |/| | |
* | | | Fix attachment of inner doc commentsAleksey Kladov2020-11-123-19/+33
| | | |
* | | | Simplify codeAleksey Kladov2020-11-121-28/+23
| | | |
* | | | Update testsAleksey Kladov2020-11-1210-21/+168
| | | |
* | | | Update crateskjeremy2020-11-111-1/+1
| | | |
* | | | Replace RacyFlag with OnceCellAleksey Kladov2020-11-113-32/+6
| |_|/ |/| |
* | | Be more pedantic when checking codeAction/resolve supportAleksey Kladov2020-11-101-3/+6
| |/ |/|
* | Switch to upstream protocol for resolving code actionAleksey Kladov2020-11-1011-46/+67
| | | | | | | | | | | | Note that we have to maintain custom implementation on the client side: I don't see how to marry bulitin resolve support with groups and snippets.
* | Merge #6512bors[bot]2020-11-091-36/+89
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6512: Don't replace parent node when inserting as first child in algo::diff r=SomeoneToIgnore a=Veykril This makes the diff a bit more detailed. See https://github.com/rust-analyzer/rust-analyzer/pull/6287#issuecomment-723889267 for context cc @SomeoneToIgnore Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't replace parent node when inserting as first child in algo::diffLukas Wirth2020-11-091-36/+89
| | |
* | | Merge #6472bors[bot]2020-11-097-3/+95
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6472: Add `static` modifier for associated functions r=matklad a=p3achyjr Adds static semantic token modifier to associated functions, resolves #6194 ## Info - Associated functions are more-or-less equivalent to static methods in other languages. This PR checks, for each function, whether that function has a self_param, and whether it's enclosed in a trait/impl. ## Changes - Added method ```is_associated``` to code_model::Function. This basically gets the source from the ast, and checks whether the enclosing scope is an impl or trait. - Added `static` to HighlightModifiers - Added unit test ## Tests - Ran ```cargo test``` Co-authored-by: Anatol Liu <[email protected]>
| * | Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-092-16/+3
| | | | | | | | | | | | | | | | | | refactor logic into code_model.rs address comments
| * | Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-082-6/+2
| | | | | | | | | | | | | | | | | | refactor logic into code_model.rs address comments
| * | Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-051-5/+1
| | | | | | | | | | | | | | | | | | refactor logic into code_model.rs address comments
| * | Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-051-1/+1
| | | | | | | | | | | | refactor logic into code_model.rs
| * | Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-052-17/+22
| | | | | | | | | | | | refactor logic into code_model.rs
| * | Add static semantic token modifier for associated functions with no &selfAnatol Liu2020-11-058-2/+110
| | |
* | | . is an operatorAleksey Kladov2020-11-095-28/+30
| | | | | | | | | | | | closes #6498