aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Link rustc error codes in diagnosticsLukas Wirth2020-11-181-3/+19
|
* Merge #6553bors[bot]2020-11-1721-96/+368
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6553: Auto imports in completion r=matklad a=SomeoneToIgnore ![completion](https://user-images.githubusercontent.com/2690773/99155339-ae4fb380-26bf-11eb-805a-655b1706ce70.gif) Closes https://github.com/rust-analyzer/rust-analyzer/issues/1062 but does not handle the completion order, since it's a separate task for https://github.com/rust-analyzer/rust-analyzer/issues/4922 , https://github.com/rust-analyzer/rust-analyzer/issues/4922 and maybe something else. 2 quirks in the current implementation: * traits are not auto imported during method completion If I understand the current situation right, we cannot search for traits by a **part** of a method name, we need a full name with correct case to get a trait for it. * VSCode (?) autocompletion is not as rigid as in Intellij Rust as you can notice on the animation. Intellij is able to refresh the completions on every new symbol added, yet VS Code does not query the completions on every symbol for me. With a few debug prints placed in RA, I've observed the following behaviour: after the first set of completion suggestions is received, next symbol input does not trigger a server request, if the completions contain this symbol. When more symbols added, the existing completion suggestions are filtered out until none are left and only then, on the next symbol it queries for completions. It seems like the only alternative to get an updated set of results is to manually retrigger it with Esc and Ctrl + Space. Despite the eerie latter bullet, the completion seems to work pretty fine and fast nontheless, but if you have any ideas on how to make it more smooth, I'll gladly try it out. Co-authored-by: Kirill Bulatov <[email protected]>
| * Actually enable eager completionKirill Bulatov2020-11-171-1/+1
| |
| * Avoid turning completion objects into buildersKirill Bulatov2020-11-169-84/+117
| |
| * Remove query aliasesKirill Bulatov2020-11-163-10/+10
| |
| * Properly fill the completion settingsKirill Bulatov2020-11-161-4/+5
| |
| * Fix the other testKirill Bulatov2020-11-162-3/+25
| |
| * Qualify autoimport completion suggestionsKirill Bulatov2020-11-162-16/+43
| |
| * Better filter mod pathsKirill Bulatov2020-11-162-26/+28
| |
| * Move autoimport completion into the unqialified_path moduleKirill Bulatov2020-11-165-156/+139
| |
| * Omit modules during autocompletionKirill Bulatov2020-11-161-13/+13
| |
| * Tweak the search limits a bitKirill Bulatov2020-11-162-3/+6
| |
| * Reuse existing element renderingKirill Bulatov2020-11-164-88/+74
| |
| * Use imports_locatorKirill Bulatov2020-11-166-86/+119
| |
| * Rename the moduleKirill Bulatov2020-11-162-6/+2
| |
| * Allow to configure the merge behaviorKirill Bulatov2020-11-162-5/+6
| |
| * Add braces to functions and macrosKirill Bulatov2020-11-162-39/+99
| |
| * Tidy up the testsKirill Bulatov2020-11-161-49/+15
| |
| * Use rewriter api to add both changesKirill Bulatov2020-11-161-11/+51
| |
| * Add imports in auto completionKirill Bulatov2020-11-1613-25/+144
| |
* | Merge #6582bors[bot]2020-11-174-12/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6582: Fill the diagnostic code field in publish_diagnostics r=kjeremy a=Veykril Fixes #6580 Before: ![Code_znn6VgLLH9](https://user-images.githubusercontent.com/3757771/99408084-213f7100-28f0-11eb-8317-3f5c2b93313d.png) After: ![Code_c4jJsvzOEA](https://user-images.githubusercontent.com/3757771/99408096-23093480-28f0-11eb-9bb2-8ebf2fb3d5a1.png) Co-authored-by: Lukas Wirth <[email protected]>
| * | Fill the diagnostic code field in publish_diagnosticsLukas Wirth2020-11-174-12/+38
| | |
* | | SimplifyAleksey Kladov2020-11-171-54/+50
| | |
* | | Make code more readableAleksey Kladov2020-11-171-186/+207
| | |
* | | MinorAleksey Kladov2020-11-171-4/+4
| | |
* | | Remove dead codeAleksey Kladov2020-11-171-6/+0
| | |
* | | SimplifyAleksey Kladov2020-11-172-17/+15
| | |
* | | Use standard code style for test fixturesAleksey Kladov2020-11-171-270/+270
| | |
* | | **Unwrap Block** supports stand-alone blocksAleksey Kladov2020-11-171-1/+68
| | |
* | | SimplifyAleksey Kladov2020-11-171-3/+1
| | |
* | | Assist target should point at *existing* codeAleksey Kladov2020-11-171-1/+1
| | |
* | | Add **Ignore Test** assistAleksey Kladov2020-11-176-18/+80
| | |
* | | Merge #6571bors[bot]2020-11-173-108/+75
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6571: Cleanup project model r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | Remove needless allocAleksey Kladov2020-11-171-1/+1
| | | |
| * | | Compress codeAleksey Kladov2020-11-172-66/+42
| | | |
| * | | simplifyAleksey Kladov2020-11-171-41/+32
| | |/ | |/|
* / | Latest LSP 3.16 protocolkjeremy2020-11-1610-27/+26
|/ / | | | | | | Pulls in https://github.com/gluon-lang/lsp-types/pull/186
* / Prepare to recompute completions on every keystrokeAleksey Kladov2020-11-161-1/+2
|/ | | | | If we set `is_incomplete: true`, VS Code will re-query completions after every keypress.
* Merge #6563bors[bot]2020-11-161-0/+46
|\ | | | | | | | | | | | | | | 6563: Don't complete keywords in struct initializers r=matklad a=Veykril Fixes #6562 Co-authored-by: Lukas Wirth <[email protected]>
| * Don't complete keywords in struct literalsLukas Wirth2020-11-161-0/+46
| |
* | Merge #6558bors[bot]2020-11-163-0/+26
|\ \ | |/ |/| | | | | | | | | | | | | 6558: format string highlighting: handle hex + debug type specifier r=matklad a=ruabmbua Should fix https://github.com/rust-analyzer/rust-analyzer/issues/6427 Co-authored-by: Roland Ruckerbauer <[email protected]>
| * format string highlighting: handle hex + debug type specifierRoland Ruckerbauer2020-11-153-0/+26
| |
* | Merge #6552bors[bot]2020-11-155-26/+206
|\ \ | |/ |/| | | | | | | | | | | 6552: Properly handle shorthands in destructure patterns when renaming r=SomeoneToIgnore a=Veykril Fixes #6548 and #6551. Co-authored-by: Lukas Wirth <[email protected]>
| * Cleanup edit_text_range_for_record_field_expr_or_patLukas Wirth2020-11-151-46/+59
| |
| * Use shorthand field syntax in destructuresLukas Wirth2020-11-143-29/+84
| |
| * Properly handle shorthands in destructure patterns when renamingLukas Wirth2020-11-142-6/+69
| |
| * Use shorthand record syntax when renaming struct initializer fieldLukas Wirth2020-11-144-19/+68
| |
* | Merge #6544bors[bot]2020-11-133-4/+117
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6544: add suggestion ..Default::default() for remaining struct fields in a constructor r=bnjjj a=bnjjj I'm not sure I should import `assists` crate inside `completions`, maybe we should move out `FamousDefs` from `assists` ? Let me know :) close #6492 Signed-off-by: Benjamin Coenen <[email protected]> Co-authored-by: Benjamin Coenen <[email protected]>
| * | add suggestion ..Default::default() for remaining struct fields in a ↵Benjamin Coenen2020-11-131-1/+1
| | | | | | | | | | | | | | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]>
| * | add suggestion ..Default::default() for remaining struct fields in a ↵Benjamin Coenen2020-11-133-4/+117
| | | | | | | | | | | | | | | | | | constructor #6492 Signed-off-by: Benjamin Coenen <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-28 09:30:32 +0000